Case 13007 Cannot-integrate-a-slice-with-monticello-red-square-in-the-UI
Priority 2 fix ready for review. Please come pick it apart. https://pharo.fogbugz.com/f/cases/13007/Cannot-integrate-a-slice-with-montic... cheers -ben
Hi I did not check the latest submission but to me putting a mutex on list looks like a bad decision. May be the original forking of the project list is the problem. What is the point of view of the people that work on the issue. Forking to get speed is often a way to pay high price after. Synchronisation points are important. Stef On 07 Apr 2014, at 18:36, Ben Coman <btc@openInWorld.com> wrote:
Priority 2 fix ready for review. Please come pick it apart. https://pharo.fogbugz.com/f/cases/13007/Cannot-integrate-a-slice-with-montic... cheers -ben
super! On 08 Apr 2014, at 02:28, Ben Coman <btc@openInWorld.com> wrote:
Pharo4Stef wrote:
Hi
I did not check the latest submission but to me putting a mutex on list looks like a bad decision. May be the original forking of the project list is the problem.
What is the point of view of the people that work on the issue. Forking to get speed is often a way to pay high price after. Synchronisation points are important.
Stef On 07 Apr 2014, at 18:36, Ben Coman <btc@openInWorld.com> wrote:
Priority 2 fix ready for review. Please come pick it apart. https://pharo.fogbugz.com/f/cases/13007/Cannot-integrate-a-slice-with-montic... cheers -ben
The fix no longer uses the mutex idea. We've refactored the per-keypress update from 2500ms down to 200ms. As well the fork has been moved within the calculation method such that object state is not updated until after the calculation, and is then the instance variable assignment is wrapped by a #defer: which should take care of the race condition with the #drawOn:
Its now been reviewed by Nicolai. Just need one more. cheers -ben
participants (2)
-
Ben Coman -
Pharo4Stef