How to integrate change on class Point
Hi I would like to remove some dusts in the class Point. No decent class comments, cleaning typo in organisation and cleaning some method comments. In fact I should do a real pass. Now I published https://pharo.fogbugz.com/f/cases/16953/Clean-Point-Reciprocal-comment-and-i... When I merged the slice I get a classBuilder warning and it means that my changes cannot be loaded and it fails of course. I do not like this classBuilder warning in fact. I can break Pharo in one line of code even with it. So may be in pharo dev mode we should not get it. So what is the way to do it properly. Stef
There is a trick Tx henrik DangerousClassNotifier disable :) Le 8/11/15 21:32, stepharo a écrit :
Hi
I would like to remove some dusts in the class Point. No decent class comments, cleaning typo in organisation and cleaning some method comments. In fact I should do a real pass. Now I published https://pharo.fogbugz.com/f/cases/16953/Clean-Point-Reciprocal-comment-and-i...
When I merged the slice I get a classBuilder warning and it means that my changes cannot be loaded and it fails of course. I do not like this classBuilder warning in fact. I can break Pharo in one line of code even with it. So may be in pharo dev mode we should not get it. So what is the way to do it properly.
Stef
On 08 Nov 2015, at 18:23, stepharo <stepharo@free.fr> wrote:
There is a trick Tx henrik DangerousClassNotifier disable :)
Yes, but we should actually fix the class builder to not raise the error when just changing a comment⦠but then, this happens not often so I did not yet even report an issue for it. Marcus
so when does it report it? When we redefine a method? Le 9/11/15 12:05, Marcus Denker a écrit :
On 08 Nov 2015, at 18:23, stepharo <stepharo@free.fr> wrote:
There is a trick Tx henrik DangerousClassNotifier disable :)
Yes, but we should actually fix the class builder to not raise the error when just changing a comment⦠but then, this happens not often so I did not yet even report an issue for it.
Marcus
I think it would be enough to do it when the shape of the class changes (adding/removing variables). Marcus
On 09 Nov 2015, at 12:07, stepharo <stepharo@free.fr> wrote:
so when does it report it? When we redefine a method?
Le 9/11/15 12:05, Marcus Denker a écrit :
On 08 Nov 2015, at 18:23, stepharo <stepharo@free.fr> wrote:
There is a trick Tx henrik DangerousClassNotifier disable :)
Yes, but we should actually fix the class builder to not raise the error when just changing a comment⦠but then, this happens not often so I did not yet even report an issue for it.
Marcus
participants (2)
-
Marcus Denker -
stepharo