Iceberg left:right
Hi Esteban did you change the left right order in the diff tool? I'm super confused in the latest version doing a code review. I have left: workingcopy right: incoming updates Is right the change proposed? What is the workingcopy? My image? Because as you can see in the attached screeshot the right is showing what is in the image. It is super difficult to understand anything. I checked with github and incoming is the image and workingcopy the proposed fix!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Argh. Is it only me? Can you fix this important glitch? Stef
yes, is super confusing and is completely mixed :( Iâm working on the changes with this in mind. In the future, all diffs with be show with: left old/right new metaphor (problem is even that will have some problems, but at least it will be coherent) Esteban
On 17 Feb 2018, at 08:23, Stephane Ducasse <stepharo.self@gmail.com> wrote:
Hi Esteban
did you change the left right order in the diff tool? I'm super confused in the latest version doing a code review.
I have left: workingcopy right: incoming updates
Is right the change proposed? What is the workingcopy? My image?
Because as you can see in the attached screeshot the right is showing what is in the image. It is super difficult to understand anything.
I checked with github and incoming is the image and workingcopy the proposed fix!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Argh. Is it only me? Can you fix this important glitch?
Stef <Screen Shot 2018-02-17 at 08.20.43.png><Screen Shot 2018-02-17 at 08.22.43.png>
Tx On Sat, Feb 17, 2018 at 9:31 AM, Esteban Lorenzano <estebanlm@gmail.com> wrote:
yes, is super confusing and is completely mixed :(
Iâm working on the changes with this in mind. In the future, all diffs with be show with: left old/right new metaphor (problem is even that will have some problems, but at least it will be coherent)
Esteban
On 17 Feb 2018, at 08:23, Stephane Ducasse <stepharo.self@gmail.com> wrote:
Hi Esteban
did you change the left right order in the diff tool? I'm super confused in the latest version doing a code review.
I have left: workingcopy right: incoming updates
Is right the change proposed? What is the workingcopy? My image?
Because as you can see in the attached screeshot the right is showing what is in the image. It is super difficult to understand anything.
I checked with github and incoming is the image and workingcopy the proposed fix!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Argh. Is it only me? Can you fix this important glitch?
Stef <Screen Shot 2018-02-17 at 08.20.43.png><Screen Shot 2018-02-17 at 08.22.43.png>
participants (2)
-
Esteban Lorenzano -
Stephane Ducasse