Status: Fixed Owner: stephane.ducasse Labels: Milestone-1.2 Difficulty-Easy New issue 3240 by stephane.ducasse: be more explicit about attribute changes to gain another 5-10x speedup http://code.google.com/p/pharo/issues/detail?id=3240 Levente Uzonyi uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ul.390.mcz ==================== Summary ==================== Name: System-ul.390 Author: ul Time: 4 November 2010, 10:44:58.211 pm UUID: 57baf4d2-ec35-614b-875e-bfbca4d9cbf2 Ancestors: System-ul.389 - be more explicit about attribute changes to gain another 5-10x speedup =============== Diff against System-ul.389 =============== Item was changed: ----- Method: ClassDiffBuilder>>print:withAttributes:on: (in category 'private') ----- print: aString withAttributes: attributes on: stream stream + currentAttributes: attributes; + nextPutAll: aString! - withAttributes: attributes - do: [ stream nextPutAll: aString ]! Item was changed: ----- Method: TextDiffBuilder>>print:withAttributes:on: (in category 'private') ----- print: aString withAttributes: attributes on: stream stream + currentAttributes: attributes; + nextPutAll: aString. + (aString notEmpty and: [ + aString last = Character cr or: [ + aString endsWith: String crlf ] ]) + ifFalse: [ stream cr ]! - withAttributes: attributes - do: [ - stream nextPutAll: aString. - (aString notEmpty and: [ - aString last = Character cr or: [ - aString endsWith: String crlf ] ]) - ifFalse: [ stream cr ] ]!