[Pharo-project] Change in MCCacheRepository that affects Metacello loading
Hi Dale. http://code.google.com/p/pharo/issues/detail?id=6405 renames MCCacheRepository #default to #uniqueInstance. Therefore, to be able to bootstrap Metacello we need to change: ConfigurationOfMetacello class >> bootstrapPackage: aString from: aPath | repository version | repository := (*MCCacheRepository uniqueInstance* includesVersionNamed: aString) ifTrue: [*MCCacheRepository uniqueInstance*] ifFalse: [MCHttpRepository location: aPath user: '' password: '']. repository versionReaderForFileNamed: aString , '.mcz' do: [:reader | version := reader version. version load. version workingCopy repositoryGroup addRepository: repository] I could commit, but I don't want to break Metacello loading in other images and I don't know how do you handle these cases. Thanks, -- Mariano http://marianopeck.wordpress.com
may be we should rollback this changes because it is not mandatory. Stef On Jul 23, 2012, at 10:14 AM, Mariano Martinez Peck wrote:
Hi Dale. http://code.google.com/p/pharo/issues/detail?id=6405 renames MCCacheRepository #default to #uniqueInstance. Therefore, to be able to bootstrap Metacello we need to change:
ConfigurationOfMetacello class >> bootstrapPackage: aString from: aPath | repository version | repository := (MCCacheRepository uniqueInstance includesVersionNamed: aString) ifTrue: [MCCacheRepository uniqueInstance] ifFalse: [MCHttpRepository location: aPath user: '' password: '']. repository versionReaderForFileNamed: aString , '.mcz' do: [:reader | version := reader version. version load. version workingCopy repositoryGroup addRepository: repository]
I could commit, but I don't want to break Metacello loading in other images and I don't know how do you handle these cases.
Thanks,
-- Mariano http://marianopeck.wordpress.com
Yeah, if you could hold off on that change for a bit (this is for Pharo-2.0 right?)...I might have a different solution for Pharo-2.0... Dale ----- Original Message ----- | From: "Stéphane Ducasse" <stephane.ducasse@inria.fr> | To: Pharo-project@lists.gforge.inria.fr | Cc: metacello@googlegroups.com | Sent: Monday, July 23, 2012 1:41:58 AM | Subject: Re: [Pharo-project] Change in MCCacheRepository that affects Metacello loading | | may be we should rollback this changes because it is not mandatory. | | Stef | | On Jul 23, 2012, at 10:14 AM, Mariano Martinez Peck wrote: | | > Hi Dale. http://code.google.com/p/pharo/issues/detail?id=6405 | > renames MCCacheRepository #default to #uniqueInstance. Therefore, | > to be able to bootstrap Metacello we need to change: | > | > ConfigurationOfMetacello class >> bootstrapPackage: aString from: | > aPath | > | repository version | | > repository := (MCCacheRepository uniqueInstance | > includesVersionNamed: aString) | > ifTrue: [MCCacheRepository uniqueInstance] | > ifFalse: [MCHttpRepository | > location: aPath | > user: '' | > password: '']. | > repository | > versionReaderForFileNamed: aString , '.mcz' | > do: [:reader | | > version := reader version. | > version load. | > version workingCopy repositoryGroup addRepository: repository] | > | > I could commit, but I don't want to break Metacello loading in | > other images and I don't know how do you handle these cases. | > | > Thanks, | > | > | > -- | > Mariano | > http://marianopeck.wordpress.com | > | | |
mariano can you create an issue and a fix so that we do not forget. stef On Jul 23, 2012, at 6:24 PM, Dale Henrichs wrote:
Yeah, if you could hold off on that change for a bit (this is for Pharo-2.0 right?)...I might have a different solution for Pharo-2.0...
Dale
----- Original Message ----- | From: "Stéphane Ducasse" <stephane.ducasse@inria.fr> | To: Pharo-project@lists.gforge.inria.fr | Cc: metacello@googlegroups.com | Sent: Monday, July 23, 2012 1:41:58 AM | Subject: Re: [Pharo-project] Change in MCCacheRepository that affects Metacello loading | | may be we should rollback this changes because it is not mandatory. | | Stef | | On Jul 23, 2012, at 10:14 AM, Mariano Martinez Peck wrote: | | > Hi Dale. http://code.google.com/p/pharo/issues/detail?id=6405 | > renames MCCacheRepository #default to #uniqueInstance. Therefore, | > to be able to bootstrap Metacello we need to change: | > | > ConfigurationOfMetacello class >> bootstrapPackage: aString from: | > aPath | > | repository version | | > repository := (MCCacheRepository uniqueInstance | > includesVersionNamed: aString) | > ifTrue: [MCCacheRepository uniqueInstance] | > ifFalse: [MCHttpRepository | > location: aPath | > user: '' | > password: '']. | > repository | > versionReaderForFileNamed: aString , '.mcz' | > do: [:reader | | > version := reader version. | > version load. | > version workingCopy repositoryGroup addRepository: repository] | > | > I could commit, but I don't want to break Metacello loading in | > other images and I don't know how do you handle these cases. | > | > Thanks, | > | > | > -- | > Mariano | > http://marianopeck.wordpress.com | > | | |
On Mon, Jul 23, 2012 at 6:24 PM, Dale Henrichs <dhenrich@vmware.com> wrote:
Yeah, if you could hold off on that change for a bit (this is for Pharo-2.0 right?)...I might have a different solution for Pharo-2.0...
Dale, our jenkins jobs were unable to build because we are unable to bootstrap Metacello. Metacello is so important for us that we prefer to fix it immediately and give time for you ;) http://code.google.com/p/**pharo/issues/detail?id=6442<http://code.google.com/p/pharo/issues/detail?id=6442> So....when you have fixed a released a new version of Metacello, let us know and we just remove the method. thanks!
Dale
----- Original Message ----- | From: "Stéphane Ducasse" <stephane.ducasse@inria.fr> | To: Pharo-project@lists.gforge.inria.fr | Cc: metacello@googlegroups.com | Sent: Monday, July 23, 2012 1:41:58 AM | Subject: Re: [Pharo-project] Change in MCCacheRepository that affects Metacello loading | | may be we should rollback this changes because it is not mandatory. | | Stef | | On Jul 23, 2012, at 10:14 AM, Mariano Martinez Peck wrote: | | > Hi Dale. http://code.google.com/p/pharo/issues/detail?id=6405 | > renames MCCacheRepository #default to #uniqueInstance. Therefore, | > to be able to bootstrap Metacello we need to change: | > | > ConfigurationOfMetacello class >> bootstrapPackage: aString from: | > aPath | > | repository version | | > repository := (MCCacheRepository uniqueInstance | > includesVersionNamed: aString) | > ifTrue: [MCCacheRepository uniqueInstance] | > ifFalse: [MCHttpRepository | > location: aPath | > user: '' | > password: '']. | > repository | > versionReaderForFileNamed: aString , '.mcz' | > do: [:reader | | > version := reader version. | > version load. | > version workingCopy repositoryGroup addRepository: repository] | > | > I could commit, but I don't want to break Metacello loading in | > other images and I don't know how do you handle these cases. | > | > Thanks, | > | > | > -- | > Mariano | > http://marianopeck.wordpress.com | > | | |
-- Mariano http://marianopeck.wordpress.com
participants (3)
-
Dale Henrichs -
Mariano Martinez Peck -
Stéphane Ducasse