Progress Report -> Refactoring Project - ( January 4 - 8 )
Hello everyone. Last week I did these tasks: - Fix PR of "extract method and occurrences" refactoring ( https://github.com/pharo-project/pharo/pull/8193). - Fix "replace senders of message by another message" refactoring, the modification is for replace in all classes or only in owner class, this can be scale to replace in determinated classes ( https://github.com/pharo-project/pharo/pull/8314). - Divide coupled logic between commands, views and refactorings (to remove NautilusRefactoring class). - Review how to fix Undo Refactoring issue. Tasks for this week: - Fix undo refactoring issue. - Migrate extract method to refactoring2. - Review how migrate all refactoring commands to commander2 now only works in source code context. - Fix rename protocol issue ( https://github.com/pharo-project/pharo/issues/4461). - Fix add argument issue (https://github.com/pharo-project/pharo/issues/5852 ). Cheers, Evelyn
Hi Evelyn - Iâm glad your making progress on the refactorings - they were very unloved - to the point I had mostly stopped using them as they were either broken or didnât work right. Given refactoring was basically invented in Smalltalk we had got into a bad place in the Pharo IDE so I am so pleased to see this getting sorted - and hopefully we can get back to a position where ours work as well as those in IntelliJ or Eclipse. On this note - I havenât noticed whether there is some work to add decent keystroke shortcuts to the most important ones so that you do them quickly. I am equally hopeful ⦠that its a bit easier for us to write some of our own as there are some higher level ones that I would like to try creating (but gave up on as it wasnât particularly obvious how to do it). The mention of refactoring2 sounds promising. Anyway - just wanted to add a big thumbs up. Tim On Mon, 11 Jan 2021, at 3:09 AM, EVELYN CUSI LOPEZ wrote:
Hello everyone.
Last week I did these tasks:
- Fix PR of "extract method and occurrences" refactoring (https://github.com/pharo-project/pharo/pull/8193). - Fix "replace senders of message by another message" refactoring, the modification is for replace in all classes or only in owner class, this can be scale to replace in determinated classes (https://github.com/pharo-project/pharo/pull/8314). - Divide coupled logic between commands, views and refactorings (to remove NautilusRefactoring class). - Review how to fix Undo Refactoring issue.
Tasks for this week:
- Fix undo refactoring issue. - Migrate extract method to refactoring2. - Review how migrate all refactoring commands to commander2 now only works in source code context. - Fix rename protocol issue (https://github.com/pharo-project/pharo/issues/4461). - Fix add argument issue (https://github.com/pharo-project/pharo/issues/5852).
Cheers, Evelyn
Hi Tim, Thanks, we are working to have an useful easy to use refactoring tool. Any comment to improve is welcome ⺠El lun, 11 ene 2021 a las 5:23, Tim Mackinnon (<tim@testit.works>) escribió:
Hi Evelyn - Iâm glad your making progress on the refactorings - they were very unloved - to the point I had mostly stopped using them as they were either broken or didnât work right. Given refactoring was basically invented in Smalltalk we had got into a bad place in the Pharo IDE so I am so pleased to see this getting sorted - and hopefully we can get back to a position where ours work as well as those in IntelliJ or Eclipse.
On this note - I havenât noticed whether there is some work to add decent keystroke shortcuts to the most important ones so that you do them quickly. I am equally hopeful ⦠that its a bit easier for us to write some of our own as there are some higher level ones that I would like to try creating (but gave up on as it wasnât particularly obvious how to do it). The mention of refactoring2 sounds promising.
Anyway - just wanted to add a big thumbs up.
Tim
On Mon, 11 Jan 2021, at 3:09 AM, EVELYN CUSI LOPEZ wrote:
Hello everyone.
Last week I did these tasks:
- Fix PR of "extract method and occurrences" refactoring ( https://github.com/pharo-project/pharo/pull/8193). - Fix "replace senders of message by another message" refactoring, the modification is for replace in all classes or only in owner class, this can be scale to replace in determinated classes ( https://github.com/pharo-project/pharo/pull/8314). - Divide coupled logic between commands, views and refactorings (to remove NautilusRefactoring class). - Review how to fix Undo Refactoring issue.
Tasks for this week:
- Fix undo refactoring issue. - Migrate extract method to refactoring2. - Review how migrate all refactoring commands to commander2 now only works in source code context. - Fix rename protocol issue ( https://github.com/pharo-project/pharo/issues/4461). - Fix add argument issue ( https://github.com/pharo-project/pharo/issues/5852).
Cheers, Evelyn
participants (2)
-
EVELYN CUSI LOPEZ -
Tim Mackinnon