Re: [Pharo-project] OCompletion is broken in 1.3
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
It comes from Toolset change. OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^) Ben 2011/6/9 Marcus Denker <marcus.denker@inria.fr>
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage.
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
It's fixed, I am looking where to post the fix :) Ben 2011/6/9 Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com>
It comes from Toolset change.
OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^)
Ben
2011/6/9 Marcus Denker <marcus.denker@inria.fr>
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage.
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
On Thu, Jun 9, 2011 at 12:45 PM, Benjamin Van Ryseghem < benjamin.vanryseghem.pharo@gmail.com> wrote:
It's fixed, I am looking where to post the fix :)
Thanks!!!!!!!!!!!!! Put it somewhere please :) OCompletionPharoCompatibilty is not enough? you have commit rights there....
Ben
2011/6/9 Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com>
It comes from Toolset change.
OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^)
Ben
2011/6/9 Marcus Denker <marcus.denker@inria.fr>
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage.
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
-- Mariano http://marianopeck.wordpress.com
so...I saw you commit in OCompletion and then rollback the pharo-ish part. So..can that be put instead to OCompletionPharoCompatibilty and we are done? then we update ConfigurationOfOCompletion and we fix it :) On Fri, Jun 10, 2011 at 11:59 AM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
On Thu, Jun 9, 2011 at 12:45 PM, Benjamin Van Ryseghem < benjamin.vanryseghem.pharo@gmail.com> wrote:
It's fixed, I am looking where to post the fix :)
Thanks!!!!!!!!!!!!!
Put it somewhere please :)
OCompletionPharoCompatibilty is not enough? you have commit rights there....
Ben
2011/6/9 Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com>
It comes from Toolset change.
OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^)
Ben
2011/6/9 Marcus Denker <marcus.denker@inria.fr>
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage.
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
In fact, I have posted two things: - a little improvement in OCompletion (not related to the bug) - then I take a look at OCompletionPharoCompatibility, but I have done a mistake because the package is OcompletionPharoCompatibility (with a minus "c") So finally, the only thing I have done to fix the bug is to change the ConfigurationOfOCompletion which now call a post load method to reset the default toolset and take in account the registry method. I hope I haven't done too many stupid things :) Ben On Jun 10, 2011, at 12:05 PM, Mariano Martinez Peck wrote:
so...I saw you commit in OCompletion and then rollback the pharo-ish part. So..can that be put instead to OCompletionPharoCompatibilty and we are done? then we update ConfigurationOfOCompletion and we fix it :)
On Fri, Jun 10, 2011 at 11:59 AM, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
On Thu, Jun 9, 2011 at 12:45 PM, Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com> wrote: It's fixed, I am looking where to post the fix :)
Thanks!!!!!!!!!!!!!
Put it somewhere please :)
OCompletionPharoCompatibilty is not enough? you have commit rights there....
Ben
2011/6/9 Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com> It comes from Toolset change.
OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^)
Ben
2011/6/9 Marcus Denker <marcus.denker@inria.fr>
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage.
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
THanks ben for all your help. It is fixed now. On Fri, Jun 10, 2011 at 12:22 PM, Benjamin < benjamin.vanryseghem.pharo@gmail.com> wrote:
In fact, I have posted two things: - a little improvement in OCompletion (not related to the bug) - then I take a look at OCompletionPharoCompatibility, but I have done a mistake because the package is OcompletionPharoCompatibility (with a minus "c")
So finally, the only thing I have done to fix the bug is to change the ConfigurationOfOCompletion which now call a post load method to reset the default toolset and take in account the registry method.
I hope I haven't done too many stupid things :)
Ben
On Jun 10, 2011, at 12:05 PM, Mariano Martinez Peck wrote:
so...I saw you commit in OCompletion and then rollback the pharo-ish part. So..can that be put instead to OCompletionPharoCompatibilty and we are done? then we update ConfigurationOfOCompletion and we fix it :)
On Fri, Jun 10, 2011 at 11:59 AM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
On Thu, Jun 9, 2011 at 12:45 PM, Benjamin Van Ryseghem < benjamin.vanryseghem.pharo@gmail.com> wrote:
It's fixed, I am looking where to post the fix :)
Thanks!!!!!!!!!!!!!
Put it somewhere please :)
OCompletionPharoCompatibilty is not enough? you have commit rights there....
Ben
2011/6/9 Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com>
It comes from Toolset change.
OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^)
Ben
2011/6/9 Marcus Denker <marcus.denker@inria.fr>
On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage.
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
It works now, but can't be disabled by settings. Please see Issue 4390 with attached fix: http://code.google.com/p/pharo/issues/detail?id=4390 The fix adds a condition on ECPreferences class>>enabled to disallow completion when appropriate. The relevant line is the following: completionAllowed := ECPreferences enabled and:[ ECController allowModel: stringHolder ]. Bill ________________________________________ From: pharo-project-bounces@lists.gforge.inria.fr [pharo-project-bounces@lists.gforge.inria.fr] On Behalf Of Mariano Martinez Peck [marianopeck@gmail.com] Sent: Friday, June 10, 2011 8:30 AM To: Pharo-project@lists.gforge.inria.fr Subject: Re: [Pharo-project] OCompletion is broken in 1.3 THanks ben for all your help. It is fixed now. On Fri, Jun 10, 2011 at 12:22 PM, Benjamin <benjamin.vanryseghem.pharo@gmail.com<mailto:benjamin.vanryseghem.pharo@gmail.com>> wrote: In fact, I have posted two things: - a little improvement in OCompletion (not related to the bug) - then I take a look at OCompletionPharoCompatibility, but I have done a mistake because the package is OcompletionPharoCompatibility (with a minus "c") So finally, the only thing I have done to fix the bug is to change the ConfigurationOfOCompletion which now call a post load method to reset the default toolset and take in account the registry method. I hope I haven't done too many stupid things :) Ben On Jun 10, 2011, at 12:05 PM, Mariano Martinez Peck wrote: so...I saw you commit in OCompletion and then rollback the pharo-ish part. So..can that be put instead to OCompletionPharoCompatibilty and we are done? then we update ConfigurationOfOCompletion and we fix it :) On Fri, Jun 10, 2011 at 11:59 AM, Mariano Martinez Peck <marianopeck@gmail.com<mailto:marianopeck@gmail.com>> wrote: On Thu, Jun 9, 2011 at 12:45 PM, Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com<mailto:benjamin.vanryseghem.pharo@gmail.com>> wrote: It's fixed, I am looking where to post the fix :) Thanks!!!!!!!!!!!!! Put it somewhere please :) OCompletionPharoCompatibilty is not enough? you have commit rights there.... Ben 2011/6/9 Benjamin Van Ryseghem <benjamin.vanryseghem.pharo@gmail.com<mailto:benjamin.vanryseghem.pharo@gmail.com>> It comes from Toolset change. OCompletion should be registered as a Completion tool (but I do not remember the magic formula ^^) Ben 2011/6/9 Marcus Denker <marcus.denker@inria.fr<mailto:marcus.denker@inria.fr>> On Jun 9, 2011, at 12:21 PM, Benjamin Van Ryseghem wrote:
It happened between 13217 and 13234 ...
Maybe the Paragraph changes ?
The Dev vs. Core is killing us. We need *one* image. We should really try to do that with 1.4, it will make everything simpler and easier to manage. Marcus -- Marcus Denker -- http://www.marcusdenker.de<http://www.marcusdenker.de/> INRIA Lille -- Nord Europe. Team RMoD. -- Mariano http://marianopeck.wordpress.com<http://marianopeck.wordpress.com/> -- Mariano http://marianopeck.wordpress.com<http://marianopeck.wordpress.com/> -- Mariano http://marianopeck.wordpress.com
participants (5)
-
Benjamin -
Benjamin Van Ryseghem
-
Marcus Denker -
Mariano Martinez Peck -
Schwab,Wilhelm K