[Pharo-project] [ANN] VB-Regex patch available
Reinout Heek recently published a patch in cincom store for some Regex pending bugs after a recent mail on vwnc list. I ported this 3-methods patch on Squeak based on latest http://www.squeaksource.com/Regex.htm I have no commit right, so I posted two copies: http://source.squeak.org/inbox/VB-Regex-nice.18.mcz http://www.squeaksource.com/PharoInbox/VB-Regex-nice.18.mcz Note that core Pharo version of Regex is some versions ahead and the patch requires further porting. Nicolas ------------------------------------------------------------------------- Port fixes from Reinout Heek from VW.Regex11 Regex11(1.3.1-soops1) - introduces fix Regex11(1.3.3) - merge above with 1.3.2 Blessing comment: Fixed RxmBranch to do greedy matching instead of first match passes. This entailed adding a collection copy to #currentState, so I expect this to slow down Regex11 a bit (not measured yet). This fixes a bug found a Soops: '.*(ABCD|BC)' asRegex matches: 'fooABCD' and Mantis bug 5391: '15' matchesRegex: '[1-9]|1[0-9]' See http://bugs.squeak.org/view.php?id=5391
Thanks nicolas I will integrate it now.
Reinout Heek recently published a patch in cincom store for some Regex pending bugs after a recent mail on vwnc list. I ported this 3-methods patch on Squeak based on latest http://www.squeaksource.com/Regex.htm I have no commit right, so I posted two copies:
http://source.squeak.org/inbox/VB-Regex-nice.18.mcz http://www.squeaksource.com/PharoInbox/VB-Regex-nice.18.mcz
Note that core Pharo version of Regex is some versions ahead and the patch requires further porting.
What do you mean by further porting
Nicolas
------------------------------------------------------------------------- Port fixes from Reinout Heek from VW.Regex11
Regex11(1.3.1-soops1) - introduces fix Regex11(1.3.3) - merge above with 1.3.2
Blessing comment:
Fixed RxmBranch to do greedy matching instead of first match passes. This entailed adding a collection copy to #currentState, so I expect this to slow down Regex11 a bit (not measured yet).
This fixes a bug found a Soops: '.*(ABCD|BC)' asRegex matches: 'fooABCD' and Mantis bug 5391: '15' matchesRegex: '[1-9]|1[0-9]'
2011/5/12 Stéphane Ducasse <stephane.ducasse@inria.fr>:
Thanks nicolas I will integrate it now.
Reinout Heek recently published a patch in cincom store for some Regex pending bugs after a recent mail on vwnc list. I ported this 3-methods patch on Squeak based on latest http://www.squeaksource.com/Regex.htm I have no commit right, so I posted two copies:
http://source.squeak.org/inbox/VB-Regex-nice.18.mcz http://www.squeaksource.com/PharoInbox/VB-Regex-nice.18.mcz
Note that core Pharo version of Regex is some versions ahead and the patch requires further porting.
What do you mean by further porting
Reinout patch is just 3 methods. But the merger pretends they are in conflict with VB-Regex-StephaneDucasse.49 And the merger is not of any help with VB-Regex-StephaneDucasse.50 because of Repackaging. Repackaging without tool support is like hell :( This is an easy 3-methods patch, but imagine you have to merge a 100 methods patch with just change sets... Argh Nicolas
Nicolas
------------------------------------------------------------------------- Port fixes from Reinout Heek from VW.Regex11
Regex11(1.3.1-soops1) - introduces fix Regex11(1.3.3) - merge above with 1.3.2
Blessing comment:
Fixed RxmBranch to do greedy matching instead of first match passes. This entailed adding a collection copy to #currentState, so I expect this to slow down Regex11 a bit (not measured yet).
This fixes a bug found a Soops: '.*(ABCD|BC)' asRegex matches: 'fooABCD' and Mantis bug 5391: '15' matchesRegex: '[1-9]|1[0-9]'
http://code.google.com/p/pharo/issues/detail?id=4203 Stef On May 12, 2011, at 4:28 PM, Nicolas Cellier wrote:
Reinout Heek recently published a patch in cincom store for some Regex pending bugs after a recent mail on vwnc list. I ported this 3-methods patch on Squeak based on latest http://www.squeaksource.com/Regex.htm I have no commit right, so I posted two copies:
http://source.squeak.org/inbox/VB-Regex-nice.18.mcz http://www.squeaksource.com/PharoInbox/VB-Regex-nice.18.mcz
Note that core Pharo version of Regex is some versions ahead and the patch requires further porting.
Nicolas
------------------------------------------------------------------------- Port fixes from Reinout Heek from VW.Regex11
Regex11(1.3.1-soops1) - introduces fix Regex11(1.3.3) - merge above with 1.3.2
Blessing comment:
Fixed RxmBranch to do greedy matching instead of first match passes. This entailed adding a collection copy to #currentState, so I expect this to slow down Regex11 a bit (not measured yet).
This fixes a bug found a Soops: '.*(ABCD|BC)' asRegex matches: 'fooABCD' and Mantis bug 5391: '15' matchesRegex: '[1-9]|1[0-9]'
Lukas Renggli maintained the VB-Regex on Pharo. He tried IIRC to get Vassily to accept some patches but it appears that he didn't get any response from him. Lukas will be interested in these patches for sure. Regards El jue, 12-05-2011 a las 16:28 +0200, Nicolas Cellier escribió:
Reinout Heek recently published a patch in cincom store for some Regex pending bugs after a recent mail on vwnc list. I ported this 3-methods patch on Squeak based on latest http://www.squeaksource.com/Regex.htm I have no commit right, so I posted two copies:
http://source.squeak.org/inbox/VB-Regex-nice.18.mcz http://www.squeaksource.com/PharoInbox/VB-Regex-nice.18.mcz
Note that core Pharo version of Regex is some versions ahead and the patch requires further porting.
Nicolas
------------------------------------------------------------------------- Port fixes from Reinout Heek from VW.Regex11
Regex11(1.3.1-soops1) - introduces fix Regex11(1.3.3) - merge above with 1.3.2
Blessing comment:
Fixed RxmBranch to do greedy matching instead of first match passes. This entailed adding a collection copy to #currentState, so I expect this to slow down Regex11 a bit (not measured yet).
This fixes a bug found a Soops: '.*(ABCD|BC)' asRegex matches: 'fooABCD' and Mantis bug 5391: '15' matchesRegex: '[1-9]|1[0-9]'
-- Miguel Cobá http://twitter.com/MiguelCobaMtz http://miguel.leugim.com.mx
participants (3)
-
Miguel Cobá -
Nicolas Cellier -
Stéphane Ducasse