Could someone please review this change? Extract the logic that opens the .sources and .changes files This logic is currently in the SmalltalkImage class. The code is hard to read and enhance. Extracting the logic to its own class will fix these issues. https://pharo.fogbugz.com/default.asp?11426 -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." Winston Churchill
I'll do a pass, since I burnt my fingers already on that code right before the 2.0 release :) On 2013-08-26, at 16:12, Damien Cassou <damien.cassou@gmail.com> wrote:
Could someone please review this change?
Extract the logic that opens the .sources and .changes files
This logic is currently in the SmalltalkImage class. The code is hard to read and enhance. Extracting the logic to its own class will fix these issues.
https://pharo.fogbugz.com/default.asp?11426
-- Damien Cassou http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without losing enthusiasm." Winston Churchill
On Mon, Aug 26, 2013 at 4:14 PM, Camillo Bruni <camillobruni@gmail.com> wrote:
I'll do a pass, since I burnt my fingers already on that code right before the 2.0 release :)
I saw you just reviewed the code. Thank you. Now, this code is ready for inclusion. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." Winston Churchill
participants (2)
-
Camillo Bruni -
Damien Cassou