Hi, Iâm trying to move QualityAssistant to FastTable and I really like it. Now as you may have noticed, you cannot select a list item in the QA plugin, but you can click on it to get the issue highlighted (if the rule allows). How can I mimic this with FT? Should I create a subclass of FTSelectionStrategy and redefine #selectRowIndex:event: not to do anything and just announce that there was a click on a list item? Or is there a better way? Uko
On 09-09-15 23:42, Yuriy Tymchuk wrote:
Iâm trying to move QualityAssistant to FastTable and I really like it. Now as you may have noticed, you cannot select a list item in the QA plugin, but you can click on it to get the issue highlighted (if the rule allows). How can I mimic this with FT? Should I create a subclass of FTSelectionStrategy and redefine #selectRowIndex:event: not to do anything and just announce that there was a click on a list item? Or is there a better way?
Wouldn't QualityAssistant fit better in the NautilusAnnotationDisplayer? With only showing the number of problems and a summary of the severest one, using a hover text for a longer description and a popup menu showing all details and actions? The picture shows the possible location. There should probably be no direct actions aside from popping up the quality assistant. There should definitely not be a fat red cross taking away attention from the editor. The current vertical space taken up seems somewhat excessive Stephan
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that.
On 10 Sep 2015, at 11:34, Stephan Eggermont <stephan@stack.nl> wrote:
On 09-09-15 23:42, Yuriy Tymchuk wrote:
Iâm trying to move QualityAssistant to FastTable and I really like it. Now as you may have noticed, you cannot select a list item in the QA plugin, but you can click on it to get the issue highlighted (if the rule allows). How can I mimic this with FT? Should I create a subclass of FTSelectionStrategy and redefine #selectRowIndex:event: not to do anything and just announce that there was a click on a list item? Or is there a better way?
Wouldn't QualityAssistant fit better in the NautilusAnnotationDisplayer? With only showing the number of problems and a summary of the severest one, using a hover text for a longer description and a popup menu showing all details and actions?
The picture shows the possible location. There should probably be no direct actions aside from popping up the quality assistant. There should definitely not be a fat red cross taking away attention from the editor.
The current vertical space taken up seems somewhat excessive
Stephan
<QA.png>
On 10-09-15 11:41, Yuriy Tymchuk wrote:
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that.
Add an instance variable qualitySummary to NautilusAnnotationDisplayer. add qualitySummary := self qualitySummaryMorph to noteNewOwner: aMorph in qualitySummaryMorph, return a morph that draws the summary and reacts to click by opening the QA panel. Stephan
Thanks, Iâll take a look on that. What would be interesting is to add a stripe like line numbers but with critic indicators. Do you know how this should work? Uko
On 10 Sep 2015, at 12:01, Stephan Eggermont <stephan@stack.nl> wrote:
On 10-09-15 11:41, Yuriy Tymchuk wrote:
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that.
Add an instance variable qualitySummary to NautilusAnnotationDisplayer.
add qualitySummary := self qualitySummaryMorph to noteNewOwner: aMorph
in qualitySummaryMorph, return a morph that draws the summary and reacts to click by opening the QA panel.
Stephan
On 10 Sep 2015, at 12:10, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Thanks, Iâll take a look on that. What would be interesting is to add a stripe like line numbers but with critic indicators. Do you know how this should work?
no idea, nut I know it is possible (through a decorator, I think) and of course, this is the way to go :) Esteban
Uko
On 10 Sep 2015, at 12:01, Stephan Eggermont <stephan@stack.nl> wrote:
On 10-09-15 11:41, Yuriy Tymchuk wrote:
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that.
Add an instance variable qualitySummary to NautilusAnnotationDisplayer.
add qualitySummary := self qualitySummaryMorph to noteNewOwner: aMorph
in qualitySummaryMorph, return a morph that draws the summary and reacts to click by opening the QA panel.
Stephan
On 10 Sep 2015, at 12:21, Esteban Lorenzano <estebanlm@gmail.com> wrote:
On 10 Sep 2015, at 12:10, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Thanks, Iâll take a look on that. What would be interesting is to add a stripe like line numbers but with critic indicators. Do you know how this should work?
no idea, nut I know it is possible (through a decorator, I think)
Whom can I ask? Alain? Franck? Uko
and of course, this is the way to go :)
Esteban
Uko
On 10 Sep 2015, at 12:01, Stephan Eggermont <stephan@stack.nl> wrote:
On 10-09-15 11:41, Yuriy Tymchuk wrote:
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that.
Add an instance variable qualitySummary to NautilusAnnotationDisplayer.
add qualitySummary := self qualitySummaryMorph to noteNewOwner: aMorph
in qualitySummaryMorph, return a morph that draws the summary and reacts to click by opening the QA panel.
Stephan
On 10-09-15 12:10, Yuriy Tymchuk wrote:
Thanks, Iâll take a look on that. What would be interesting is to add a stripe like line numbers but with critic indicators. Do you know how this should work?
RubScrolledTextExtra has lineIndexForPoint: that is used in RubLineNumberDisplayer>>drawOn: to find the relevant lines visibleRectangle := self bounds. (self lineIndexForPoint: visibleRectangle topLeft) to: (self lineIndexForPoint: visibleRectangle bottomRight) do: Overriding the RubLineNumberDisplayer looks like it might need some changes in Rubric. The lookup mechanism using class side key method is 'interesting' Stephan
Oh wow, there is "RubLipsumWithSegmentsExample openWrappedâ. Iâll talk with Alain to see what can be done. Uko
On 10 Sep 2015, at 12:32, Stephan Eggermont <stephan@stack.nl> wrote:
On 10-09-15 12:10, Yuriy Tymchuk wrote:
Thanks, Iâll take a look on that. What would be interesting is to add a stripe like line numbers but with critic indicators. Do you know how this should work?
RubScrolledTextExtra has lineIndexForPoint: that is used in RubLineNumberDisplayer>>drawOn: to find the relevant lines
visibleRectangle := self bounds. (self lineIndexForPoint: visibleRectangle topLeft) to: (self lineIndexForPoint: visibleRectangle bottomRight) do:
Overriding the RubLineNumberDisplayer looks like it might need some changes in Rubric. The lookup mechanism using class side key method is 'interesting'
Stephan
yuriy Alain is probably busy but send him a mail. Le 10/9/15 12:10, Yuriy Tymchuk a écrit :
Thanks, Iâll take a look on that. What would be interesting is to add a stripe like line numbers but with critic indicators. Do you know how this should work?
Uko
On 10 Sep 2015, at 12:01, Stephan Eggermont <stephan@stack.nl> wrote:
On 10-09-15 11:41, Yuriy Tymchuk wrote:
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that. Add an instance variable qualitySummary to NautilusAnnotationDisplayer.
add qualitySummary := self qualitySummaryMorph to noteNewOwner: aMorph
in qualitySummaryMorph, return a morph that draws the summary and reacts to click by opening the QA panel.
Stephan
Stefan We know that the qualityAssistant could be better but for now we should use it and pay attention that yuriy should publish about his research and stay active around :). Stef Le 10/9/15 12:01, Stephan Eggermont a écrit :
On 10-09-15 11:41, Yuriy Tymchuk wrote:
Ideally I want it to be embedded into rubric representation. But I donât know where to start with that.
Add an instance variable qualitySummary to NautilusAnnotationDisplayer.
add qualitySummary := self qualitySummaryMorph to noteNewOwner: aMorph
in qualitySummaryMorph, return a morph that draws the summary and reacts to click by opening the QA panel.
Stephan
participants (4)
-
Esteban Lorenzano -
Stephan Eggermont -
stepharo -
Yuriy Tymchuk