[Pharo-project] [Guillermo Polito, Benjamin Van Ryseghem] Issue 3088: MNU Text>>withBlanksTrimmed
Guillermo Polito and Benjamin Van Ryseghem, Could you check your changes made to ProtocolBrowser>>initListFrom: selectorCollection highlighting: aClass ? It's related to http://code.google.com/p/pharo/issues/detail?id=3088 Basically, Guillermo added the line stringVersion: item asString and then Benjamin replaced it with stringVersion: item So, now the Protocol Browser is creating SourceMethodReferences with Texts as stringVersion. you can view those instances if you follow the steps and then execute SourcedMethodReference allInstances select: [:each | each stringVersion class == Text ] And it leads to http://code.google.com/p/pharo/issues/detail?id=3088 For what i saw, the fix will be to add Guillermo's line again but im not sure. its confusing. What do you think? Thanks
Adding 'asString' again could solve this problem, but I think it's hiding something because item := selector, ' (' , defClass name , ')'. So if item is a Text, it means selector is a Text, which sounds strange to me... But yes, let's put asString ^^ Ben On Apr 12, 2011, at 12:51 AM, Bernardo Ezequiel Contreras wrote:
Guillermo Polito and Benjamin Van Ryseghem,
Could you check your changes made to ProtocolBrowser>>initListFrom: selectorCollection highlighting: aClass ? It's related to http://code.google.com/p/pharo/issues/detail?id=3088
Basically, Guillermo added the line
stringVersion: item asString
and then Benjamin replaced it with
stringVersion: item
So, now the Protocol Browser is creating SourceMethodReferences with Texts as stringVersion. you can view those instances if you follow the steps and then execute SourcedMethodReference allInstances select: [:each | each stringVersion class == Text ] And it leads to http://code.google.com/p/pharo/issues/detail?id=3088
For what i saw, the fix will be to add Guillermo's line again but im not sure. its confusing.
What do you think?
Thanks
If I have 5 minutes today, I'll add a test :P. On Tue, Apr 12, 2011 at 8:17 AM, Benjamin < benjamin.vanryseghem.pharo@gmail.com> wrote:
Adding 'asString' again could solve this problem, but I think it's hiding something because
item := selector, ' (' , defClass name , ')'.
So if item is a Text, it means selector is a Text, which sounds strange to me...
But yes, let's put asString ^^
Ben
On Apr 12, 2011, at 12:51 AM, Bernardo Ezequiel Contreras wrote:
Guillermo Polito and Benjamin Van Ryseghem,
Could you check your changes made to ProtocolBrowser>>initListFrom: selectorCollection highlighting: aClass ? It's related to http://code.google.com/p/pharo/issues/detail?id=3088
Basically, Guillermo added the line
stringVersion: item asString
and then Benjamin replaced it with
stringVersion: item
So, now the Protocol Browser is creating SourceMethodReferences with Texts as stringVersion. you can view those instances if you follow the steps and then execute
SourcedMethodReference allInstances select: [:each | each stringVersion class == Text ]
And it leads to http://code.google.com/p/pharo/issues/detail?id=3088
For what i saw, the fix will be to add Guillermo's line again but im not sure. its confusing.
What do you think?
Thanks
participants (3)
-
Benjamin -
Bernardo Ezequiel Contreras -
Guillermo Polito