Re: [Pharo-project] WebBrowser
On Oct 7, 2010, at 10:49 PM, Alexander LazareviÄ wrote:
2010/10/7 Torsten Bergmann <astares@gmx.de>:
Dont know why this specific subclass was removed since other subclasses of AppRegistry are still in the image (like MailSender, SoundService, ...)
Was it by accident or if not what is the idea here.
It got nuked with
Name: System-Applications-StephaneDucasse.18 Author: StephaneDucasse Time: 11 July 2010, 6:52:54 pm UUID: 7eb6ce52-4ac4-4523-b44f-eaf822506c76 Ancestors: System-Applications-StephaneDucasse.14
- Issue 2664: empty classes: WebBrowser, SketchMorph, PasteUpMorphTest, NameOfSubclass, MethodTempsNode
I think I removed it because I removed the code for browsing... with the idea that I am sure nobody needs Scamper these days. But I forgot the external webBrowser stuff. The nice thing is: we can put things back, easily. I think it's better to remove and put back than to never change anything because someone might need it. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
2010/10/8 Marcus Denker <marcus.denker@inria.fr>:
The nice thing is: we can put things back, easily. I think it's better to remove and put back than to never change anything because someone might need it.
True. I guess there is no benefit other than for backwards compatibility to keep WebBrowser around. In Pharo 1.2 web links don't use WebBrowser anymore and so even a registered ExternalWebBrowser will not be used. I think there is a UI testing framework that uses ExternalWebBrowser, but I doubt that this uses the indirection via the WebBrowser registry. Anyway, I changed the latest version of ExternalWebBrowser, so that it checks if there is a WebBrowser registry present before trying to register itself. Works in Squeak 4.2a and Pharo1.2 . Alex
El vie, 08-10-2010 a las 09:06 +0200, Marcus Denker escribió:
The nice thing is: we can put things back, easily. I think it's better to remove and put back than to never change anything because someone might need it.
+ 100 -- Miguel Cobá http://miguel.leugim.com.mx
participants (3)
-
Alexander LazareviÄ -
Marcus Denker -
Miguel Cobá