[Pharo-project] Fixes for Numbers are ready (toward ANSI)
I cumulated the changes in this order: http://code.google.com/p/pharo/issues/list?id=874 PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1 add Integer #bitAt: http://code.google.com/p/pharo/issues/list?id=875 PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1 fix Float hash http://code.google.com/p/pharo/issues/list?id=876 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-Part1-nice.1 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-Part2-nice.1 fix number equal transitivity (and further change Fraction hash) http://code.google.com/p/pharo/issues/detail?id=681 PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1 connect SqNumberParser in Number readFrom: (with backward compatibility) http://code.google.com/p/pharo/issues/list?id=879 PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1 add ANSI Float Characterization Please review :) Nicolas
thanks nicolas BTW did you got feedback about this one? http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat... On Jun 11, 2009, at 9:24 PM, Nicolas Cellier wrote:
I cumulated the changes in this order:
http://code.google.com/p/pharo/issues/list?id=874 PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1 add Integer #bitAt:
http://code.google.com/p/pharo/issues/list?id=875 PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1 fix Float hash
http://code.google.com/p/pharo/issues/list?id=876 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive- Part1-nice.1 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive- Part2-nice.1 fix number equal transitivity (and further change Fraction hash)
http://code.google.com/p/pharo/issues/detail?id=681 PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1 connect SqNumberParser in Number readFrom: (with backward compatibility)
http://code.google.com/p/pharo/issues/list?id=879 PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1 add ANSI Float Characterization
Please review :)
Nicolas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
2009/6/11 Stéphane Ducasse <stephane.ducasse@inria.fr>:
thanks nicolas BTW did you got feedback about this one? http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat...
None yet. I only see 3 explanations: - everyone is busy, dead, in hollidays, in the garden, etc... - everyone disabled the preference for generating the error log - I'm the only one doing bugs, no one else ever seen a slow Notifier Maybe I should submit to squeak-dev, but the list seems rather quiet these times. Nicolas
On Jun 11, 2009, at 9:24 PM, Nicolas Cellier wrote:
I cumulated the changes in this order:
http://code.google.com/p/pharo/issues/list?id=874 PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1 add Integer #bitAt:
http://code.google.com/p/pharo/issues/list?id=875 PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1 fix Float hash
http://code.google.com/p/pharo/issues/list?id=876 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive- Part1-nice.1 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive- Part2-nice.1 fix number equal transitivity (and further change Fraction hash)
http://code.google.com/p/pharo/issues/detail?id=681 PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1 connect SqNumberParser in Number readFrom: (with backward compatibility)
http://code.google.com/p/pharo/issues/list?id=879 PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1 add ANSI Float Characterization
Please review :)
Nicolas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Jun 11, 2009, at 10:02 PM, Nicolas Cellier wrote:
2009/6/11 Stéphane Ducasse <stephane.ducasse@inria.fr>:
thanks nicolas BTW did you got feedback about this one? http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat...
None yet. I only see 3 explanations: - everyone is busy, dead, in hollidays, in the garden, etc...
Dead busyz dead = stef
- everyone disabled the preference for generating the error log - I'm the only one doing bugs, no one else ever seen a slow Notifier
Maybe I should submit to squeak-dev, but the list seems rather quiet these times.
Nicolas
On Jun 11, 2009, at 9:24 PM, Nicolas Cellier wrote:
I cumulated the changes in this order:
http://code.google.com/p/pharo/issues/list?id=874 PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1 add Integer #bitAt:
http://code.google.com/p/pharo/issues/list?id=875 PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1 fix Float hash
http://code.google.com/p/pharo/issues/list?id=876 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive- Part1-nice.1 PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive- Part2-nice.1 fix number equal transitivity (and further change Fraction hash)
http://code.google.com/p/pharo/issues/detail?id=681 PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1 connect SqNumberParser in Number readFrom: (with backward compatibility)
http://code.google.com/p/pharo/issues/list?id=879 PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1 add ANSI Float Characterization
Please review :)
Nicolas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Nicolas Cellier a écrit :
2009/6/11 Stéphane Ducasse <stephane.ducasse@inria.fr>:
thanks nicolas BTW did you got feedback about this one? http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat...
None yet. I only see 3 explanations: - everyone is busy, dead, in hollidays, in the garden, etc... - everyone disabled the preference for generating the error log - I'm the only one doing bugs, no one else ever seen a slow Notifier
:) Hi Nicolas, sorry for the stupid question but what are you asking testers to do ? I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0. seen a notifier, click on proceed and get a SqueakDebug.log. and then what ? thanks Alain
2009/6/11 Alain Plantec <alain.plantec@free.fr>:
Nicolas Cellier a écrit :
2009/6/11 Stéphane Ducasse <stephane.ducasse@inria.fr>:
thanks nicolas BTW did you got feedback about this one? http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat...
None yet. I only see 3 explanations: - everyone is busy, dead, in hollidays, in the garden, etc... - everyone disabled the preference for generating the error log - I'm the only one doing bugs, no one else ever seen a slow Notifier
:) Hi Nicolas, sorry for the stupid question but what are you asking testers to do ? I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0. seen a notifier, click on proceed and get a SqueakDebug.log. and then what ? thanks Alain
The speed should increase, that's what the patch is all for. I don't know what test Stef wants exactly, I see two possibilities: -1) review the changes -2) install the changes and do normal activity, report if any trouble Nicolas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
yes something like that. I think that the community should be more active reviewing fixes :)
Nicolas Cellier a écrit :
2009/6/11 Stéphane Ducasse <stephane.ducasse@inria.fr>:
thanks nicolas BTW did you got feedback about this one? http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat...
None yet. I only see 3 explanations: - everyone is busy, dead, in hollidays, in the garden, etc... - everyone disabled the preference for generating the error log - I'm the only one doing bugs, no one else ever seen a slow Notifier
:) Hi Nicolas, sorry for the stupid question but what are you asking testers to do ? I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0. seen a notifier, click on proceed and get a SqueakDebug.log. and then what ? thanks Alain
The speed should increase, that's what the patch is all for. I don't know what test Stef wants exactly, I see two possibilities: -1) review the changes -2) install the changes and do normal activity, report if any trouble
Nicolas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Thu, Jun 11, 2009 at 5:26 PM, Alain Plantec <alain.plantec@free.fr>wrote:
Nicolas Cellier a écrit :
2009/6/11 Stéphane Ducasse <stephane.ducasse@inria.fr>:
thanks nicolas BTW did you got feedback about this one?
http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Stat...
None yet. I only see 3 explanations: - everyone is busy, dead, in hollidays, in the garden, etc... - everyone disabled the preference for generating the error log - I'm the only one doing bugs, no one else ever seen a slow Notifier
:) Hi Nicolas, sorry for the stupid question but what are you asking testers to do ? I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0. seen a notifier, click on proceed and get a SqueakDebug.log. and then what ?
Should he do something like what Nicolas do: Debugger class>>#openOn:context:label:contents:fullView: Preferences logDebuggerStackToFile ifTrue: [MessageTally spyOn: [Smalltalk logError: title inContext: context to: 'SqueakDebug.log']] and compare the times before and after the changesets ??? Cheers, Mariano
thanks Alain
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (4)
-
Alain Plantec -
Mariano Martinez Peck -
Nicolas Cellier -
Stéphane Ducasse