[Pharo-project] [update 2.0] #20404
20404 ----- Issue 6994: move DisplayScreen >> #defaultCanvasClass to Morphic http://code.google.com/p/pharo/issues/detail?id=6994 Issue 6993: update Pharo Kernel generation http://code.google.com/p/pharo/issues/detail?id=6993 Issue 6991: Move #cleanUpForProduction to its own class http://code.google.com/p/pharo/issues/detail?id=6991 Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-MarcusDenker.980.diff http://ss3.gemstone.com/ss/Pharo20/System-Support-MarcusDenker.735.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-MarcusDenker.1284.diff http://ss3.gemstone.com/ss/Pharo20/Graphics-Display Objects-MarcusDenker.88.diff -- Marcus Denker -- http://marcusdenker.de
On Sat, Nov 17, 2012 at 9:12 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
20404 -----
Issue 6994: move DisplayScreen >> #defaultCanvasClass to Morphic http://code.google.com/p/pharo/issues/detail?id=6994
Issue 6993: update Pharo Kernel generation http://code.google.com/p/pharo/issues/detail?id=6993
Marcus, I did a small additional fix. Please integrate new slice too. -- Pavel
Issue 6991: Move #cleanUpForProduction to its own class http://code.google.com/p/pharo/issues/detail?id=6991
Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-MarcusDenker.980.diff http://ss3.gemstone.com/ss/Pharo20/System-Support-MarcusDenker.735.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-MarcusDenker.1284.diff http://ss3.gemstone.com/ss/Pharo20/Graphics-Display Objects-MarcusDenker.88.diff
-- Marcus Denker -- http://marcusdenker.de
On Sat, Nov 17, 2012 at 9:12 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
20404 -----
Issue 6994: move DisplayScreen >> #defaultCanvasClass to Morphic http://code.google.com/p/pharo/issues/detail?id=6994
This fix has very interesting consequence when loading Morphic. Because when the Morphic package is loaded, it firstly loads Form>>#defaultCanvasClass that calls "Display defaultCanvasClass". But Display is a Form too so before the DisplayScreen implementation (^FormCanvas) is loaded too, it can lead and leads to infinite recursion. -- Pavel
Issue 6993: update Pharo Kernel generation http://code.google.com/p/pharo/issues/detail?id=6993
Issue 6991: Move #cleanUpForProduction to its own class http://code.google.com/p/pharo/issues/detail?id=6991
Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-MarcusDenker.980.diff http://ss3.gemstone.com/ss/Pharo20/System-Support-MarcusDenker.735.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-MarcusDenker.1284.diff http://ss3.gemstone.com/ss/Pharo20/Graphics-Display Objects-MarcusDenker.88.diff
-- Marcus Denker -- http://marcusdenker.de
On Nov 18, 2012, at 3:45 PM, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
On Sat, Nov 17, 2012 at 9:12 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
20404 -----
Issue 6994: move DisplayScreen >> #defaultCanvasClass to Morphic http://code.google.com/p/pharo/issues/detail?id=6994
This fix has very interesting consequence when loading Morphic. Because when the Morphic package is loaded, it firstly loads Form>>#defaultCanvasClass that calls "Display defaultCanvasClass". But Display is a Form too so before the DisplayScreen implementation (^FormCanvas) is loaded too, it can lead and leads to infinite recursion.
I actually wonder if we need all the indirection (defaultCanvasClass and friends). I looked at the senders, and it is not used everywhere... Canvas sometimes is rerenced directly, sometimes not. In addition, Canvas should not be in Morpic but there should be a Canvas package that Morphic *uses* but that is completely independend of Morphic. Marcus -- Marcus Denker -- http://marcusdenker.de
participants (2)
-
Marcus Denker -
Pavel Krivanek