Re: [Pharo-dev] Penelope Doesn't Skip "Wrong" Lint Rules
----- Sean P. DeNigris <sean@clipperadams.com> a écrit :
I marked them wrong in the Critic Browser, which now skips them, but the validation report still shows them as Warnings. Anyone know why? I see the versions in the inbox references by the slice have their manifest classes... On Fri, May 8, 2015 at 4:00 AM, Christophe Demarey < christophe.demarey@inria.fr> wrote:
The monkey does a first run of tests/critics with the current pharo image ans store failed tests/rules. Then, it loads the slice and does a second run. At the end, issues reported are only the new failed tests/ rules.
That is how I understand it should work, but I've found that it doesn't always work in practice. Though at the time I thought it might just be me and I didn't stop to extract a reproducible case. And then once an issue is integrated, its not there for troubleshooting. How about we open an issue for this, and temporarily introduce a new package CaseNNNN for testing this, where Sean could reproduce his case. cheers -ben
Ben Coman wrote
How about we open an issue for this, and temporarily introduce a new package CaseNNNN for testing this, where Sean could reproduce his case.
I have also experienced what you're talking about - that Lint rules were failing that were not introduced with my fix; but I also was unable to properly document them. Just to be clear, this is a different problem - namely, that manifests declarations of wrong rules are not honored i.e. they are still reported as errors/warnings. As Nicolai pointed out in a comment in issue 15507, maybe this is a good thing because human reviewers may want to check that they were properly marked "wrong". But ideally, they would be reported as two separate categories - 1. new failures not marked "wrong" and 2. new failures so marked ----- Cheers, Sean -- View this message in context: http://forum.world.st/Penelope-Doesn-t-Skip-Wrong-Lint-Rules-tp4825134p48251... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (2)
-
Ben Coman -
Sean P. DeNigris