[Pharo-project] Issue 3482 in pharo: InterimSoundMorph references to SketchMorph
Status: Accepted Owner: guillermopolito Labels: Milestone-1.2-DevImage New issue 3482 by guillermopolito: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 SketchMorph is not in the image and the reference is broken. Pharo 1.2 dev InterimSoundMorph>>addGraphic
Comment #1 on issue 3482 by stephane.ducasse: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Thanks thanks for all your good energy.
Comment #2 on issue 3482 by marianopeck: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Guille. We have two options: remove also InterimSoundMorph or....add SketchMorph and its subclass JoystickMorph to PharoMorphicExtras or something like that. can you take care?
Comment #3 on issue 3482 by guillerm...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Mmm, tonight I will, promise :).
Comment #4 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 I'm working on it InterimSoundMorph>>addGraphic graphic := self speakerGraphic asMorph. graphic position: bounds center - (graphic extent // 2). self addMorph: graphic. solves a part of the problem. I'm checking for the rest
Comment #5 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Marcus we can integrate System-Applications that I published in the inbox. It makes the logic of SoundService delegating to the BaseSoundSystem. I published a slice for Sound in the inbox too.3482 - in SoundService I added the possibility to delegate to the registered soundsystem for preferences see package: System-Applications in inbox - I fixed all the references to SoundSettings in Sounds to refer to BaseSoundSystem and BaseSoundSystem is not the hold of the preferences.
Comment #6 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 So apparently I should move the behavior from BaseSoundSystem to AsbtractSoundSystem. Then there is a problem since the registeredClasses contain instances!!!! So I will fix that too.
Comment #7 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 I published a new Slice named 3482-FixSoundService It is probably necessary to do a SoundService reset (newly introduced method) and DummySoundSystem initialize. as postload action Then I published another slice
Updates: Status: FixedProposed Labels: Milestone-1.3 Comment #8 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 I integrate the core part in 12327
Comment #9 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 in 13032
Comment #10 on issue 3482 by ryd...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Wait what? This makes no sense whatsover... There's one setting in SoundSystem, namely soundEnabled. Why would you delegate that to the installed soundsystem? So sound is automatically turned on/off when you change what sounds to use? That's not a good use-case imho...
Comment #11 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Because you do not want to have SoundSystem dependent on System-Application. Sound should be autonomous and when it registers as been a soundservice then the sound service delegate its preference to it. I think that it makes sense. Even if I would remove SoundService completely.
Comment #12 on issue 3482 by ryd...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Then move SoundService to System-Sound? If anything, the System-Applications package should be removed, moving AppRegistry in some core library, and the rest to their respective logical spots... Finding a good place for PrettyPrinting seems like a challenge though, unless you recategorize TPureBehavor>>prettyPrinterClass :) Speaking of which, it might be a good idea to move Beeper to System-Sound as well, and rewrite uses of Beeper beep to SoundService default beep. With these moves, I think the existing SoundSystems will only rely on System-Sound.
Comment #13 on issue 3482 by ryd...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 In other words, I agree it's not ideal for Sound services to rely on System-Applications. The package seems more like it's put together more on the principle of "Ah! These are registry subclasses!!" rather than "I provide a pluggable way to do X Oh, and btw, I happen to be using the registry mechanism to achieve that" :) The second approach would, I think, lead you to put it in the same package as the other classes needed to do X. I do not think it's a good change in functionality/responsibility to have a sound on/off setting per service though, that should remain a global setting. Moving Beeper and SoundService to System-Sound would satisfy both.
Comment #14 on issue 3482 by stephane...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Thanks for the analysis I will have a look. Right now my son gave me his nice flu and I start burning of heat in my bed :) with little headache reminding me that well this head is hurting... :)
Comment #15 on issue 3482 by guillerm...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Is this fixed? Because we have not this broken reference any more! :D
Updates: Status: Fixed Comment #16 on issue 3482 by guillerm...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 (No comment was entered for this change.)
Updates: Status: Closed Comment #17 on issue 3482 by marcus.d...@gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 Test is not failing anymore for Undeclared
participants (1)
-
pharo＠googlecode.com