[Pharo3] Reviewers of fixes needed
Hi, As I have integrated some wrong things recently, I would like to only integrate fixes where at least two other people (then me or the author) checked that this is a) correct b) not introducing more bugs and c) really for Pharo3 (and not Pharo4). https://pharo.fogbugz.com/f/filters/45/Review Marcus
https://pharo.fogbugz.com/default.asp?11674 looks ok for me and I hit the "resolve" button yesterday. Do you need anything else from my side? Phil On Fri, Jan 31, 2014 at 9:06 AM, Marcus Denker <marcus.denker@inria.fr>wrote:
Hi,
As I have integrated some wrong things recently, I would like to only integrate fixes where at least two other people (then me or the author) checked that this is a) correct b) not introducing more bugs and c) really for Pharo3 (and not Pharo4).
https://pharo.fogbugz.com/f/filters/45/Review
Marcus
On 31 Jan 2014, at 10:26, phil@highoctane.be wrote:
https://pharo.fogbugz.com/default.asp?11674 looks ok for me and I hit the "resolve" button yesterday.
Do you need anything else from my side?
the resolve button just move the state to one of the resolved states. If the issue was already in a resolved state, the only thing it does is to add a tiny meta-data change note from the same state to the same state, which nobody will ever recognise as having any meaning. THUS: put a note âI checked it and I think it should be integratedâ Marcus
Ok boss, on my way. On Fri, Jan 31, 2014 at 10:30 AM, Marcus Denker <marcus.denker@inria.fr>wrote:
On 31 Jan 2014, at 10:26, phil@highoctane.be wrote:
https://pharo.fogbugz.com/default.asp?11674 looks ok for me and I hit the "resolve" button yesterday.
Do you need anything else from my side?
the resolve button just move the state to one of the resolved states. If the issue was already in a resolved state, the only thing it does is to add a tiny meta-data change note from the same state to the same state, which nobody will ever recognise as having any meaning.
THUS: put a note "I checked it and I think it should be integrated"
Marcus
participants (2)
-
Marcus Denker -
phil＠highoctane.be