I notice several VM fixes [1] submitted by Nicolas 6 months ago. They are categorized as Milestone=Later, so I'm bumping them here just in case these slipped through the cracks to get them into Pharo 4. [1] https://pharo.fogbugz.com/default.asp?pgx=LF&ixFilter=36 But then I think I remember that early in Pharo 4 cycle, the Pharo VM was aligned more closely with with Eliot's - so maybe some of these are already included? cheers -ben
can you mark them as 4.0 Stef Le 16/11/14 01:52, Ben Coman a écrit :
I notice several VM fixes [1] submitted by Nicolas 6 months ago. They are categorized as Milestone=Later, so I'm bumping them here just in case these slipped through the cracks to get them into Pharo 4.
[1] https://pharo.fogbugz.com/default.asp?pgx=LF&ixFilter=36
But then I think I remember that early in Pharo 4 cycle, the Pharo VM was aligned more closely with with Eliot's - so maybe some of these are already included?
cheers -ben
the problem was that everything changed a lot since then because for the time he submitted them I was making a HUGE synchronisation with Eliot sources. so I want those changes, a lot⦠but I asked him to review his fixes in the new context (because some changes could be already there due the sync, etc.) and reconfirm the pull request. and thatâs the status of those fixes so far :) Esteban
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
Stef
Le 16/11/14 01:52, Ben Coman a écrit :
I notice several VM fixes [1] submitted by Nicolas 6 months ago. They are categorized as Milestone=Later, so I'm bumping them here just in case these slipped through the cracks to get them into Pharo 4.
[1] https://pharo.fogbugz.com/default.asp?pgx=LF&ixFilter=36
But then I think I remember that early in Pharo 4 cycle, the Pharo VM was aligned more closely with with Eliot's - so maybe some of these are already included?
cheers -ben
stepharo wrote:
can you mark them as 4.0
Stef
Le 16/11/14 01:52, Ben Coman a écrit :
I notice several VM fixes [1] submitted by Nicolas 6 months ago. They are categorized as Milestone=Later, so I'm bumping them here just in case these slipped through the cracks to get them into Pharo 4.
[1] https://pharo.fogbugz.com/default.asp?pgx=LF&ixFilter=36
But then I think I remember that early in Pharo 4 cycle, the Pharo VM was aligned more closely with with Eliot's - so maybe some of these are already included?
cheers -ben
done
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
The problem is that they now show up in the integrator app and the monkey will try to run them with a non-existing slice, failing them all.
Stef
Le 16/11/14 01:52, Ben Coman a écrit :
I notice several VM fixes [1] submitted by Nicolas 6 months ago. They are categorized as Milestone=Later, so I'm bumping them here just in case these slipped through the cracks to get them into Pharo 4.
[1] https://pharo.fogbugz.com/default.asp?pgx=LF&ixFilter=36
But then I think I remember that early in Pharo 4 cycle, the Pharo VM was aligned more closely with with Eliot's - so maybe some of these are already included?
cheers -ben
Marcus Denker wrote:
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
The problem is that they now show up in the integrator app and the monkey will try to run them with a non-existing slice, failing them all.
I checked they are all tagged NoMonkey. Sorry I didn't consider the Integrator app. -ben
Stef
Le 16/11/14 01:52, Ben Coman a écrit :
I notice several VM fixes [1] submitted by Nicolas 6 months ago. They are categorized as Milestone=Later, so I'm bumping them here just in case these slipped through the cracks to get them into Pharo 4.
[1] https://pharo.fogbugz.com/default.asp?pgx=LF&ixFilter=36
But then I think I remember that early in Pharo 4 cycle, the Pharo VM was aligned more closely with with Eliot's - so maybe some of these are already included?
cheers -ben
Ben Coman wrote:
Marcus Denker wrote:
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
The problem is that they now show up in the integrator app and the monkey will try to run them with a non-existing slice, failing them all.
I checked they are all tagged NoMonkey. Sorry I didn't consider the Integrator app.
Maybe the integrator app should only show issues tagged "Fix To Include" ? -ben
On 21 Nov 2014, at 13:46, Ben Coman <btc@openInWorld.com> wrote:
Ben Coman wrote:
Marcus Denker wrote:
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
The problem is that they now show up in the integrator app and the monkey will try to run them with a non-existing slice, failing them all. I checked they are all tagged NoMonkey. Sorry I didn't consider the Integrator app.
Maybe the integrator app should only show issues tagged "Fix To Includeâ
they are two things: 1) integrator app 2) monkey. is the 2nd one who will fail without noMonkey :) Esteban
-ben
On 21 Nov 2014, at 13:46, Ben Coman <btc@openInWorld.com> wrote:
Ben Coman wrote:
Marcus Denker wrote:
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
The problem is that they now show up in the integrator app and the monkey will try to run them with a non-existing slice, failing them all. I checked they are all tagged NoMonkey. Sorry I didn't consider the Integrator app.
Maybe the integrator app should only show issues tagged "Fix To Includeâ
Yes, that might be a good idea. Marcus
On 21 Nov 2014, at 13:56, Marcus Denker <marcus.denker@inria.fr> wrote:
On 21 Nov 2014, at 13:46, Ben Coman <btc@openInWorld.com> wrote:
Ben Coman wrote:
Marcus Denker wrote:
On 21 Nov 2014, at 13:21, stepharo <stepharo@free.fr> wrote:
can you mark them as 4.0
The problem is that they now show up in the integrator app and the monkey will try to run them with a non-existing slice, failing them all. I checked they are all tagged NoMonkey. Sorry I didn't consider the Integrator app.
Maybe the integrator app should only show issues tagged "Fix To Includeâ
Yes, that might be a good idea.
in the integrator app (latest version), you can configure the issues you want to see. default values are just âFix Review Neededâ and âFix Reviewed by the Monkey" Esteban
Marcus
participants (4)
-
Ben Coman -
Esteban Lorenzano -
Marcus Denker -
stepharo