New Pull Request for UpdatedPharoByExample
I have made a few corrections in the chapter Syntax in a Nutshell. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/30 Kindly review the pull request.
Thanks, Gaurav! It is now merged. I don't think one needs to send an email to the mailing list, though, for PRs. Github usually notifies anybody who's watching the repository, when new PRs are made. On Sun, Apr 5, 2015 at 9:28 AM, Gaurav Singh <grvanm.coder@gmail.com> wrote:
I have made a few corrections in the chapter Syntax in a Nutshell. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/30 Kindly review the pull request.
Thanks :) On Sun, Apr 5, 2015 at 9:09 PM, Dmitri Zagidulin <dmitri@zagidulin.net> wrote:
Thanks, Gaurav! It is now merged.
I don't think one needs to send an email to the mailing list, though, for PRs. Github usually notifies anybody who's watching the repository, when new PRs are made.
On Sun, Apr 5, 2015 at 9:28 AM, Gaurav Singh <grvanm.coder@gmail.com> wrote:
I have made a few corrections in the chapter Syntax in a Nutshell. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/30 Kindly review the pull request.
Strangely enough it does not notify me, probably need to change something in my github settings. On Sun, Apr 5, 2015 at 6:39 PM, Dmitri Zagidulin <dmitri@zagidulin.net> wrote:
Thanks, Gaurav! It is now merged.
I don't think one needs to send an email to the mailing list, though, for PRs. Github usually notifies anybody who's watching the repository, when new PRs are made.
On Sun, Apr 5, 2015 at 9:28 AM, Gaurav Singh <grvanm.coder@gmail.com> wrote:
I have made a few corrections in the chapter Syntax in a Nutshell. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/30 Kindly review the pull request.
You might have to click on the Watch button on the repo. On Sunday, April 5, 2015, kilon alios <kilon.alios@gmail.com> wrote:
Strangely enough it does not notify me, probably need to change something in my github settings.
On Sun, Apr 5, 2015 at 6:39 PM, Dmitri Zagidulin <dmitri@zagidulin.net <javascript:_e(%7B%7D,'cvml','dmitri@zagidulin.net');>> wrote:
Thanks, Gaurav! It is now merged.
I don't think one needs to send an email to the mailing list, though, for PRs. Github usually notifies anybody who's watching the repository, when new PRs are made.
On Sun, Apr 5, 2015 at 9:28 AM, Gaurav Singh <grvanm.coder@gmail.com <javascript:_e(%7B%7D,'cvml','grvanm.coder@gmail.com');>> wrote:
I have made a few corrections in the chapter Syntax in a Nutshell. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/30 Kindly review the pull request.
no, as I suspected I have forgot to change from my old email to my new one. Should work now. On Mon, Apr 6, 2015 at 2:17 AM, Dmitri Zagidulin <dmitri@zagidulin.net> wrote:
You might have to click on the Watch button on the repo.
On Sunday, April 5, 2015, kilon alios <kilon.alios@gmail.com> wrote:
Strangely enough it does not notify me, probably need to change something in my github settings.
On Sun, Apr 5, 2015 at 6:39 PM, Dmitri Zagidulin <dmitri@zagidulin.net> wrote:
Thanks, Gaurav! It is now merged.
I don't think one needs to send an email to the mailing list, though, for PRs. Github usually notifies anybody who's watching the repository, when new PRs are made.
On Sun, Apr 5, 2015 at 9:28 AM, Gaurav Singh <grvanm.coder@gmail.com> wrote:
I have made a few corrections in the chapter Syntax in a Nutshell. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/30 Kindly review the pull request.
participants (3)
-
Dmitri Zagidulin -
Gaurav Singh -
kilon alios