SqNumberParser and PGConnection in Pharo 3
So SqNumberParser is gone in Pharo 3. And the nextDateAndTimeFrom: in PGConnection refers to it... I replaced it by plain NumberParser and it seems to continue working. What is the approach here to have a "squeak compatible" PGConnection? Add an empty SqNumberClass as subclass NumberParser? Regards! Esteban A. Maringolo
On 09 Apr 2014, at 22:49, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
So SqNumberParser is gone in Pharo 3.
And the nextDateAndTimeFrom: in PGConnection refers to it... I replaced it by plain NumberParser and it seems to continue working.
What is the approach here to have a "squeak compatible" PGConnection? Add an empty SqNumberClass as subclass NumberParser?
what even is PGConnection? Marcus
On 10 Apr 2014, at 09:08, Marcus Denker <marcus.denker@inria.fr> wrote:
On 09 Apr 2014, at 22:49, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
So SqNumberParser is gone in Pharo 3.
And the nextDateAndTimeFrom: in PGConnection refers to it... I replaced it by plain NumberParser and it seems to continue working.
What is the approach here to have a "squeak compatible" PGConnection? Add an empty SqNumberClass as subclass NumberParser?
what even is PGConnection?
Marcus
It is part of the native Postgresql driver (PostgresV2). His question comes down to: if I change it this way, it will break for Squeak, what should I do ? In this case, a common code base would be preferred I guess, but we'll need platform specific stuff that was not needed up to now. Svenk
Thanks for the translation Sven :) Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :) Regards! Esteban A. Maringolo 2014-04-10 4:28 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 09:08, Marcus Denker <marcus.denker@inria.fr> wrote:
On 09 Apr 2014, at 22:49, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
So SqNumberParser is gone in Pharo 3.
And the nextDateAndTimeFrom: in PGConnection refers to it... I replaced it by plain NumberParser and it seems to continue working.
What is the approach here to have a "squeak compatible" PGConnection? Add an empty SqNumberClass as subclass NumberParser?
what even is PGConnection?
Marcus
It is part of the native Postgresql driver (PostgresV2).
His question comes down to: if I change it this way, it will break for Squeak, what should I do ?
In this case, a common code base would be preferred I guess, but we'll need platform specific stuff that was not needed up to now.
Svenk
I'm emaringolo@* :D Regards! Esteban A. Maringolo 2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
And you are in DBXTalk now On 10 Apr 2014, at 16:15, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I'm emaringolo@* :D
Regards!
Esteban A. Maringolo
2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
I never uploaded the PostgresV2 update. And I don't see anybody else replaced the SqNumberParser to NumberParser reference. How can I upload the package back? Can I get write access to 'http://smalltalkhub.com/mc/DBXTalk/PostgresV2Driver/main' ? Regards, Esteban A. Maringolo 2014-04-10 11:19 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
And you are in DBXTalk now
On 10 Apr 2014, at 16:15, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I'm emaringolo@* :D
Regards!
Esteban A. Maringolo
2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
you are part of the team, so you have write access. Esteban On 19 May 2014, at 17:25, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I never uploaded the PostgresV2 update. And I don't see anybody else replaced the SqNumberParser to NumberParser reference.
How can I upload the package back? Can I get write access to 'http://smalltalkhub.com/mc/DBXTalk/PostgresV2Driver/main' ?
Regards, Esteban A. Maringolo
2014-04-10 11:19 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
And you are in DBXTalk now
On 10 Apr 2014, at 16:15, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I'm emaringolo@* :D
Regards!
Esteban A. Maringolo
2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
I commited PostgresV2-EstebanMaringolo.32 and ConfigurationOfPostgresV2-EstebanMaringolo.11 (added version 2.3) to SmalltalkHub. I hope it doesn't break anything. If so, please apologize. Esteban A. Maringolo 2014-05-19 12:55 GMT-03:00 Esteban Lorenzano <estebanlm@gmail.com>:
you are part of the team, so you have write access.
Esteban
On 19 May 2014, at 17:25, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I never uploaded the PostgresV2 update. And I don't see anybody else replaced the SqNumberParser to NumberParser reference.
How can I upload the package back? Can I get write access to 'http://smalltalkhub.com/mc/DBXTalk/PostgresV2Driver/main' ?
Regards, Esteban A. Maringolo
2014-04-10 11:19 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
And you are in DBXTalk now
On 10 Apr 2014, at 16:15, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I'm emaringolo@* :D
Regards!
Esteban A. Maringolo
2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
On 19 May 2014, at 18:20, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I commited PostgresV2-EstebanMaringolo.32 and ConfigurationOfPostgresV2-EstebanMaringolo.11 (added version 2.3) to SmalltalkHub.
I hope it doesn't break anything. If so, please apologize. Esteban A. Maringolo
Esteban, Is there any reason why we should not make this the #stable version, at least for Pharo ? Things do not work without your latest patch on Pharo 3. Sven
2014-05-19 12:55 GMT-03:00 Esteban Lorenzano <estebanlm@gmail.com>:
you are part of the team, so you have write access.
Esteban
On 19 May 2014, at 17:25, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I never uploaded the PostgresV2 update. And I don't see anybody else replaced the SqNumberParser to NumberParser reference.
How can I upload the package back? Can I get write access to 'http://smalltalkhub.com/mc/DBXTalk/PostgresV2Driver/main' ?
Regards, Esteban A. Maringolo
2014-04-10 11:19 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
And you are in DBXTalk now
On 10 Apr 2014, at 16:15, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I'm emaringolo@* :D
Regards!
Esteban A. Maringolo
2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
It could be #stable, I just was afraid of breaking somebody else stuff. I'm a champion at f*king up third parties repositories. :) Regards! Esteban A. Maringolo ps: There is also other versions of GLORP I didn't bless as #stable. 2014-08-29 17:17 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 19 May 2014, at 18:20, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I commited PostgresV2-EstebanMaringolo.32 and ConfigurationOfPostgresV2-EstebanMaringolo.11 (added version 2.3) to SmalltalkHub.
I hope it doesn't break anything. If so, please apologize. Esteban A. Maringolo
Esteban,
Is there any reason why we should not make this the #stable version, at least for Pharo ? Things do not work without your latest patch on Pharo 3.
Sven
2014-05-19 12:55 GMT-03:00 Esteban Lorenzano <estebanlm@gmail.com>:
you are part of the team, so you have write access.
Esteban
On 19 May 2014, at 17:25, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I never uploaded the PostgresV2 update. And I don't see anybody else replaced the SqNumberParser to NumberParser reference.
How can I upload the package back? Can I get write access to 'http://smalltalkhub.com/mc/DBXTalk/PostgresV2Driver/main' ?
Regards, Esteban A. Maringolo
2014-04-10 11:19 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
And you are in DBXTalk now
On 10 Apr 2014, at 16:15, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
I'm emaringolo@* :D
Regards!
Esteban A. Maringolo
2014-04-10 11:13 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 10 Apr 2014, at 16:08, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Can we coordinate efforts here? Can I at least have writing rights to GlorpDBX and PostgresV2 repos? :)
What is your StHub username ? I can add you to DBXTalk I think.
On 30 Aug 2014, at 01:40, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
It could be #stable, I just was afraid of breaking somebody else stuff. I'm a champion at f*king up third parties repositories. :)
I'll take the risk for you then: === Name: ConfigurationOfPostgresV2-SvenVanCaekenberghe.11 Author: SvenVanCaekenberghe Time: 31 August 2014, 12:04:35.32701 pm UUID: eaf9ae38-654b-43c9-8312-2a3ce8d1d26d Ancestors: ConfigurationOfPostgresV2-EstebanMaringolo.10 Updated #stable to version 2.3 to ensure pharo 3 compatibility ===
Regards!
Esteban A. Maringolo
ps: There is also other versions of GLORP I didn't bless as #stable.
That seems a bit more complicated: the Glorp ancestry is mixed up, we should merge this carefully: you made versions 86 & 87 while those already existed, the latest 88 skips your version. in any case, 88 now works for me, but I fear it skips your code Sven
On 31 Aug 2014, at 12:27, Sven Van Caekenberghe <sven@stfx.eu> wrote:
ps: There is also other versions of GLORP I didn't bless as #stable.
That seems a bit more complicated: the Glorp ancestry is mixed up, we should merge this carefully:
you made versions 86 & 87 while those already existed, the latest 88 skips your version.
in any case, 88 now works for me, but I fear it skips your code
Ah, I see, this was an intentional branch, right ? Anyway, your addition seems non-intrusive, since it only adds a type, which does not get used unless one specifically asks for it, correct ? If so, I can merge this, commit a new version and update the config. Sven
Yes... it was intentional. Because there is no "official" maintainer of the GLORP package, I didn't want to add stuff to the main codebase. Same story as with the PostgresV2 package. Regards! Esteban A. Maringolo 2014-08-31 19:16 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 31 Aug 2014, at 12:27, Sven Van Caekenberghe <sven@stfx.eu> wrote:
ps: There is also other versions of GLORP I didn't bless as #stable.
That seems a bit more complicated: the Glorp ancestry is mixed up, we should merge this carefully:
you made versions 86 & 87 while those already existed, the latest 88 skips your version.
in any case, 88 now works for me, but I fear it skips your code
Ah, I see, this was an intentional branch, right ?
Anyway, your addition seems non-intrusive, since it only adds a type, which does not get used unless one specifically asks for it, correct ?
If so, I can merge this, commit a new version and update the config.
Sven
On 01 Sep 2014, at 00:21, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Yes... it was intentional.
OK, but what about the second part, about it being non-intrusive ?
Because there is no "official" maintainer of the GLORP package, I didn't want to add stuff to the main codebase. Same story as with the PostgresV2 package.
Regards!
Esteban A. Maringolo
2014-08-31 19:16 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 31 Aug 2014, at 12:27, Sven Van Caekenberghe <sven@stfx.eu> wrote:
ps: There is also other versions of GLORP I didn't bless as #stable.
That seems a bit more complicated: the Glorp ancestry is mixed up, we should merge this carefully:
you made versions 86 & 87 while those already existed, the latest 88 skips your version.
in any case, 88 now works for me, but I fear it skips your code
Ah, I see, this was an intentional branch, right ?
Anyway, your addition seems non-intrusive, since it only adds a type, which does not get used unless one specifically asks for it, correct ?
If so, I can merge this, commit a new version and update the config.
Sven
I merged your branch and declared the result stable for Pharo 3: === Name: Glorp-SvenVanCaekenberghe.89 Author: SvenVanCaekenberghe Time: 2 September 2014, 5:08:03.507586 pm UUID: 5c4bda4a-9395-4015-b388-c8ce00b65e19 Ancestors: Glorp-MarianoMartinezPeck.88, Glorp-EstebanMaringolo.87 Merging with Esteban Maringolo's branch: adding a #dataAndTime PostgreSQL type for Pharo === Name: ConfigurationOfGlorp-SvenVanCaekenberghe.38 Author: SvenVanCaekenberghe Time: 2 September 2014, 5:12:20.404014 pm UUID: a8d54504-7a5a-4a43-92cd-3d66b252611e Ancestors: ConfigurationOfGlorp-EstebanMaringolo.37 Moved to #stable 1.7 for Pharo 3+ === On 01 Sep 2014, at 08:06, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 01 Sep 2014, at 00:21, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Yes... it was intentional.
OK, but what about the second part, about it being non-intrusive ?
Because there is no "official" maintainer of the GLORP package, I didn't want to add stuff to the main codebase. Same story as with the PostgresV2 package.
Regards!
Esteban A. Maringolo
2014-08-31 19:16 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 31 Aug 2014, at 12:27, Sven Van Caekenberghe <sven@stfx.eu> wrote:
ps: There is also other versions of GLORP I didn't bless as #stable.
That seems a bit more complicated: the Glorp ancestry is mixed up, we should merge this carefully:
you made versions 86 & 87 while those already existed, the latest 88 skips your version.
in any case, 88 now works for me, but I fear it skips your code
Ah, I see, this was an intentional branch, right ?
Anyway, your addition seems non-intrusive, since it only adds a type, which does not get used unless one specifically asks for it, correct ?
If so, I can merge this, commit a new version and update the config.
Sven
Oh, Sorry, I didn't see your last question. Thank you. Esteban A. Maringolo 2014-09-02 12:14 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
I merged your branch and declared the result stable for Pharo 3:
=== Name: Glorp-SvenVanCaekenberghe.89 Author: SvenVanCaekenberghe Time: 2 September 2014, 5:08:03.507586 pm UUID: 5c4bda4a-9395-4015-b388-c8ce00b65e19 Ancestors: Glorp-MarianoMartinezPeck.88, Glorp-EstebanMaringolo.87
Merging with Esteban Maringolo's branch: adding a #dataAndTime PostgreSQL type for Pharo === Name: ConfigurationOfGlorp-SvenVanCaekenberghe.38 Author: SvenVanCaekenberghe Time: 2 September 2014, 5:12:20.404014 pm UUID: a8d54504-7a5a-4a43-92cd-3d66b252611e Ancestors: ConfigurationOfGlorp-EstebanMaringolo.37
Moved to #stable 1.7 for Pharo 3+ ===
On 01 Sep 2014, at 08:06, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 01 Sep 2014, at 00:21, Esteban A. Maringolo <emaringolo@gmail.com> wrote:
Yes... it was intentional.
OK, but what about the second part, about it being non-intrusive ?
Because there is no "official" maintainer of the GLORP package, I didn't want to add stuff to the main codebase. Same story as with the PostgresV2 package.
Regards!
Esteban A. Maringolo
2014-08-31 19:16 GMT-03:00 Sven Van Caekenberghe <sven@stfx.eu>:
On 31 Aug 2014, at 12:27, Sven Van Caekenberghe <sven@stfx.eu> wrote:
ps: There is also other versions of GLORP I didn't bless as #stable.
That seems a bit more complicated: the Glorp ancestry is mixed up, we should merge this carefully:
you made versions 86 & 87 while those already existed, the latest 88 skips your version.
in any case, 88 now works for me, but I fear it skips your code
Ah, I see, this was an intentional branch, right ?
Anyway, your addition seems non-intrusive, since it only adds a type, which does not get used unless one specifically asks for it, correct ?
If so, I can merge this, commit a new version and update the config.
Sven
participants (4)
-
Esteban A. Maringolo -
Esteban Lorenzano -
Marcus Denker -
Sven Van Caekenberghe