[Pharo-project] strange logic
Hi I added a simple transcript into the following method. icon "Answer the receiver's icon. Handle legacy case of wording-based mechanism." |state| Transcript show: 'icon'; cr. ^^^^^^^^^^^^^^^^^^^^^^ self getStateSelector ifNil: [^super icon]. state := (MessageSend receiver: self target selector: self getStateSelector) valueWithEnoughArguments: self arguments . (state = true or: [state isString and: [(state beginsWith: '<yes>') or: [state beginsWith: '<on>']]]) ifTrue: [^self onIcon]. (state = false or: [state isString and: [(state beginsWith: '<no>') or: [state beginsWith: '<off>']]]) ifTrue: [^self offIcon]. ^super icon Then I brought up the monticello menu which has 4 toggleMenus and I got a lot and a lot and a lot of processing in the transcript It looks to me that there is a wrong logic in the system Stef
Bringing up the World menu ends up with more than 1000 'icon' messages in the Transcript 8-o "Stéphane Ducasse" <stephane.ducasse@inria.fr> a écrit dans le message de news: BAF0C354-2FD4-4AD0-B24E-EABE17ADE36D@inria.fr... Hi I added a simple transcript into the following method. icon "Answer the receiver's icon. Handle legacy case of wording-based mechanism." |state| Transcript show: 'icon'; cr. ^^^^^^^^^^^^^^^^^^^^^^ self getStateSelector ifNil: [^super icon]. state := (MessageSend receiver: self target selector: self getStateSelector) valueWithEnoughArguments: self arguments . (state = true or: [state isString and: [(state beginsWith: '<yes>') or: [state beginsWith: '<on>']]]) ifTrue: [^self onIcon]. (state = false or: [state isString and: [(state beginsWith: '<no>') or: [state beginsWith: '<off>']]]) ifTrue: [^self offIcon]. ^super icon Then I brought up the monticello menu which has 4 toggleMenus and I got a lot and a lot and a lot of processing in the transcript It looks to me that there is a wrong logic in the system Stef
Putting a haltOnce in the method shows : MenuMorph>>layoutItems ... self items do: [:item | item icon ifNotNil: [maxIconWidth := maxIconWidth max: item icon width]. item hasSubMenu ifTrue: [item subMenu layoutItems]]. too much layouting is going on (here submenu layout is done even if the submenu is not visible) ... But may be there are other calls Is there a package/tool that trace all message sends for particular methods with stack trace ? Spy ? "Alain Rastoul" <alr.dev@free.fr> a écrit dans le message de news: jmsmjm$it8$1@dough.gmane.org...
Bringing up the World menu ends up with more than 1000 'icon' messages in the Transcript 8-o
"Stéphane Ducasse" <stephane.ducasse@inria.fr> a écrit dans le message de news: BAF0C354-2FD4-4AD0-B24E-EABE17ADE36D@inria.fr... Hi
I added a simple transcript into the following method.
icon "Answer the receiver's icon. Handle legacy case of wording-based mechanism."
|state| Transcript show: 'icon'; cr. ^^^^^^^^^^^^^^^^^^^^^^ self getStateSelector ifNil: [^super icon]. state := (MessageSend receiver: self target selector: self getStateSelector) valueWithEnoughArguments: self arguments . (state = true or: [state isString and: [(state beginsWith: '<yes>') or: [state beginsWith: '<on>']]]) ifTrue: [^self onIcon]. (state = false or: [state isString and: [(state beginsWith: '<no>') or: [state beginsWith: '<off>']]]) ifTrue: [^self offIcon]. ^super icon
Then I brought up the monticello menu which has 4 toggleMenus and I got a lot and a lot and a lot of processing in the transcript
It looks to me that there is a wrong logic in the system Stef
2840 in mine for 4 icons O_o And of course doing a lot of bad string comparisonsâ¦.. Stef On Apr 21, 2012, at 12:05 AM, Alain Rastoul wrote:
Bringing up the World menu ends up with more than 1000 'icon' messages in the Transcript 8-o
"Stéphane Ducasse" <stephane.ducasse@inria.fr> a écrit dans le message de news: BAF0C354-2FD4-4AD0-B24E-EABE17ADE36D@inria.fr... Hi
I added a simple transcript into the following method.
icon "Answer the receiver's icon. Handle legacy case of wording-based mechanism."
|state| Transcript show: 'icon'; cr. ^^^^^^^^^^^^^^^^^^^^^^ self getStateSelector ifNil: [^super icon]. state := (MessageSend receiver: self target selector: self getStateSelector) valueWithEnoughArguments: self arguments . (state = true or: [state isString and: [(state beginsWith: '<yes>') or: [state beginsWith: '<on>']]]) ifTrue: [^self onIcon]. (state = false or: [state isString and: [(state beginsWith: '<no>') or: [state beginsWith: '<off>']]]) ifTrue: [^self offIcon]. ^super icon
Then I brought up the monticello menu which has 4 toggleMenus and I got a lot and a lot and a lot of processing in the transcript
It looks to me that there is a wrong logic in the system Stef
Nice! :) On 21 April 2012 09:56, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
2840 in mine for 4 icons O_o
And of course doing a lot of bad string comparisonsâ¦..
Stef
On Apr 21, 2012, at 12:05 AM, Alain Rastoul wrote:
Bringing up the World menu ends up with more than 1000 'icon' messages in the Transcript 8-o
"Stéphane Ducasse" <stephane.ducasse@inria.fr> a écrit dans le message de news: BAF0C354-2FD4-4AD0-B24E-EABE17ADE36D@inria.fr... Hi
I added a simple transcript into the following method.
icon "Answer the receiver's icon. Handle legacy case of wording-based mechanism."
|state| Transcript show: 'icon'; cr. ^^^^^^^^^^^^^^^^^^^^^^ self getStateSelector ifNil: [^super icon]. state := (MessageSend receiver: self target selector: self getStateSelector) valueWithEnoughArguments: self arguments . (state = true or: [state isString and: [(state beginsWith: '<yes>') or: [state beginsWith: '<on>']]]) ifTrue: [^self onIcon]. (state = false or: [state isString and: [(state beginsWith: '<no>') or: [state beginsWith: '<off>']]]) ifTrue: [^self offIcon]. ^super icon
Then I brought up the monticello menu which has 4 toggleMenus and  I got a lot and a lot and a lot of processing in the transcript
It looks to me that there is a wrong logic in the system Stef
-- Best regards, Igor Stasenko.
enablementSelector: aSelector enablementSelector := aSelector isBlock ifTrue: [aSelector copyForSaving] ifFalse: [aSelector] may be it would be good to get straight on the accepted parameter: because after we get this kind of logicâ¦.
participants (3)
-
Alain Rastoul -
Igor Stasenko -
Stéphane Ducasse