[Pharo-project] Class>>asRingDescription
Veronica, i've started to adopt Ring in Gaucho. Very nice work, excellent tests also! A question, why does the following is true? Collection asRingDefinition methods isEmpty = true If you look at the following method,  they should be added here right?, on the ring definition creation. Class>>asRingDefinition     | ring |     ring := (RGFactory current createClassNamed: self name)         category: self category;         superclassName: self superclass name;         traitCompositionSource: self traitCompositionString;         addInstanceVariables: self instVarNames;         addClassVariables: self classVarNames;         addPoolDictionaries: self poolDictionaryNames;         comment: self organization classComment;         stamp: self organization commentStamp;         definitionSource: self definition;         withMetaclass.     ring theMetaClass         traitCompositionSource: self theMetaClass traitCompositionString;         definitionSource: self theMetaClass definition;         addInstanceVariables: self theMetaClass instVarNames.     ^ring I'm using the latest Pharo1.4 from Jenkins. Fernando
On Sep 15, 2011, at 9:22 PM, Fernando Olivero wrote:
Veronica, i've started to adopt Ring in Gaucho. Very nice work, excellent tests also!
A question, why does the following is true?
Collection asRingDefinition methods isEmpty = true
The RGClass is created, but the methods ring objects are not created on cascade :) But you can do it easily :)
If you look at the following method, they should be added here right?, on the ring definition creation.
Class>>asRingDefinition
| ring | ring := (RGFactory current createClassNamed: self name) category: self category; superclassName: self superclass name; traitCompositionSource: self traitCompositionString; addInstanceVariables: self instVarNames; addClassVariables: self classVarNames; addPoolDictionaries: self poolDictionaryNames; comment: self organization classComment; stamp: self organization commentStamp; definitionSource: self definition; withMetaclass. ring theMetaClass traitCompositionSource: self theMetaClass traitCompositionString; definitionSource: self theMetaClass definition; addInstanceVariables: self theMetaClass instVarNames. ^ring
In this method, there is nothing about the methods :) I think Veronica told about implementing such a method. Let's wait for her precisions :) Ben
I'm using the latest Pharo1.4 from Jenkins.
Fernando
Fernando, I am almost done with this.. I already implemented some utilities to get ring classes including methods/superclasses/subclasses. Will write some tests and publish tomorrow. Veronica On 15 Sep 2011, at 21:22, Fernando Olivero wrote:
Veronica, i've started to adopt Ring in Gaucho. Very nice work, excellent tests also!
A question, why does the following is true?
Collection asRingDefinition methods isEmpty = true
If you look at the following method, they should be added here right?, on the ring definition creation.
Class>>asRingDefinition
| ring | ring := (RGFactory current createClassNamed: self name) category: self category; superclassName: self superclass name; traitCompositionSource: self traitCompositionString; addInstanceVariables: self instVarNames; addClassVariables: self classVarNames; addPoolDictionaries: self poolDictionaryNames; comment: self organization classComment; stamp: self organization commentStamp; definitionSource: self definition; withMetaclass. ring theMetaClass traitCompositionSource: self theMetaClass traitCompositionString; definitionSource: self theMetaClass definition; addInstanceVariables: self theMetaClass instVarNames. ^ring
I'm using the latest Pharo1.4 from Jenkins.
Fernando
participants (3)
-
Benjamin -
Fernando Olivero -
Veronica Isabel Uquillas Gomez