[Pharo-project] Issue 3375 in pharo: PositionableStream remove dependence to Compiler
Status: Fixed Owner: Benjamin.VanRyseghem.Pharo New issue 3375 by Benjamin.VanRyseghem.Pharo: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 fix, but using a not so pretty way. I've to discuss with Steph about extensions Attachments: PositionableStreamRemoveDependenceToCompiler.1.cs 1.8 KB
Updates: Labels: Type-Seed Comment #1 on issue 3375 by Benjamin.VanRyseghem.Pharo: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 (No comment was entered for this change.)
Comment #2 on issue 3375 by rydier: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 So you're moving fileInSilentlyAnnouncing: to Compiler-Kernel, but keeping fileInSilently in Collections-Streams and give it an "Does compiler exist"-check? This does not consistently make sense to me...
Comment #3 on issue 3375 by rydier: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 Ie why not just move both methods to the extension category?
Comment #4 on issue 3375 by rydier: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 BTW, methods used by fileInSilentlyAnnouncing: , as well as fileIn, fileInAnnouncing: (which also reference Compiler) etc. are already in *System-Changes. So with these changes we will have a dependency of Kernel-Compiler on System-Changes, as well as no single category containing all fileIn-related methods.
Comment #5 on issue 3375 by Benjamin.VanRyseghem.Pharo: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 @Comment 2 and Comment 3: You're right, here the new cs. @Comment 4 : fileInSilentlyAnnouncing: doesn't invoke methods from *System-Changes. That's true that there is dependencies between Compiler-Kernel and System-Changes, but I can fix dependencies only step by step :) (and I hope I will not be the only Pharo user who will fix such issues) Attachments: Issue3375PositionableStreamRemoveDependenceToCompiler.1.cs 1.6 KB
Comment #6 on issue 3375 by stephane.ducasse: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 No don't worry we are doing that all the time :)
Comment #7 on issue 3375 by rydier: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 @5: "fileInSilentlyAnnouncing: doesn't invoke methods from *System-Changes." What are you talking about? It uses both nextChunk, checkForPreamble:, and skipStyleChunk
Comment #8 on issue 3375 by Benjamin.VanRyseghem.Pharo: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 Excuse me, it's the end of the week, I'm a little bit tired ^^ What I want to say was it doesn't invoke methods which reference Compiler (I think)
Comment #9 on issue 3375 by rydier: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 No, but other methods which have similar functionality, and have already been moved to *System-Changes, do :P (Like I implied in first comment by mentioning fileIn, fileInAnnouncing: etc.) Why not switch those over as well when you're at it? The reason I mentioned consistency is because the browser is very class-centric. When I now browse PositionableStream, and see the functionality for filing in code randomly distributed between two extension categories, rather than all being in a logically named category like they used to... Let's just say it doesn't always strike me as practical improvements.
Comment #10 on issue 3375 by Benjamin.VanRyseghem.Pharo: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 Yes I know, but in one hand I want methods in meaningful category and on the other hand I want no dependencies, so I had to take a decision ... Moreover, maybe it will change when dependencies of System-Changes will be checked ... Maybe it's not practical, but I don't think it makes sense that Stream depends on Compiler
Updates: Status: Closed Comment #11 on issue 3375 by stephane...@gmail.com: PositionableStream remove dependence to Compiler http://code.google.com/p/pharo/issues/detail?id=3375 in 13083
participants (1)
-
pharo@googlecode.com