[Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser. At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen. Thanks, Rob
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)... Regards, Gary. ----- Original Message ----- From: Rob Rothwell To: Pharo Development Sent: Tuesday, January 27, 2009 11:32 PM Subject: [Pharo-project] Polymorph and OB Browser Colors Quick Solution I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser. At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen. Thanks, Rob ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Hi Gary,
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)...
yep, sorry, I was busy with other stuff. But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December: "Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB." To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it. I will in the meantime look at the PluggableButtonMorphPlus issue. Cheers, David
Regards, Gary.
----- Original Message ----- *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr> *Sent:* Tuesday, January 27, 2009 11:32 PM *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser.
At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen.
Thanks,
Rob
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Indeed, the changeset is totally bogus... must have got tripped up in the change sorter (mostly use MC so I don't use the sorters very often)! Found the correct one now... attached. Regards, Gary. ----- Original Message ----- From: "David Röthlisberger" <squeak@webcitas.ch> To: <Pharo-project@lists.gforge.inria.fr> Sent: Thursday, January 29, 2009 1:43 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Hi Gary,
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)...
yep, sorry, I was busy with other stuff.
But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December:
"Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB."
To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it.
I will in the meantime look at the PluggableButtonMorphPlus issue.
Cheers, David
Regards, Gary.
----- Original Message ----- *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr> *Sent:* Tuesday, January 27, 2009 11:32 PM *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser.
At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen.
Thanks,
Rob
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Thanks, Gary, for this new patch. Indeed this works better. :) I adapted some parts and committed it for the moment. From the Polymorph point of view: Is this what you need? Because I need to adapt it again as OB does not work properly in Squeak now, so I would like to know whether it does what you want for Polymorph or not. It's enough when you load latest OB-Morphic to get it. David
Found the correct one now... attached.
Regards, Gary.
----- Original Message ----- From: "David Röthlisberger" <squeak@webcitas.ch> To: <Pharo-project@lists.gforge.inria.fr> Sent: Thursday, January 29, 2009 1:43 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Hi Gary,
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)...
yep, sorry, I was busy with other stuff.
But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December:
"Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB."
To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it.
I will in the meantime look at the PluggableButtonMorphPlus issue.
Cheers, David
Regards, Gary.
----- Original Message ----- *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr> *Sent:* Tuesday, January 27, 2009 11:32 PM *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser.
At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen.
Thanks,
Rob
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I notice the back/forward buttons are created with a morph as the label. Might be better to refactor OBDraggableButton to be under PluggableButtonMorphPlus (or implement enablement protocol) and use just a string or text, using enablement rather than on/off state - that should help avoid use of the hardcoded font. In Polymorph if the "label" (morph) of a PluggableButtonMorphPlus responds to #enabled: the enablement of the button gets forwarded to the label morph as well. Button bar heights are also a problem if fixed size. Similarly, OBButtonModel might benefit from some attention (hence the "different" style of the instance/class/traits buttons etc.). These buttons also. I guess there's a lot in OB to do with specifying the style of in a rather fixed manner (#styleWith:...) (clearly to make it look good with original Morphic) rather than relying on default behaviour that Polymorph leverages. The Vistary theme seems to highlight problems with button colours/states better while Watery2 highlights any pane colour problems. Getting there, I think though. Regards, Gary ________________________________ From: David Röthlisberger <squeak@webcitas.ch> To: Pharo-project@lists.gforge.inria.fr Sent: Friday, 30 January, 2009 3:17:46 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution Thanks, Gary, for this new patch. Indeed this works better. :) I adapted some parts and committed it for the moment. >From the Polymorph point of view: Is this what you need? Because I need to adapt it again as OB does not work properly in Squeak now, so I would like to know whether it does what you want for Polymorph or not. It's enough when you load latest OB-Morphic to get it. David
Found the correct one now... attached.
Regards, Gary.
----- Original Message ----- From: "David Röthlisberger" <squeak@webcitas.ch> To: <Pharo-project@lists.gforge.inria.fr> Sent: Thursday, January 29, 2009 1:43 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Hi Gary,
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)...
yep, sorry, I was busy with other stuff.
But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December:
"Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB."
To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it.
I will in the meantime look at the PluggableButtonMorphPlus issue.
Cheers, David
Regards, Gary.
----- Original Message ----- *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr> *Sent:* Tuesday, January 27, 2009 11:32 PM *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser.
At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen.
Thanks,
Rob
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
------------------------------------------------------------------------
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Hi Gary,
I notice the back/forward buttons are created with a morph as the label. Might be better to refactor OBDraggableButton to be under PluggableButtonMorphPlus (or implement enablement protocol) and use just a string or text, using enablement rather than on/off state - that should help avoid use of the hardcoded font.
ok, I changed the back/forward buttons to be subclasses of PluggableButtonMorphPlus. But I did not change the label to just be a string or text, because it doesn't seem to be possible to get colored labels for buttons if you don't generate the string morph yourself. Because when you pass a text, PluggableButtonMorph just uses its string, but not the assigned attributes...
Button bar heights are also a problem if fixed size. Similarly, OBButtonModel might benefit from some attention (hence the "different" style of the instance/class/traits buttons etc.). These buttons also.
ok, I will check that. Thanks, David
------------------------------------------------------------------------ *From:* David Röthlisberger <squeak@webcitas.ch> *To:* Pharo-project@lists.gforge.inria.fr *Sent:* Friday, 30 January, 2009 3:17:46 PM *Subject:* Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Thanks, Gary, for this new patch. Indeed this works better. :) I adapted some parts and committed it for the moment. From the Polymorph point of view: Is this what you need? Because I need to adapt it again as OB does not work properly in Squeak now, so I would like to know whether it does what you want for Polymorph or not.
It's enough when you load latest OB-Morphic to get it.
David
Found the correct one now... attached.
Regards, Gary.
----- Original Message ----- From: "David Röthlisberger" <squeak@webcitas.ch <mailto:squeak@webcitas.ch>> To: <Pharo-project@lists.gforge.inria.fr <mailto:Pharo-project@lists.gforge.inria.fr>> Sent: Thursday, January 29, 2009 1:43 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Hi Gary,
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)...
yep, sorry, I was busy with other stuff.
But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December:
"Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB."
To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it.
I will in the meantime look at the PluggableButtonMorphPlus issue.
Cheers, David
Regards, Gary.
----- Original Message ----- *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com <mailto:r.j.rothwell@gmail.com>> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr <mailto:pharo-project@lists.gforge.inria.fr>> *Sent:* Tuesday, January 27, 2009 11:32 PM *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser.
At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen.
Thanks,
Rob
With Polymorph use of Text for button labels does work. Not for normal Squeak though... Regards, Gary. ----- Original Message ----- From: "David Röthlisberger" <squeak@webcitas.ch> To: <Pharo-project@lists.gforge.inria.fr> Sent: Monday, February 02, 2009 11:13 AM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Hi Gary,
I notice the back/forward buttons are created with a morph as the label. Might be better to refactor OBDraggableButton to be under PluggableButtonMorphPlus (or implement enablement protocol) and use just a string or text, using enablement rather than on/off state - that should help avoid use of the hardcoded font.
ok, I changed the back/forward buttons to be subclasses of PluggableButtonMorphPlus. But I did not change the label to just be a string or text, because it doesn't seem to be possible to get colored labels for buttons if you don't generate the string morph yourself. Because when you pass a text, PluggableButtonMorph just uses its string, but not the assigned attributes...
Button bar heights are also a problem if fixed size. Similarly, OBButtonModel might benefit from some attention (hence the "different" style of the instance/class/traits buttons etc.). These buttons also.
ok, I will check that.
Thanks, David
------------------------------------------------------------------------ *From:* David Röthlisberger <squeak@webcitas.ch> *To:* Pharo-project@lists.gforge.inria.fr *Sent:* Friday, 30 January, 2009 3:17:46 PM *Subject:* Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Thanks, Gary, for this new patch. Indeed this works better. :) I adapted some parts and committed it for the moment. From the Polymorph point of view: Is this what you need? Because I need to adapt it again as OB does not work properly in Squeak now, so I would like to know whether it does what you want for Polymorph or not.
It's enough when you load latest OB-Morphic to get it.
David
Found the correct one now... attached.
Regards, Gary.
----- Original Message ----- From: "David Röthlisberger" <squeak@webcitas.ch <mailto:squeak@webcitas.ch>> To: <Pharo-project@lists.gforge.inria.fr <mailto:Pharo-project@lists.gforge.inria.fr>> Sent: Thursday, January 29, 2009 1:43 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution
Hi Gary,
Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)...
yep, sorry, I was busy with other stuff.
But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December:
"Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB."
To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it.
I will in the meantime look at the PluggableButtonMorphPlus issue.
Cheers, David
Regards, Gary.
----- Original Message ----- *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com <mailto:r.j.rothwell@gmail.com>> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr <mailto:pharo-project@lists.gforge.inria.fr>> *Sent:* Tuesday, January 27, 2009 11:32 PM *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick Solution
I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser.
At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen.
Thanks,
Rob
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (4)
-
David Röthlisberger -
GARY CHAMBERS -
Gary Chambers
-
Rob Rothwell