[Pharo-project] add temp does not add the temp in 1.3 13179
Hi guys I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up. Stef
true....I could reproduce it On Mon, May 2, 2011 at 6:34 PM, Stéphane Ducasse <stephane.ducasse@inria.fr>wrote:
Hi guys
I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up.
Stef
-- Mariano http://marianopeck.wordpress.com
however, in the core image doesn't happend. And changing the Browser of the core image in the dev, has the same problem. So it doesn't seem related to OB.... The "gulty" seems to be shout....if you take a PharoCore and you load shout, you get such problem. On Tue, May 3, 2011 at 12:31 AM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
true....I could reproduce it
On Mon, May 2, 2011 at 6:34 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
Hi guys
I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up.
Stef
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
This is already broken in Pharo 1.2. Lukas On Monday, 2 May 2011, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up.
Stef
-- Lukas Renggli www.lukas-renggli.ch
strange I program a lot and I did not see it in 1.3 before recently Stef On May 3, 2011, at 7:53 AM, Lukas Renggli wrote:
This is already broken in Pharo 1.2.
Lukas
On Monday, 2 May 2011, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up.
Stef
-- Lukas Renggli www.lukas-renggli.ch
On Tue, May 3, 2011 at 7:53 AM, Lukas Renggli <renggli@gmail.com> wrote:
This is already broken in Pharo 1.2.
In the official Pharo 1.2.1 it works correct.
Lukas
On Monday, 2 May 2011, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up.
Stef
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
http://code.google.com/p/pharo/issues/detail?id=4153 On Tue, May 3, 2011 at 10:04 AM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
On Tue, May 3, 2011 at 7:53 AM, Lukas Renggli <renggli@gmail.com> wrote:
This is already broken in Pharo 1.2.
In the official Pharo 1.2.1 it works correct.
Lukas
On Monday, 2 May 2011, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
I do not know how many of you are coding in 1.3 but when the system asks me to add if I want to add a temp, the temp does not show up.
Stef
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
On 03 May 2011, at 10:04, Mariano Martinez Peck wrote:
On Tue, May 3, 2011 at 7:53 AM, Lukas Renggli <renggli@gmail.com> wrote: This is already broken in Pharo 1.2.
In the official Pharo 1.2.1 it works correct.
Nope. When adding a temp while in the debugger it does not add the temp either in Pharo1.2.1 Johan
On Tue, May 3, 2011 at 10:12 AM, Johan Brichau <johan@inceptive.be> wrote:
On 03 May 2011, at 10:04, Mariano Martinez Peck wrote:
On Tue, May 3, 2011 at 7:53 AM, Lukas Renggli <renggli@gmail.com> wrote: This is already broken in Pharo 1.2.
In the official Pharo 1.2.1 it works correct.
Nope. When adding a temp while in the debugger it does not add the temp either in Pharo1.2.1
aha.... I didn't try that ;) So...in 1.2.1 adding from a browser does work, but not from the debugger? And in 1.3 none of them?
Johan
-- Mariano http://marianopeck.wordpress.com
On 03 May 2011, at 10:14, Mariano Martinez Peck wrote:
aha.... I didn't try that ;) So...in 1.2.1 adding from a browser does work, but not from the debugger? And in 1.3 none of them?
I don't know about 1.3 but it's one of the things I started to notice about 1.2.1 this week. In the browser, it works fine.
it does not work in OB in 1.3 nor in the plain default browser. Now in plain 1.3-core it is working in the default browser. So this is probably linked with a package loaded in the dev image. I was thinking OC? Stef On May 3, 2011, at 2:30 PM, Johan Brichau wrote:
On 03 May 2011, at 10:14, Mariano Martinez Peck wrote:
aha.... I didn't try that ;) So...in 1.2.1 adding from a browser does work, but not from the debugger? And in 1.3 none of them?
I don't know about 1.3 but it's one of the things I started to notice about 1.2.1 this week. In the browser, it works fine.
I can reproduce it everywhere, in Pharo 1.2 and 1.3. I don't think it has anything to do with Shout or eCompletion. It looks like the problem is that the new text editor that doesn't consequently reuse the same Text object but instead creates new ones. The method #compile:classified:withStamp:notifying:logSource: depends on the fact that this is always the same Text instance, even after editing. Luckily we can fix that easily, but there might be other subtle bugs lingering around: TClassAndTraitDescription>>compile: text classified: category withStamp: changeStamp notifying: requestor logSource: logSource | methodAndNode | methodAndNode := self compile: text asString classified: category notifying: requestor trailer: self defaultMethodTrailer ifFail: [^nil]. logSource ifTrue: [ " replace 'text' with 'methodAndNode node sourceText' " self logMethodSource: methodAndNode node sourceText forMethodWithNode: methodAndNode inCategory: category withStamp: changeStamp notifying: requestor. ]. self addAndClassifySelector: methodAndNode selector withMethod: methodAndNode method inProtocol: category notifying: requestor. self instanceSide noteCompilationOf: methodAndNode selector meta: self isClassSide. ^ methodAndNode selector On 3 May 2011 17:19, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
it does not work in OB in 1.3 nor in the plain default browser. Now in plain 1.3-core it is working in the default browser. So this is probably linked with a package loaded in the dev image. I was thinking OC?
Stef
On May 3, 2011, at 2:30 PM, Johan Brichau wrote:
On 03 May 2011, at 10:14, Mariano Martinez Peck wrote:
aha.... I didn't try that ;) So...in 1.2.1 adding from a browser does work, but not from the debugger? And in 1.3 none of them?
I don't know about 1.3 but it's one of the things I started to notice about 1.2.1 this week. In the browser, it works fine.
-- Lukas Renggli www.lukas-renggli.ch
Thanks Lukas. I put your code in a slice and it works. http://code.google.com/p/pharo/issues/detail?id=4153 On Tue, May 3, 2011 at 8:38 PM, Lukas Renggli <renggli@gmail.com> wrote:
I can reproduce it everywhere, in Pharo 1.2 and 1.3. I don't think it has anything to do with Shout or eCompletion. It looks like the problem is that the new text editor that doesn't consequently reuse the same Text object but instead creates new ones. The method #compile:classified:withStamp:notifying:logSource: depends on the fact that this is always the same Text instance, even after editing. Luckily we can fix that easily, but there might be other subtle bugs lingering around:
TClassAndTraitDescription>>compile: text classified: category withStamp: changeStamp notifying: requestor logSource: logSource | methodAndNode | methodAndNode := self compile: text asString classified: category notifying: requestor trailer: self defaultMethodTrailer ifFail: [^nil]. logSource ifTrue: [ " replace 'text' with 'methodAndNode node sourceText' " self logMethodSource: methodAndNode node sourceText forMethodWithNode: methodAndNode inCategory: category withStamp: changeStamp notifying: requestor. ]. self addAndClassifySelector: methodAndNode selector withMethod: methodAndNode method inProtocol: category notifying: requestor. self instanceSide noteCompilationOf: methodAndNode selector meta: self isClassSide. ^ methodAndNode selector
On 3 May 2011 17:19, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
it does not work in OB in 1.3 nor in the plain default browser. Now in plain 1.3-core it is working in the default browser. So this is probably linked with a package loaded in the dev image. I was thinking OC?
Stef
On May 3, 2011, at 2:30 PM, Johan Brichau wrote:
On 03 May 2011, at 10:14, Mariano Martinez Peck wrote:
aha.... I didn't try that ;) So...in 1.2.1 adding from a browser does work, but not from the
debugger?
And in 1.3 none of them?
I don't know about 1.3 but it's one of the things I started to notice about 1.2.1 this week. In the browser, it works fine.
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
http://code.google.com/p/pharo/issues/detail?id=3985 should reopen ? Laurent. On Tue, May 3, 2011 at 5:19 PM, Stéphane Ducasse <stephane.ducasse@inria.fr>wrote:
it does not work in OB in 1.3 nor in the plain default browser. Now in plain 1.3-core it is working in the default browser. So this is probably linked with a package loaded in the dev image. I was thinking OC?
Stef
On May 3, 2011, at 2:30 PM, Johan Brichau wrote:
On 03 May 2011, at 10:14, Mariano Martinez Peck wrote:
aha.... I didn't try that ;) So...in 1.2.1 adding from a browser does work, but not from the
debugger?
And in 1.3 none of them?
I don't know about 1.3 but it's one of the things I started to notice about 1.2.1 this week. In the browser, it works fine.
participants (5)
-
Johan Brichau -
laurent laffont -
Lukas Renggli -
Mariano Martinez Peck -
Stéphane Ducasse