GitFileTree repository commitish doesn't support slashes
Hi, the repository specification 'github://<user name>/<project name>[:comitish]/<path to filetree repo>' doesn't support slashes in commitish. For example if I have branch named 'feature/something', or 'hotfix/otherthing' it breaks. There may be conflict also with path (imagine having branch repository/repository and and actual folder called repository), so this may require something special... like having another separator... i.e. <project name>[:commitish[:]]/<path to filetree repo>? (Optional ending colon.) Peter
Hi Peter, Le 19/03/2015 01:31, Peter Uhnák a écrit :
Hi,
the repository specification 'github://<user name>/<project name>[:comitish]/<path to filetree repo>' doesn't support slashes in commitish.
For example if I have branch named 'feature/something', or 'hotfix/otherthing' it breaks.
Yes, it certainly would.
There may be conflict also with path (imagine having branch repository/repository and and actual folder called repository), so this may require something special... like having another separator... i.e. <project name>[:commitish[:]]/<path to filetree repo>? (Optional ending colon.)
Yes, it looks like a good approach. But what if you have $: in the commitish? Another one would be to have, like gitfiletree urls, the ability to write: 'github://<user name>/<project name>[[?commit=comitish]&path=<path to filetree repo>]' Well, I was considering to allow, in gitfiletree, the following 'gitfiletree://<user name>/<project name>[:branch]/<path to filetree repo>', so now I'm having an excuse for not doing it ;) Thierry
Hi Peter, after raising an issue on FileTree, Dale pointed out this was corrected in the latest Metacello (which is not included in Pharo 4). Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze? Thierry Le 19/03/2015 01:31, Peter Uhnák a écrit :
Hi,
the repository specification 'github://<user name>/<project name>[:comitish]/<path to filetree repo>' doesn't support slashes in commitish.
For example if I have branch named 'feature/something', or 'hotfix/otherthing' it breaks.
There may be conflict also with path (imagine having branch repository/repository and and actual folder called repository), so this may require something special... like having another separator... i.e. <project name>[:commitish[:]]/<path to filetree repo>? (Optional ending colon.)
Peter
Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze?
It is still 12 days till freeze; are there any issues associated with it? Because this is a bug fix, not a feature. Unless its bundled with a lot of other stuff. Peter
On 19 Mar 2015, at 20:39, Peter Uhnák <i.uhnak@gmail.com> wrote:
Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze?
It is still 12 days till freeze; are there any issues associated with it? Because this is a bug fix, not a feature. Unless its bundled with a lot of other stuff.
No, freeze was 18 days ago⦠is 12 days to release. Now we just accept bugfixes (and a new release of Metacello is far more than a bugfix). Esteban
Peter
Le 19/03/2015 20:42, Esteban Lorenzano a écrit :
On 19 Mar 2015, at 20:39, Peter Uhnák <i.uhnak@gmail.com <mailto:i.uhnak@gmail.com>> wrote:
Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze?
It is still 12 days till freeze; are there any issues associated with it? Because this is a bug fix, not a feature. Unless its bundled with a lot of other stuff.
No, freeze was 18 days ago⦠is 12 days to release. Now we just accept bugfixes (and a new release of Metacello is far more than a bugfix).
Ok, thanks. Then I won't spend my evening looking at it ;) Anyway, the github support in Pharo4 is as it was in Pharo3: kind of broken :( Thierry
No, freeze was 18 days ago⦠is 12 days to release.
Aha, I confused the two.
Anyway, the github support in Pharo4 is as it was in Pharo3: kind of broken
:(
Well I work from bleeding edge (more or less), so if it will be in early Pharo 5 it's fine. In the meantime, can I load it myself? Where is the repo? Will it break anything? Thanks, Peter
Le 19/03/2015 20:51, Peter Uhnák a écrit :
No, freeze was 18 days ago⦠is 12 days to release.
Aha, I confused the two.
Anyway, the github support in Pharo4 is as it was in Pharo3: kind of broken :(
Well I work from bleeding edge (more or less), so if it will be in early Pharo 5 it's fine. In the meantime, can I load it myself? Where is the repo? Will it break anything?
The Metacello repository is on github, at https://github.com/dalehenrich/metacello-work. I believe that if you use the pharo3 instructions, it should load. Thierry
On 19 Mar 2015, at 20:47, Thierry Goubier <thierry.goubier@gmail.com> wrote:
Le 19/03/2015 20:42, Esteban Lorenzano a écrit :
On 19 Mar 2015, at 20:39, Peter Uhnák <i.uhnak@gmail.com <mailto:i.uhnak@gmail.com>> wrote:
Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze?
It is still 12 days till freeze; are there any issues associated with it? Because this is a bug fix, not a feature. Unless its bundled with a lot of other stuff.
No, freeze was 18 days ago⦠is 12 days to release. Now we just accept bugfixes (and a new release of Metacello is far more than a bugfix).
Ok,
thanks. Then I won't spend my evening looking at it ;)
The problem is that one new version could cause infinite problems (and has caused, before)⦠I would be really happy to integrate the new version as soon as we start Pharo5.
Anyway, the github support in Pharo4 is as it was in Pharo3: kind of broken :(
yeah, a lot of things can be improved⦠but that is the way things are usually. We will always have something cool and new to add⦠but if we do not put a stop, we will never release. Is not that I do not want⦠is that is not recommendable⦠So: Pharo5. I will be super happy to include the new version as soon as we begin :) cheers, Esteban
Thierry
Le 19/03/2015 20:54, Esteban Lorenzano a écrit :
On 19 Mar 2015, at 20:47, Thierry Goubier <thierry.goubier@gmail.com> wrote:
Le 19/03/2015 20:42, Esteban Lorenzano a écrit :
On 19 Mar 2015, at 20:39, Peter Uhnák <i.uhnak@gmail.com <mailto:i.uhnak@gmail.com>> wrote:
Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze?
It is still 12 days till freeze; are there any issues associated with it? Because this is a bug fix, not a feature. Unless its bundled with a lot of other stuff.
No, freeze was 18 days ago⦠is 12 days to release. Now we just accept bugfixes (and a new release of Metacello is far more than a bugfix).
Ok,
thanks. Then I won't spend my evening looking at it ;)
The problem is that one new version could cause infinite problems (and has caused, before)⦠I would be really happy to integrate the new version as soon as we start Pharo5.
Unknown problems against known ones:) Anyway, Metacello is only part of the story; because of the file path problems, github and bitbucket urls can't be used to distribute packages from github on Windows.
Anyway, the github support in Pharo4 is as it was in Pharo3: kind of broken :(
yeah, a lot of things can be improved⦠but that is the way things are usually. We will always have something cool and new to add⦠but if we do not put a stop, we will never release.
I agree with that.
Is not that I do not want⦠is that is not recommendable⦠So: Pharo5. I will be super happy to include the new version as soon as we begin :)
We'll do that then :) Thierry
Le 19/03/2015 20:39, Peter Uhnák a écrit :
Question now: is it still viable to include the latest Metacello in Pharo 4 despite the freeze?
It is still 12 days till freeze; are there any issues associated with it? Because this is a bug fix, not a feature. Unless its bundled with a lot of other stuff.
I'll make a diff to the latest Pharo4 to check. I believe Dale suggested to Stéphane he could upgrade easily. It corrects at least one bug :) and probably a few, hard to solve, dependencies issues in complex configurations, from past messages. Thierry
participants (3)
-
Esteban Lorenzano -
Peter Uhnák -
Thierry Goubier