PetitParser Tests Failing in Pharo 4.0
RBVariableNode DNU #identifierToken: Removed since Pharo 3.0. No deprecation. Searching dev list & fogbugz -> 0 hits. Guys, we need some discipline. ----- Cheers, Sean -- View this message in context: http://forum.world.st/PetitParser-Tests-Failing-in-Pharo-4-0-tp4809513.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 04 Mar 2015, at 16:59, Sean P. DeNigris <sean@clipperadams.com> wrote:
RBVariableNode DNU #identifierToken:
Removed since Pharo 3.0. No deprecation. Searching dev list & fogbugz -> 0 hits.
Guys, we need some discipline.
We changes the AST to have no tokens anymore. We either do that change or we donât. There is no way to keep it backward compatible. Marcus
On Mar 4, 2015, at 11:02 AM, "Marcus Denker-4 [via Smalltalk]" <ml-node+s1294792n4809514h22@n4.nabble.com> wrote:
We either do that change or we donât. There is no way to keep it backward compatible.
Thanks for the info. Sorry about my frustration :/ But I just had a huge Aha that may help understanding changes in the future. I went to the GitHub mirror and discovered something /really/ cool... 1. I navigated to the class side of RBVariableNode and noticed the button with the clock & backward arrow on it 2. Clicking it, lead me to a list of commits perfectly scoped to the methods in question. There, I clicked on the SHA of the last commit 3. I was presented with a) the image version where it was integrated b) the issues integrated, and c) the method diffs!!! I didn't realize that e.g. the update and issue numbers were on github. This is really great. Screenshot 2015-03-04 11.50.34.png (182K) <http://forum.world.st/attachment/4809534/0/Screenshot%202015-03-04%2011.50.3...> Screenshot 2015-03-04 11.48.09.png (94K) <http://forum.world.st/attachment/4809534/1/Screenshot%202015-03-04%2011.48.0...> Screenshot 2015-03-04 11.48.37.png (325K) <http://forum.world.st/attachment/4809534/2/Screenshot%202015-03-04%2011.48.3...> ----- Cheers, Sean -- View this message in context: http://forum.world.st/PetitParser-Tests-Failing-in-Pharo-4-0-tp4809513p48095... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 04 Mar 2015, at 17:48, Sean P. DeNigris <sean@clipperadams.com> wrote:
On Mar 4, 2015, at 11:02 AM, "Marcus Denker-4 [via Smalltalk]" <[hidden email]> wrote:
We either do that change or we donât. There is no way to keep it backward compatible.
Thanks for the info. Sorry about my frustration :/ But I just had a huge Aha that may help understanding changes in the future. I went to the GitHub mirror and discovered something /really/ cool...
Yes, we are very cool ;-) Seriously though: good explanation. This is again an example of multiple smaller things coming together and amplifying each other.
1. I navigated to the class side of RBVariableNode and noticed the button with the clock & backward arrow on it
2. Clicking it, lead me to a list of commits perfectly scoped to the methods in question. There, I clicked on the SHA of the last commit
3. I was presented with a) the image version where it was integrated b) the issues integrated, and c) the method diffs!!!
I didn't realize that e.g. the update and issue numbers were on github. This is really great. Cheers, Sean
View this message in context: Re: PetitParser Tests Failing in Pharo 4.0 Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
2015-03-04 16:59 GMT+01:00 Sean P. DeNigris <sean@clipperadams.com>:
RBVariableNode DNU #identifierToken:
Removed since Pharo 3.0. No deprecation. Searching dev list & fogbugz -> 0 hits.
- > 11992 <https://pharo.fogbugz.com/default.asp?11992> Remove tokens from the AST-Core-Node classes
Guys, we need some discipline.
----- Cheers, Sean -- View this message in context: http://forum.world.st/PetitParser-Tests-Failing-in-Pharo-4-0-tp4809513.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Marcus Denker -
Nicolai Hess -
Sean P. DeNigris -
Sven Van Caekenberghe