Made changes in the Metaclasses chapter regarding syntax. Link to the pull request: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/pull/5 Kindly review the pull request.
Gaurav Singh wrote
Kindly review the pull request.
Thanks! I reviewed and commented there. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Pull-Request-for-UpdatedPharoByExample-tp4816485p48165... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Made another commit with the necessary corrections, Kindly look into it :)
Gaurav Singh wrote
Made another commit with the necessary corrections, Kindly look into it :)
Looks good but Travis is failing (https://travis-ci.org/SquareBracketAssociates/UpdatedPharoByExample/builds/5...). I wonder why... Preparing Pillar image ./pharo: line 11: /home/travis/build/SquareBracketAssociates/UpdatedPharoByExample/pharo-vm/pharo: No such file or directory The command "./download.sh" failed and exited with 127 during . ----- Cheers, Sean -- View this message in context: http://forum.world.st/Pull-Request-for-UpdatedPharoByExample-tp4816485p48165... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Yeah its failing, but there shouldn't be any reason for it to fail, because only three lines have been changed which shouldn't affect ./download.sh to fail. On Wed, Apr 1, 2015 at 5:48 AM, Sean P. DeNigris <sean@clipperadams.com> wrote:
Gaurav Singh wrote
Made another commit with the necessary corrections, Kindly look into it :)
Looks good but Travis is failing ( https://travis-ci.org/SquareBracketAssociates/UpdatedPharoByExample/builds/5... ). I wonder why... Preparing Pillar image
./pharo: line 11:
/home/travis/build/SquareBracketAssociates/UpdatedPharoByExample/pharo-vm/pharo: No such file or directory
The command "./download.sh" failed and exited with 127 during .
----- Cheers, Sean -- View this message in context: http://forum.world.st/Pull-Request-for-UpdatedPharoByExample-tp4816485p48165... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Yeah its failing, but there shouldn't be any reason for it to fail, because only three lines have been changed which shouldn't affect ./download.sh to fail. Yes, it seems obviously unrelated to your fix...
----- Cheers, Sean -- View this message in context: http://forum.world.st/Pull-Request-for-UpdatedPharoByExample-tp4816485p48165... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
If we see the build history on travis , we can see that travis is failing on previous commits too which were made in the last few days . On Wed, Apr 1, 2015 at 5:58 AM, Sean P. DeNigris <sean@clipperadams.com> wrote:
Yeah its failing, but there shouldn't be any reason for it to fail, because only three lines have been changed which shouldn't affect ./download.sh to fail. Yes, it seems obviously unrelated to your fix...
Cheers, Sean
------------------------------ View this message in context: Re: Pull Request for UpdatedPharoByExample <http://forum.world.st/Pull-Request-for-UpdatedPharoByExample-tp4816485p48165...>
Sent from the Pharo Smalltalk Developers mailing list archive <http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html> at Nabble.com.
Yeah, I've noticed the Travis build failing. I suspect it's something with the config (or DNS, or the package list..). I opened an issue for it: https://github.com/SquareBracketAssociates/UpdatedPharoByExample/issues/4 Also, while we're on the subject - what's the difference between the Jenkins job for the book, and the Travis CI? Why have two? On Tue, Mar 31, 2015 at 8:28 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
Yeah its failing, but there shouldn't be any reason for it to fail, because only three lines have been changed which shouldn't affect ./download.sh to fail. Yes, it seems obviously unrelated to your fix...
Cheers, Sean
------------------------------ View this message in context: Re: Pull Request for UpdatedPharoByExample <http://forum.world.st/Pull-Request-for-UpdatedPharoByExample-tp4816485p48165...>
Sent from the Pharo Smalltalk Developers mailing list archive <http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html> at Nabble.com.
participants (3)
-
Dmitri Zagidulin -
Gaurav Singh -
Sean P. DeNigris