Re: [Pharo-project] Adding "Extended Search" to OB context menu
Sure, that can be done. The point is that the RB code menu is fully implemented in OB now. Previously OB just used the menu provided by Pharo, what caused all kinds of problems. "Method source with it" was never an operation backed by OB. Lukas On 9 May 2011 11:46, Damien Cassou <damien.cassou@gmail.com> wrote:
Hi Lukas,
do you think it would be possible to use what is currently selected in the code pane to set the default value of the 'Refactor -> Search code' window?
---------- Forwarded message ---------- From: Mariano Martinez Peck <marianopeck@gmail.com> Date: Mon, May 9, 2011 at 10:56 AM Subject: Re: [Pharo-project] Adding "Extended Search" to OB context menu To: Pharo-project@lists.gforge.inria.fr
Have you tried 'Refactor -> Search code' ?
Thanks Damien. But that's something completely different. What I want to do is to select text, right button, method source with it. That's all.
-- Damien Cassou http://damiencassou.seasidehosting.st
"Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry
-- Lukas Renggli www.lukas-renggli.ch
On Mon, May 9, 2011 at 1:57 PM, Lukas Renggli <renggli@gmail.com> wrote:
Sure, that can be done.
The point is that the RB code menu is fully implemented in OB now.
Thanks Lukas. I am not sure if you understand my question. I am not doing anything at all with RB. So I don't see how this is related to do a right click in the code pane. I attach two screenshots, "oldOB" and "newOB". What I am asking is to have the "extended search" or the "method soruce with it" from "oldOB". thanks in advance Mariano
Previously OB just used the menu provided by Pharo, what caused all kinds of problems. "Method source with it" was never an operation backed by OB.
Lukas
On 9 May 2011 11:46, Damien Cassou <damien.cassou@gmail.com> wrote:
Hi Lukas,
do you think it would be possible to use what is currently selected in the code pane to set the default value of the 'Refactor -> Search code' window?
---------- Forwarded message ---------- From: Mariano Martinez Peck <marianopeck@gmail.com> Date: Mon, May 9, 2011 at 10:56 AM Subject: Re: [Pharo-project] Adding "Extended Search" to OB context menu To: Pharo-project@lists.gforge.inria.fr
Have you tried 'Refactor -> Search code' ?
Thanks Damien. But that's something completely different. What I want to do is to select text, right button, method source with it. That's all.
-- Damien Cassou http://damiencassou.seasidehosting.st
"Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
I am not asking a question. I am just saying that the new OB does not use the default menu of the Pharo text editor anymore. Like this developers have full control and can use OB outside a Smalltalk context. In fact there are already many browsers (CodeCritics, Changes, Diff, Versions, Bytecode, Comments, etc) where most of the default menus don't make sense. So for you this means that you need to contribute that functionality in terms of an OBCommand; or use the old keybinding that still is passed to the text editor as long as OB doesn't reuse it otherwise. Lukas On Monday, 9 May 2011, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
On Mon, May 9, 2011 at 1:57 PM, Lukas Renggli <renggli@gmail.com> wrote:
Sure, that can be done.
The point is that the RB code menu is fully implemented in OB now.
Thanks Lukas. I am not sure if you understand my question. I am not doing anything at all with RB. So I don't see how this is related to do a right click in the code pane. I attach two screenshots, "oldOB" and "newOB". What I am asking is to have the "extended search" or the "method soruce with it" from "oldOB".
thanks in advance
Mariano
Previously OB just used the menu provided by Pharo, what caused all kinds of problems. "Method source with it" was never an operation backed by OB.
Lukas
On 9 May 2011 11:46, Damien Cassou <damien.cassou@gmail.com> wrote:
Hi Lukas,
do you think it would be possible to use what is currently selected in the code pane to set the default value of the 'Refactor -> Search code' window?
---------- Forwarded message ---------- From: Mariano Martinez Peck <marianopeck@gmail.com> Date: Mon, May 9, 2011 at 10:56 AM Subject: Re: [Pharo-project] Adding "Extended Search" to OB context menu To: Pharo-project@lists.gforge.inria.fr
Have you tried 'Refactor -> Search code' ?
Thanks Damien. But that's something completely different. What I want to do is to select text, right button, method source with it. That's all.
-- Damien Cassou http://damiencassou.seasidehosting.st
"Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
-- Lukas Renggli www.lukas-renggli.ch
Lukas. I did a little experiment. It is "working" here. I attach changeset. Two things I am not sure: 1) if I should implement OBTextSelection >> methodSourceWithIt self subclassResponsibility 2) If I should define a shortcut or not Cheers Mariano On Mon, May 9, 2011 at 5:49 PM, Lukas Renggli <renggli@gmail.com> wrote:
I am not asking a question. I am just saying that the new OB does not use the default menu of the Pharo text editor anymore. Like this developers have full control and can use OB outside a Smalltalk context. In fact there are already many browsers (CodeCritics, Changes, Diff, Versions, Bytecode, Comments, etc) where most of the default menus don't make sense.
So for you this means that you need to contribute that functionality in terms of an OBCommand; or use the old keybinding that still is passed to the text editor as long as OB doesn't reuse it otherwise.
Lukas
On Monday, 9 May 2011, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
On Mon, May 9, 2011 at 1:57 PM, Lukas Renggli <renggli@gmail.com> wrote:
Sure, that can be done.
The point is that the RB code menu is fully implemented in OB now.
Thanks Lukas. I am not sure if you understand my question. I am not doing
anything at all with RB. So I don't see how this is related to do a right click in the code pane.
I attach two screenshots, "oldOB" and "newOB". What I am asking is to have the "extended search" or the "method soruce with it" from "oldOB".
thanks in advance
Mariano
Previously OB just used the menu provided by Pharo, what caused all kinds of problems. "Method source with it" was never an operation backed by OB.
Lukas
On 9 May 2011 11:46, Damien Cassou <damien.cassou@gmail.com> wrote:
Hi Lukas,
do you think it would be possible to use what is currently selected in the code pane to set the default value of the 'Refactor -> Search code' window?
---------- Forwarded message ---------- From: Mariano Martinez Peck <marianopeck@gmail.com> Date: Mon, May 9, 2011 at 10:56 AM Subject: Re: [Pharo-project] Adding "Extended Search" to OB context menu To: Pharo-project@lists.gforge.inria.fr
Have you tried 'Refactor -> Search code' ?
Thanks Damien. But that's something completely different. What I want to do is to select text, right button, method source with it. That's all.
-- Damien Cassou http://damiencassou.seasidehosting.st
"Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
participants (2)
-
Lukas Renggli -
Mariano Martinez Peck