Re: [Pharo-project] Replacing 'ReadStream on smth:' by 'smth readStream'
Damien, The only potential problem is that you assume tests will catch everything. However, I think streams are broken, and I will certainly help fix what we break in getting them right. Bill Wilhelm K. Schwab, Ph.D. University of Florida Department of Anesthesiology PO Box 100254 Gainesville, FL 32610-0254 Email: bschwab@anest.ufl.edu Tel: (352) 846-1285 FAX: (352) 392-7029
damien.cassou@gmail.com 05/30/08 9:37 AM >>> On Fri, May 30, 2008 at 2:18 PM, Adrian Lienhard <adi@netstyle.ch> wrote: Have you verified that your change does not inadvertently modify any behavior? Its not likely, but changes like this can introduce subtle bugs. For instance, Matrix overrides readStream. So if there exists any use of "ReadStream on: aMatrix" that is there to bypass the overridden behavior, the code will break.
It should not break anything (if it does, the test will fail and I will fix things :-)). In fact, ReadStream only deals with SequenceableStreams so it should be ok. Do you agree? -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu) _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Fri, May 30, 2008 at 5:54 PM, Bill Schwab <BSchwab@anest.ufl.edu> wrote:
Damien,
The only potential problem is that you assume tests will catch everything. However, I think streams are broken, and I will certainly help fix what we break in getting them right.
I guess the change I'm applying won't cause any problem but I can't be sure. I won't loose time fixing Streams as I would prefer installing Nile if everybody agree. -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
The only potential problem is that you assume tests will catch everything. However, I think streams are broken, and I will certainly help fix what we break in getting them right.
I guess the change I'm applying won't cause any problem but I can't be sure. I won't loose time fixing Streams as I would prefer installing Nile if everybody agree.
Nile seems the way to go. Now could you guys do a summary and proposal with actions. So that we can have one clear summary and situation. stef
participants (3)
-
Bill Schwab -
Damien Cassou -
Stéphane Ducasse