[Pharo-project] Issue 3247 in pharo: Remodel Text Constants
Status: New Owner: ---- New issue 3247 by Benjamin.VanRyseghem.Pharo: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Gofer new squeaksource: 'PharoTaskForces'; package: 'KillTextConstants'; load. KillTextConstants new script. It remodel TextConstants as a SharedPool, and create a global dictionary SharedDictionary to allow classes to share constants. One step is missing, the one which check all methods invoking SharedDictionary to know if they really use SharedDictionary or pool variables from TextConstants
Updates: Status: Fixed Comment #1 on issue 3247 by Benjamin.VanRyseghem: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 (No comment was entered for this change.)
Comment #2 on issue 3247 by Benjamin.VanRyseghem.Pharo: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 A new version is available, where I fix the bug about poolDictionaries and where I fix 3 classes. If someone want to play with it, enjoy ^^
Updates: Labels: Milestone-1.2 Comment #3 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 I will have a look later in the afternoon but this is true that we should have a look at that because this is good to fix it.
Updates: Cc: marcus.denker adrian.lienhard siguctua Comment #4 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 (No comment was entered for this change.)
Comment #5 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 I read all the code and this looks quite good. I will run it now and check if I can release package after.
Comment #6 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Benjamin, it would be good to rename SharedDictionary into something like TextSharedInformation.
Comment #7 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Then we could define such dictionary as a classVar of the new sharedPool class TextConstant. Like that we minimize the globals in the system.
Updates: Cc: -siguctua Comment #8 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Then I do not understand why You changed | letter varAndValue tempArray width | "CtrlA..CtrlZ, Ctrla..Ctrlz" letter := $A. #( 212 230 228 196 194 226 241 243 214 229 200 217 246 245 216 202 210 239 211 240 197 198 209 215 242 231 1 166 228 132 130 12 232 179 150 165 136 153 182 14 15 138 17 18 19 11 21 134 145 151 178 167 ) do: [:kbd | TextContants at: ('Ctrl', letter asSymbol) asSymbol put: kbd asCharacter. letter := letter == $Z ifTrue: [$a] ifFalse: [(letter asciiValue + 1) asCharacter]]. into | letter varAndValue tempArray width | "CtrlA..CtrlZ, Ctrla..Ctrlz" letter := $A. #( 212 230 228 196 194 226 241 243 214 229 200 217 246 245 216 202 210 239 211 240 197 198 209 215 242 231 1 166 228 132 130 12 232 179 150 165 136 153 182 14 15 138 17 18 19 11 21 134 145 151 178 167 ) do: [:kbd | SharedDictionary at: ('Ctrl', letter asSymbol) asSymbol put: kbd asCharacter. letter := letter == $Z ifTrue: [$a] ifFalse: [(letter asciiValue + 1) asCharacter]]. The idea is to have TextConstant (the new shared) containing the constants and the other dictionary the variable part but here this is clearly constant.
Comment #9 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 The TextConstant class>>initialize could be better since we cannot reproduce it (or somehow) Ctrll := $ should be something like Ctrll := Character value: XCXXC like that we do not really on an invisible character
Comment #10 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 I have the impression that we should add a ClassVar to TextStyle and that a lot of changes where simply puts in the wrong place. all the methods in TextStyle class for example. Similarly HostFont should have a classVariables for its fonts! Same probably for StrikeFont May be should perform these changes first. Like that the migration will be easier.
Comment #11 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Ben when a class uses a Pool you can use the key of the variable instead of the at: expression For example: text: aText "Answer an instance of me such that the text displayed is aText according to the system's default text style." ^self new setText: aText textStyle: DefaultTextStyle copy offset: 0 @ 0 is better than text: aText "Answer an instance of me such that the text displayed is aText according to the system's default text style." ^self new setText: aText textStyle: (SharedDictionary at: #DefaultTextStyle) copy offset: 0 @ 0
Comment #12 on issue 3247 by Benjamin.VanRyseghem.Pharo: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Comment 8 : This method should be removed (I'll write a fix asap) Comment 9 : I will take a look at that too Comment 10 : For sure, there is a lot of classes to fix, but I can't script that Comment 11 : DefaultTextStyle is not in the SharedPool, but in the SharedDictionary
Comment #13 on issue 3247 by stephane.ducasse: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 may be we can just do the changes for some items of comment 10 by hand.
Comment #14 on issue 3247 by Benjamin.VanRyseghem.Pharo: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Update done ^^
Comment #15 on issue 3247 by Benjamin.VanRyseghem.Pharo: Remodel Text Constants http://code.google.com/p/pharo/issues/detail?id=3247 Now the dictionary for shared values is named TextSharedInformations and it is a class variable of TextConstants. Moreover, I have added TextConstants in the poolDictionaries of classes which formely invoke the dictionary
participants (1)
-
pharo＠googlecode.com