problems with RPackage and cie...
Hi! We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug. Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Do you have an issue on that? Or does it happens just when moving classes from any package to another? Thierry Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Do you have an issue on that? Or does it happens just when moving classes from any package to another?
I do not know. I do not see on https://pharo.fogbugz.com how I can list issues that contains the RPackage and that are still open. The problems we are facing usually involves having more than one browser opened, dragging classes from one browser to another browser. Hard to be more accurate because students are calling me to the rescue when they are already in the mess. We can put images online if this help. Alexandre
Thierry
Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Le 15/01/2014 16:46, Alexandre Bergel a écrit :
Do you have an issue on that? Or does it happens just when moving classes from any package to another?
I do not know. I do not see on https://pharo.fogbugz.com how I can list issues that contains the RPackage and that are still open.
The problems we are facing usually involves having more than one browser opened, dragging classes from one browser to another browser. Hard to be more accurate because students are calling me to the rescue when they are already in the mess. We can put images online if this help.
Ok, this could be in Nautilus. I was drag and dropping in AltBrowser and couldn't see anything wrong, but I'm not exercising the same code paths on RPackage than Nautilus does. As far as AltBrowser goes, recompiling the class with a new system category is picked up fine (apart from the disappearing tag). Thierry
Alexandre
Thierry
Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
We are also facing some RPackage cache not in sync anymore with system leading to the impossibility to commit the code :( Ben On 15 Jan 2014, at 12:56, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 15/01/2014 16:46, Alexandre Bergel a écrit :
Do you have an issue on that? Or does it happens just when moving classes from any package to another?
I do not know. I do not see on https://pharo.fogbugz.comhow I can list issues that contains the RPackage and that are still open.
The problems we are facing usually involves having more than one browser opened, dragging classes from one browser to another browser. Hard to be more accurate because students are calling me to the rescue when they are already in the mess. We can put images online if this help.
Ok, this could be in Nautilus.
I was drag and dropping in AltBrowser and couldn't see anything wrong, but I'm not exercising the same code paths on RPackage than Nautilus does.
As far as AltBrowser goes, recompiling the class with a new system category is picked up fine (apart from the disappearing tag).
Thierry
Alexandre
Thierry
Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Le 15/01/2014 16:59, Benjamin a écrit :
We are also facing some RPackage cache not in sync anymore with system leading to the impossibility to commit the code :(
Ben
I'm onto something with very few manipulations. Now I have a class belonging to A listed in B too, but with the system category of A. And, if I inspect the B RPackage, there is no reference to that class. Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Ben had to define the method on the class RPackage: forceRefreshClassDefinedSelectors | dict | dict := Dictionary new. self definedClasses do: [ :e || set | set := Set new. e protocols select: [ :p | (p beginsWith: '*') not ] thenDo: [ :p | (e methodsInProtocol: p) do: [ :m | set add: m selector ] ]. dict at: e name put:set ]. classDefinedSelectors := dict Alexandre On Jan 15, 2014, at 12:59 PM, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote:
We are also facing some RPackage cache not in sync anymore with system leading to the impossibility to commit the code :(
Ben
On 15 Jan 2014, at 12:56, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 15/01/2014 16:46, Alexandre Bergel a écrit :
Do you have an issue on that? Or does it happens just when moving classes from any package to another?
I do not know. I do not see on https://pharo.fogbugz.comhow I can list issues that contains the RPackage and that are still open.
The problems we are facing usually involves having more than one browser opened, dragging classes from one browser to another browser. Hard to be more accurate because students are calling me to the rescue when they are already in the mess. We can put images online if this help.
Ok, this could be in Nautilus.
I was drag and dropping in AltBrowser and couldn't see anything wrong, but I'm not exercising the same code paths on RPackage than Nautilus does.
As far as AltBrowser goes, recompiling the class with a new system category is picked up fine (apart from the disappearing tag).
Thierry
Alexandre
Thierry
Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
but that is a hack, not a real solution⦠we need to find the place where RPackage loses the update. On 15 Jan 2014, at 18:17, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Ben had to define the method on the class RPackage:
forceRefreshClassDefinedSelectors | dict |
dict := Dictionary new. self definedClasses do: [ :e || set | set := Set new. e protocols select: [ :p | (p beginsWith: '*') not ] thenDo: [ :p | (e methodsInProtocol: p) do: [ :m | set add: m selector ] ]. dict at: e name put:set ]. classDefinedSelectors := dict
Alexandre
On Jan 15, 2014, at 12:59 PM, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote:
We are also facing some RPackage cache not in sync anymore with system leading to the impossibility to commit the code :(
Ben
On 15 Jan 2014, at 12:56, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 15/01/2014 16:46, Alexandre Bergel a écrit :
Do you have an issue on that? Or does it happens just when moving classes from any package to another?
I do not know. I do not see on https://pharo.fogbugz.comhow I can list issues that contains the RPackage and that are still open.
The problems we are facing usually involves having more than one browser opened, dragging classes from one browser to another browser. Hard to be more accurate because students are calling me to the rescue when they are already in the mess. We can put images online if this help.
Ok, this could be in Nautilus.
I was drag and dropping in AltBrowser and couldn't see anything wrong, but I'm not exercising the same code paths on RPackage than Nautilus does.
As far as AltBrowser goes, recompiling the class with a new system category is picked up fine (apart from the disappearing tag).
Thierry
Alexandre
Thierry
Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Just that you know I faced it again :( I created a new RPackage, move classes in the newly created RPackage. And when I wanted to commit the code, it was empty. I added also forceRefreshMetaclassDefinedSelectors | dict | dict := Dictionary new. self definedClasses do: [ :e || set | set := Set new. e class protocols select: [ :p | (p beginsWith: '*') not ] thenDo: [ :p | (e class methodsInProtocol: p) do: [ :m | set add: m selector ] ]. dict at: e name put:set ]. metaclassDefinedSelectors := dict and this with the previous snippet saved my ass 2014/1/15 Esteban Lorenzano <estebanlm@gmail.com>
but that is a hack, not a real solution⦠we need to find the place where RPackage loses the update.
On 15 Jan 2014, at 18:17, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Ben had to define the method on the class RPackage:
forceRefreshClassDefinedSelectors | dict |
dict := Dictionary new. self definedClasses do: [ :e || set | set := Set new. e protocols select: [ :p | (p beginsWith: '*') not ] thenDo: [ :p | (e methodsInProtocol: p) do: [ :m | set add: m selector ] ]. dict at: e name put:set ]. classDefinedSelectors := dict
Alexandre
On Jan 15, 2014, at 12:59 PM, Benjamin < benjamin.vanryseghem.pharo@gmail.com> wrote:
We are also facing some RPackage cache not in sync anymore with system leading to the impossibility to commit the code :(
Ben
On 15 Jan 2014, at 12:56, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 15/01/2014 16:46, Alexandre Bergel a écrit :
Do you have an issue on that? Or does it happens just when moving
classes from any package to another?
I do not know. I do not see on https://pharo.fogbugz.comhow I can
list issues that contains the RPackage and that are still open.
The problems we are facing usually involves having more than one
browser opened, dragging classes from one browser to another browser. Hard to be more accurate because students are calling me to the rescue when they are already in the mess. We can put images online if this help.
Ok, this could be in Nautilus.
I was drag and dropping in AltBrowser and couldn't see anything wrong, but I'm not exercising the same code paths on RPackage than Nautilus does.
As far as AltBrowser goes, recompiling the class with a new system category is picked up fine (apart from the disappearing tag).
Thierry
Alexandre
Thierry
Le 15/01/2014 16:34, Alexandre Bergel a écrit :
Hi!
We are constantly facing problems when moving classes between
packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Alexandre
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Le 23/01/2014 18:57, Benjamin Van Ryseghem a écrit :
Just that you know I faced it again :( I created a new RPackage, move classes in the newly created RPackage. And when I wanted to commit the code, it was empty.
Have you tried with the old Browser to see if your classes were in the right category? (When I see something suspicious like that happening, I often open the three browsers to double check: AltBrowser, Nautilus and Browser). And I have not seen anything suspicious that I could pinpoint to RPackage so far. Small bugs easily corrected, yes. Big totally out of sync, no. Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
I would really like a reproducible case⦠in the form of an image, if no else. btw⦠moose 5.0 images are severely broken in that area, so if you are using one of them you *will* have problems. Esteban On 24 Jan 2014, at 13:28, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 23/01/2014 18:57, Benjamin Van Ryseghem a écrit :
Just that you know I faced it again :( I created a new RPackage, move classes in the newly created RPackage. And when I wanted to commit the code, it was empty.
Have you tried with the old Browser to see if your classes were in the right category?
(When I see something suspicious like that happening, I often open the three browsers to double check: AltBrowser, Nautilus and Browser).
And I have not seen anything suspicious that I could pinpoint to RPackage so far. Small bugs easily corrected, yes. Big totally out of sync, no.
Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Step to reproduce: Open latest Pharo30719. Create a new package with shortcut or menu. Name it âAST-Monkeyâ (to have a RPackage not a Tag) Go in another package. Select some classes. CMD M + CMD C (and probably with the menu too) (note that the Drag nâ Drop works) Type the name of the package âAST-Monkeyâ + enter BOUM Might be that you fixed the drag n drop in the PackageTreeNautilusUI but not the move class. Ben On 24 Jan 2014, at 10:23, Esteban Lorenzano <estebanlm@gmail.com> wrote:
I would really like a reproducible case⦠in the form of an image, if no else.
btw⦠moose 5.0 images are severely broken in that area, so if you are using one of them you *will* have problems.
Esteban
On 24 Jan 2014, at 13:28, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 23/01/2014 18:57, Benjamin Van Ryseghem a écrit :
Just that you know I faced it again :( I created a new RPackage, move classes in the newly created RPackage. And when I wanted to commit the code, it was empty.
Have you tried with the old Browser to see if your classes were in the right category?
(When I see something suspicious like that happening, I often open the three browsers to double check: AltBrowser, Nautilus and Browser).
And I have not seen anything suspicious that I could pinpoint to RPackage so far. Small bugs easily corrected, yes. Big totally out of sync, no.
Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
https://pharo.fogbugz.com/f/cases/12718 that should fix the problem. weâll see :P Esteban On 24 Jan 2014, at 14:58, Benjamin <Benjamin.VanRyseghem.Pharo@gmail.com> wrote:
Step to reproduce:
Open latest Pharo30719. Create a new package with shortcut or menu. Name it âAST-Monkeyâ (to have a RPackage not a Tag) Go in another package. Select some classes. CMD M + CMD C (and probably with the menu too) (note that the Drag nâ Drop works) Type the name of the package âAST-Monkeyâ + enter BOUM
Might be that you fixed the drag n drop in the PackageTreeNautilusUI but not the move class.
Ben
On 24 Jan 2014, at 10:23, Esteban Lorenzano <estebanlm@gmail.com> wrote:
I would really like a reproducible case⦠in the form of an image, if no else.
btw⦠moose 5.0 images are severely broken in that area, so if you are using one of them you *will* have problems.
Esteban
On 24 Jan 2014, at 13:28, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Le 23/01/2014 18:57, Benjamin Van Ryseghem a écrit :
Just that you know I faced it again :( I created a new RPackage, move classes in the newly created RPackage. And when I wanted to commit the code, it was empty.
Have you tried with the old Browser to see if your classes were in the right category?
(When I see something suspicious like that happening, I often open the three browsers to double check: AltBrowser, Nautilus and Browser).
And I have not seen anything suspicious that I could pinpoint to RPackage so far. Small bugs easily corrected, yes. Big totally out of sync, no.
Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
On 15 Jan 2014, at 16:34, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Yes, this one: https://pharo.fogbugz.com/f/cases/12655/RPackage-bug-when-moving-a-class-to-...
Le 15/01/2014 16:46, Marcus Denker a écrit :
On 15 Jan 2014, at 16:34, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
We are constantly facing problems when moving classes between packages. This is highly discouraging. This involves tricky parts of the system that both difficult to understand and to debug.
Yes, this one:
https://pharo.fogbugz.com/f/cases/12655/RPackage-bug-when-moving-a-class-to-...
That's one more, then :) Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
participants (6)
-
Alexandre Bergel -
Benjamin -
Benjamin Van Ryseghem
-
Esteban Lorenzano -
Goubier Thierry -
Marcus Denker