[Pharo-project] problem with find & replace in PharoCore 1.2
First, Alain, let me congratulate you because of this wonderful improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work. Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;) I should do that when I change the method I guess, or when I press cancel. Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button. Thanks mariano
+1 On Thu, Dec 2, 2010 at 5:27 PM, Mariano Martinez Peck <marianopeck@gmail.com
wrote:
First, Alain, let me congratulate you because of this wonderful improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.
Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;) I should do that when I change the method I guess, or when I press cancel.
Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.
Thanks
mariano
Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :
First, Alain, let me congratulate you because of this wonderful improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work. thanks Mariano,
Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;) I should do that when I change the method I guess, or when I press cancel.
the orange color is for the current searched text which is updated while you are typing some text in the find field. It is the same when you select some text and cmd-h. so I can set the search text to empty string if one cancel the find & replace. is it what you want ? notice that you can do that with cmd-h with nothing selected in the current text morph.
Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.
sorry, I don't really understand. You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ? Cheers Alain
Thanks
mariano
On Thu, Dec 2, 2010 at 5:53 PM, Alain Plantec <alain.plantec@free.fr> wrote:
Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :
First, Alain, let me congratulate you because of this wonderful
improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.
thanks Mariano,
Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;) I should do that when I change the method I guess, or when I press cancel.
the orange color is for the current searched text which is updated while you are typing some text in the find field. It is the same when you select some text and cmd-h. so I can set the search text to empty string if one cancel the find & replace. is it what you want ? notice that you can do that with cmd-h with nothing selected in the current text morph.
imho setting search text to empty string in any other context different that the place you did the search would be the best As an example if i search for "self" browsing a method even if after i open an Inspector i can see "self" highlighted Cheers, Francisco
Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.
sorry, I don't really understand. You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ?
Cheers Alain
Thanks
mariano
On Thu, Dec 2, 2010 at 10:19 PM, Francisco Ortiz Peñaloza < patchinko@gmail.com> wrote:
On Thu, Dec 2, 2010 at 5:53 PM, Alain Plantec <alain.plantec@free.fr>wrote:
Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :
First, Alain, let me congratulate you because of this wonderful
improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.
thanks Mariano,
Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;) I should do that when I change the method I guess, or when I press cancel.
the orange color is for the current searched text which is updated while you are typing some text in the find field. It is the same when you select some text and cmd-h. so I can set the search text to empty string if one cancel the find & replace. is it what you want ? notice that you can do that with cmd-h with nothing selected in the current text morph.
imho setting search text to empty string in any other context different that the place you did the search would be the best
As an example if i search for "self" browsing a method even if after i open an Inspector i can see "self" highlighted
Exatly. That's another problem. The scope. For me it should be only the method you are browsing.... or maybe an option to select scope: - current method - all methods of current class - all classes (all system browser) And, in my opinion, it should only put colors to the system browser...I don't know if it is worth it to do it also in Inspector, Debugger, workspace, etc....
Cheers, Francisco
Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.
sorry, I don't really understand. You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ?
Cheers Alain
Thanks
mariano
On Thu, Dec 2, 2010 at 9:53 PM, Alain Plantec <alain.plantec@free.fr> wrote:
Le 02/12/2010 21:27, Mariano Martinez Peck a écrit :
First, Alain, let me congratulate you because of this wonderful
improvemnt. I found myself several times copying code to a text editor to do exactly that and then come back to pharo...anyway, awesome work.
thanks Mariano,
Now, I have a little bug. Suppose I search something, in this case, I serached the word "new" in testParagraphExtent Now...it shows all the "new" with a orange color. Perfect. But then I put cancel, I go to other methods, and it is still painting "new"!!! ;) I should do that when I change the method I guess, or when I press cancel.
the orange color is for the current searched text which is updated while you are typing some text in the find field. It is the same when you select some text and cmd-h. so I can set the search text to empty string if one cancel the find & replace. is it what you want ?
I guess so. What I mean is....when the find/replace finished instead??? my problem is that even closing the popup it continues putting colors...so...until when? forever?
notice that you can do that with cmd-h with nothing selected in the current text morph.
Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button.
sorry, I don't really understand. You just want an additional menu item it the window menu in order to be able to close the find & replace dialog from there ?
Cheers Alain
Thanks
mariano
On Fri, Dec 3, 2010 at 3:33 PM, Alain Plantec <alain.plantec@free.fr> wrote:
I guess so. What I mean is....when the find/replace finished instead??? my
problem is that even closing the popup it continues putting colors...so...until when? forever?
click on the text (empty selection, visible caret), then cmd-h
hehehe that worked...but its it a bit cryptic? ;) can the cancel button do that for me? :) mariano
Last little thing is that it would be nice to have the find & replace like a popup, so that you can close it from the windows title in addition to "close" button. ok, you just want a normal window top bar with a red button for the find & replace dialog, that it ? alain
On Thu, Dec 2, 2010 at 10:04 PM, Alain Plantec <alain.plantec@free.fr>wrote:
Last little thing is that it would be nice to have the find & replace like
a popup, so that you can close it from the windows title in addition to "close" button.
ok, you just want a normal window top bar with a red button for the find & replace dialog, that it ?
ouiiiii :) I am lazy and closing from there is better than the close button for me. Some prefer that button, so we can have both :)
alain
participants (3)
-
Alain Plantec -
Francisco Ortiz Peñaloza -
Mariano Martinez Peck