[Pharo-project] Problem with OB compare versions - Issue 1033 again :(
Hi: In latest Dev version there is again this bug :( http://code.google.com/p/pharo/issues/detail?id=1033 The problem is that OBVersionBrowser DNU definitionPanel In previous versions OBBrowser has definitionPanel but in latest version it doesnt. I think the fix is as putting again: OBBrowser >> definitionPanel ^ panels detect: [:ea | ea isDefinition] ifNone: [self error: 'No definition panel configured'] Or maybe it should be in OBVersionBrowser ? Cheers Mariano
I fixed it in the latest commit. I also added a test for #definitionPanel. I've never seen the command for comparing versions before. The problem is that somebody added it without writing a test, so it is quite obvious that it breaks. Lukas 2010/1/16 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi: In latest Dev version there is again this bug :(
http://code.google.com/p/pharo/issues/detail?id=1033
The problem is that OBVersionBrowser DNU definitionPanel
In previous versions OBBrowser has definitionPanel but in latest version it doesnt.
I think the fix is as putting again:
OBBrowser >> definitionPanel ^ panels detect: [:ea | ea isDefinition] ifNone: [self error: 'No definition panel configured']
Or maybe it should be in OBVersionBrowser ?
Cheers
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
On Sat, Jan 16, 2010 at 11:32 PM, Lukas Renggli <renggli@gmail.com> wrote:
I fixed it in the latest commit. I also added a test for #definitionPanel.
Thanks. It is fixed :)
I've never seen the command for comparing versions before. The problem is that somebody added it without writing a test, so it is quite obvious that it breaks.
Sorry :( I am just the messenger hahah. Do only thing I am trying to do is a PharoDev image as much stable and with more green tests as possible. Sorry if I bother you a lot :( Thanks! Mariano
Lukas
2010/1/16 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi: In latest Dev version there is again this bug :(
http://code.google.com/p/pharo/issues/detail?id=1033
The problem is that OBVersionBrowser DNU definitionPanel
In previous versions OBBrowser has definitionPanel but in latest version it doesnt.
I think the fix is as putting again:
OBBrowser >> definitionPanel ^ panels detect: [:ea | ea isDefinition] ifNone: [self error: 'No definition panel configured']
Or maybe it should be in OBVersionBrowser ?
Cheers
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Lukas Renggli -
Mariano Martinez Peck