Rubric/Event handling issue?
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave. https://vimeo.com/139353992 To reproduce, Load DragPanels from StephanEggermont/DragPanels and NewUI from StephanEggermont/Documentation In a Playground open a panel CodePanel new openInWindowLabeled:'Code Panel' add a few cards (drop them in the panel) (CodeCard class: CodeCard selector: #initialize) openInHand and expand them by clicking on the arrow Right click on the empty area in the CodePanel and open the colors. A fast drag from the color panel to the rubric area of the code card sometimes results in the rubric editors losing their content. Stephan
ping On 15-09-15 17:49, Stephan Eggermont wrote:
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
To reproduce, Load DragPanels from StephanEggermont/DragPanels and NewUI from StephanEggermont/Documentation
In a Playground open a panel CodePanel new openInWindowLabeled:'Code Panel'
add a few cards (drop them in the panel) (CodeCard class: CodeCard selector: #initialize) openInHand and expand them by clicking on the arrow
Right click on the empty area in the CodePanel and open the colors. A fast drag from the color panel to the rubric area of the code card sometimes results in the rubric editors losing their content.
Stephan
2015-09-17 10:35 GMT+02:00 Stephan Eggermont <stephan@stack.nl>:
ping
On 15-09-15 17:49, Stephan Eggermont wrote:
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
To reproduce, Load DragPanels from StephanEggermont/DragPanels and NewUI from StephanEggermont/Documentation
In a Playground open a panel CodePanel new openInWindowLabeled:'Code Panel'
add a few cards (drop them in the panel) (CodeCard class: CodeCard selector: #initialize) openInHand and expand them by clicking on the arrow
Right click on the empty area in the CodePanel and open the colors. A fast drag from the color panel to the rubric area of the code card sometimes results in the rubric editors losing their content.
Stephan
DragWell startDrag: evt WorldState addDeferredUIMessage: [ evt hand grabMorph: self copy ]. calls Morph>>#copy and this makes a veryDeepCopy. I don't know exactly how this affects the other rubric text morphs, but replacing self copy with self shallowCopy seems to work.
On 17-09-15 23:11, Nicolai Hess wrote:
DragWell startDrag: evt WorldState addDeferredUIMessage: [ evt hand grabMorph: self copy ].
calls Morph>>#copy and this makes a veryDeepCopy.
I don't know exactly how this affects the other rubric text morphs, but replacing self copy with self shallowCopy seems to work.
Thanks. So there's something wrong with how I hold onto the Rubric text morph and or model. Something shouldn't be copied there. We don't have many examples of using veryDeepCopy and the fixups needed in image, and I'm not sure I fully understand the class comment of DeepCopier :( The clone menu option for a code card does a duplicate, and that creates the same problem as shown with the color panel. In CodeCard I hold onto both the model and the morph. They are connected using announcements, if I understand it correctly? Shouldn't that connection be rewired when doing a copy? Stephan
I forwarded to alain. Now this is the restart of the university... Stef Le 15/9/15 17:49, Stephan Eggermont a écrit :
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
To reproduce, Load DragPanels from StephanEggermont/DragPanels and NewUI from StephanEggermont/Documentation
In a Playground open a panel CodePanel new openInWindowLabeled:'Code Panel'
add a few cards (drop them in the panel) (CodeCard class: CodeCard selector: #initialize) openInHand and expand them by clicking on the arrow
Right click on the empty area in the CodePanel and open the colors. A fast drag from the color panel to the rubric area of the code card sometimes results in the rubric editors losing their content.
Stephan
On Tue, Sep 15, 2015 at 11:49 PM, Stephan Eggermont <stephan@stack.nl> wrote:
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
It looks like there was meant to be sound, but I didn't hear any (could just be me) cheers -ben
To reproduce, Load DragPanels from StephanEggermont/DragPanels and NewUI from StephanEggermont/Documentation
In a Playground open a panel CodePanel new openInWindowLabeled:'Code Panel'
add a few cards (drop them in the panel) (CodeCard class: CodeCard selector: #initialize) openInHand and expand them by clicking on the arrow
Right click on the empty area in the CodePanel and open the colors. A fast drag from the color panel to the rubric area of the code card sometimes results in the rubric editors losing their content.
Stephan
On 17-09-15 13:59, Ben Coman wrote:
On Tue, Sep 15, 2015 at 11:49 PM, Stephan Eggermont <stephan@stack.nl> wrote:
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
It looks like there was meant to be sound, but I didn't hear any (could just be me) cheers -ben
Yes, there is sound, and it is 720p video. I'm probably constructing the rubric editor incorrectly, and it would be good if that would only interfere with the ones I created... Stephan
On Thu, Sep 17, 2015 at 8:47 PM, Stephan Eggermont <stephan@stack.nl> wrote:
On 17-09-15 13:59, Ben Coman wrote:
On Tue, Sep 15, 2015 at 11:49 PM, Stephan Eggermont <stephan@stack.nl> wrote:
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
It looks like there was meant to be sound, but I didn't hear any (could just be me) cheers -ben
Yes, there is sound, and it is 720p video. I'm probably constructing the rubric editor incorrectly, and it would be good if that would only interfere with the ones I created...
Problem was at my end. cheers -ben
On 15-09-15 17:49, Stephan Eggermont wrote:
There is an interesting bad interaction between my drag-and-drop code and Rubric. It kills all Rubric editors at the same time, so it looks to me like a problem with the Rubric background thread interacting with mouseMove or mouseEnter/Leave.
I've removed the video. As noted by Henrik in 'RubAbstractTextArea copying', a RubScrolledTextMorph cannot be safely copied, which can be seen by opening the halos on a playground's edit space and trying to duplicate the morph. Stephan
participants (4)
-
Ben Coman -
Nicolai Hess -
Stephan Eggermont -
stepharo