[Pharo-project] XML-Support red tests
Hi XML-support has two red tests in Pharo 1.4 and Pharo2.0. Does anybody know if they were one day green? I do not want to put on the CI server something red. I will check on 1.3 to see if worked. Stef
Apparently they were green in in 1.2.1. This clearly shows why we need automated tools for that. Stef On Mar 2, 2013, at 10:16 PM, Stéphane Ducasse <Stephane.Ducasse@inria.fr> wrote:
Hi
XML-support has two red tests in Pharo 1.4 and Pharo2.0. Does anybody know if they were one day green?
I do not want to put on the CI server something red. I will check on 1.3 to see if worked.
Stef
Apparently in 1.2.1 the following method works for 1 5 #(1 2 3 4 5) 1 replaceFrom: start to: stop with: replacement startingAt: repStart "An ordered collection is growable, so a call to this can make the collection grow." self makeRoomFor: (stop - self capacity). array replaceFrom: start + firstIndex - 1 to: stop + firstIndex - 1 with: replacement startingAt: repStart. lastIndex := lastIndex max: stop + firstIndex - 1. but not in 1.4, 2.0 where the code is replaceFrom: start to: stop with: replacement startingAt: repStart "This destructively replaces elements from start to stop in the receiver starting at index, repStart, in the sequenceable collection, replacementCollection. Answer the receiver. No range checks are performed." | index repOff | repOff := repStart - start. index := start - 1. [(index := index + 1) <= stop] whileTrue: [self at: index put: (replacement at: repOff + index)] at: anInteger put: anObject "Put anObject at element index anInteger. at:put: cannot be used to append, front or back, to an ordered collection; it is used by a knowledgeable client to replace an element." self ensureBoundsFrom: anInteger to: anInteger. ^array at: anInteger + firstIndex - 1 put: anObject ensureBoundsFrom: fromIndex to: toIndex (fromIndex < 1) ifTrue: [^self errorSubscriptBounds: fromIndex]. (toIndex + firstIndex - 1 > lastIndex) ifTrue: [^self errorSubscriptBounds: toIndex]. On Mar 3, 2013, at 9:10 AM, stephane ducasse <stephane.ducasse@free.fr> wrote:
Apparently they were green in in 1.2.1. This clearly shows why we need automated tools for that.
Stef
On Mar 2, 2013, at 10:16 PM, Stéphane Ducasse <Stephane.Ducasse@inria.fr> wrote:
Hi
XML-support has two red tests in Pharo 1.4 and Pharo2.0. Does anybody know if they were one day green?
I do not want to put on the CI server something red. I will check on 1.3 to see if worked.
Stef
participants (2)
-
stephane ducasse -
Stéphane Ducasse