VersionnerRepositoriesManager - Why clear okAction?
No class is safe from my wrath he he... VersionnerRepositoriesManager class>>#open | dialog | dialog := remotesUI openDialogWithSpec. dialog okAction: [ ] - why were we wiping the okAction? "dialog okAction: [ ]" does not reveal any intention. At minimum, a comment would be good - it would be good to return something here so users can customize more easily. Even though this is tightly integrated with Versionner, a tiny bit of care makes the system more easily extensible. We should record some patterns here... ----- Cheers, Sean -- View this message in context: http://forum.world.st/VersionnerRepositoriesManager-Why-clear-okAction-tp478... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Hi Sean, Le 23 oct. 2014 à 23:16, Sean P. DeNigris a écrit :
No class is safe from my wrath he he...
VersionnerRepositoriesManager class>>#open | dialog | dialog := remotesUI openDialogWithSpec. dialog okAction: [ ]
- why were we wiping the okAction? "dialog okAction: [ ]" does not reveal any intention. At minimum, a comment would be good
I fully agree. I wrote the code some months ago and I forgot the reason ... I think the setting of the okAction is useless. I often put a comment but i miss this one. Thanks for the feedback.
- it would be good to return something here so users can customize more easily. Even though this is tightly integrated with Versionner, a tiny bit of care makes the system more easily extensible. We should record some patterns here...
Maybe what you need is RemotesManager. I extracted this component from Komitter.
demarey wrote
Maybe what you need is RemotesManager. I extracted this component from Komitter.
Thanks for the reply! Yes, I ended up using RemotesManager. ----- Cheers, Sean -- View this message in context: http://forum.world.st/VersionnerRepositoriesManager-Why-clear-okAction-tp478... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (2)
-
Christophe Demarey -
Sean P. DeNigris