Fix 'Search Code' menu item in Nautilus
Hi - The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow. The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite... Paul
Thanks Paul! We will check that for 4.0. Because Pharo 30 is only for major bugs. Stef
Hi -
The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow.
The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite...
Paul
Hi Paul, You also need to include the two dependencies of the slice, those need to be uploaded to the inbox too. Cheers, Max
On 04.11.2014, at 06:19, Paul DeBruicker <pdebruic@gmail.com> wrote:
Hi -
The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow.
The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite...
Paul
<SLICE-Issue-14382-Fix-Search-Code-refactoring-menu-item-in-Nautilus-PaulDeBruicker.1.mcz>
Thanks for the tip Max. I've uploaded the packages to the Pharo30Inbox repo. Max Leske wrote
Hi Paul,
You also need to include the two dependencies of the slice, those need to be uploaded to the inbox too.
Cheers, Max
On 04.11.2014, at 06:19, Paul DeBruicker <
pdebruic@
> wrote:
Hi -
The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow.
The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite...
Paul
<SLICE-Issue-14382-Fix-Search-Code-refactoring-menu-item-in-Nautilus-PaulDeBruicker.1.mcz>
-- View this message in context: http://forum.world.st/Fix-Search-Code-menu-item-in-Nautilus-tp4788273p478838... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
In general we need to discuss about Pharo3 non-bug improvements⦠=> we need to take care not to overdue it. If we change Pharo3 a lot, this will add a lot of double work and might introduce new bugs. => My personal rule is: even for bug fixes, if they are to be back ported to Pharo3 not just because âit would be niceâ. My personal threshold for that is simple: I will not do it, but if the fix is important enough *for someone else* to back port, than this is of a kind that should be considered. => We need to be cautious with new features⦠but then there might be cases where it makes sense.
On 04 Nov 2014, at 17:45, Paul DeBruicker <pdebruic@gmail.com> wrote:
Thanks for the tip Max. I've uploaded the packages to the Pharo30Inbox repo.
Max Leske wrote
Hi Paul,
You also need to include the two dependencies of the slice, those need to be uploaded to the inbox too.
Cheers, Max
On 04.11.2014, at 06:19, Paul DeBruicker <
pdebruic@
> wrote:
Hi -
The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow.
The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite...
Paul
<SLICE-Issue-14382-Fix-Search-Code-refactoring-menu-item-in-Nautilus-PaulDeBruicker.1.mcz>
-- View this message in context: http://forum.world.st/Fix-Search-Code-menu-item-in-Nautilus-tp4788273p478838... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 05.11.2014, at 09:39, Marcus Denker <marcus.denker@inria.fr> wrote:
In general we need to discuss about Pharo3 non-bug improvementsâ¦
=> we need to take care not to overdue it. If we change Pharo3 a lot, this will add a lot of double work and might introduce new bugs.
=> My personal rule is: even for bug fixes, if they are to be back ported to Pharo3 not just because âit would be niceâ. My personal threshold for that is simple: I will not do it, but if the fix is important enough *for someone else* to back port, than this is of a kind that should be considered.
=> We need to be cautious with new features⦠but then there might be cases where it makes sense.
Agreed.
On 04 Nov 2014, at 17:45, Paul DeBruicker <pdebruic@gmail.com> wrote:
Thanks for the tip Max. I've uploaded the packages to the Pharo30Inbox repo.
Max Leske wrote
Hi Paul,
You also need to include the two dependencies of the slice, those need to be uploaded to the inbox too.
Cheers, Max
On 04.11.2014, at 06:19, Paul DeBruicker <
pdebruic@
> wrote:
Hi -
The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow.
The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite...
Paul
<SLICE-Issue-14382-Fix-Search-Code-refactoring-menu-item-in-Nautilus-PaulDeBruicker.1.mcz>
-- View this message in context: http://forum.world.st/Fix-Search-Code-menu-item-in-Nautilus-tp4788273p478838... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Hi Marcus, I agree with your points. I'm just so habituated to using the three things I've 'fixed' in the past couple days it was really annoying to work in Pharo 3 vs. 1.4. FWIW - I don't really care if it gets into the 3.0 image as long as I can load the fix into my own Pharo 3. I contributed it back because it seems generally useful to let the computer find and format stuff, which I think has been missing since Pharo 2. I don't expect to fix anything else, if that helps.... ;) Paul Marcus Denker-4 wrote
In general we need to discuss about Pharo3 non-bug improvementsâ¦
=> we need to take care not to overdue it. If we change Pharo3 a lot, this will add a lot of double work and might introduce new bugs.
=> My personal rule is: even for bug fixes, if they are to be back ported to Pharo3 not just because âit would be niceâ. My personal threshold for that is simple: I will not do it, but if the fix is important enough *for someone else* to back port, than this is of a kind that should be considered.
=> We need to be cautious with new features⦠but then there might be cases where it makes sense.
On 04 Nov 2014, at 17:45, Paul DeBruicker <
pdebruic@
> wrote:
Thanks for the tip Max. I've uploaded the packages to the Pharo30Inbox repo.
Max Leske wrote
Hi Paul,
You also need to include the two dependencies of the slice, those need to be uploaded to the inbox too.
Cheers, Max
On 04.11.2014, at 06:19, Paul DeBruicker <
pdebruic@
> wrote:
Hi -
The attached slice makes the 'Search Code' menu item in Nautilus work like it did prior to the adoption of Nautilus in Pharo 3. I do not have commit rights to Pharo30Inbox but would submit it there if I did. I have not sent the contributor agreement but will tomorrow.
The issue in fogbugz is: https://pharo.fogbugz.com/f/cases/14382/Fix-Search-Code-refactoring-menu-ite...
Paul
<SLICE-Issue-14382-Fix-Search-Code-refactoring-menu-item-in-Nautilus-PaulDeBruicker.1.mcz>
-- View this message in context: http://forum.world.st/Fix-Search-Code-menu-item-in-Nautilus-tp4788273p478838... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- View this message in context: http://forum.world.st/Fix-Search-Code-menu-item-in-Nautilus-tp4788273p478859... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Marcus Denker -
Max Leske -
Paul DeBruicker -
stepharo