[Pharo-project] Issue 3715 in pharo: Workspace shouting after switching between shout/unshout
Status: Accepted Owner: Benjamin...@gmail.com New issue 3715 by Benjamin...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 I do not know why but when you switch unshout -> shout again in the menu, then when you automatically declare a variable, this one is not correctly shouted But first, I will fix the bold issue ^^
Updates: Status: Fixed Comment #1 on issue 3715 by Benjamin...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 Done. Now, instead of creating a new instance of the styler class, I store them in two variables (nullStyler and shoutedStyler), and I switch when needed. It solves the problem, generate less garbage, and allow to keep styler changements Attachments: FixPluggableTextMorphForBetterShouting.1.cs 1.7 KB
Updates: Labels: Milestone-1.3 Comment #2 on issue 3715 by stephane...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 (No comment was entered for this change.)
Updates: Status: Closed Comment #3 on issue 3715 by stephane...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 Benjamin I'm sure that there is a solution without the Smalltalk at:... Now that there is a NullStyler, it should be enough to pass another one, without these terrible checks. Smalltalk at: should not exist.
Comment #4 on issue 3715 by Benjamin...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 If you have an idea, i'm listening :) I'm totally agree with you that it's ugly, but at some point, you have to decide if you use the NullStyler or not ...
On Mar 2, 2011, at 10:25 AM, pharo@googlecode.com wrote:
Comment #4 on issue 3715 by Benjamin...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715
If you have an idea, i'm listening :)
I'm totally agree with you that it's ugly, but at some point, you have to decide if you use the NullStyler or not ...
Indeed but not that way. Either the ShoutPackage should install a different styler, or the toolset should push a new styler. We should not have such tests now that we have a NullStyler. Stef
Updates: Status: Accepted Comment #5 on issue 3715 by stephane...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 in the shout initialize or load method we should have something like PluggableTextMorph shoutStylerClass: SHTextStylerST80 PluggableTextMorph>>shoutedStyler shoutStylerClass ifNil: [ ^ self nullStyler] ifNotNil: [^ self shoutStylerClass new view: self]
Updates: Status: FixProposed Comment #6 on issue 3715 by Benjamin...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 Once this fix is integrated, you can load the last version of shout :) Attachments: BetterImplementationOfShouting.1.cs 2.2 KB
Comment #7 on issue 3715 by Benjamin...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 Done Attachments: BetterImplementationOfShouting.2.cs 2.0 KB
Updates: Status: Closed Comment #8 on issue 3715 by stephane...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 in 13110
Comment #9 on issue 3715 by stephane...@gmail.com: Workspace shouting after switching between shout/unshout http://code.google.com/p/pharo/issues/detail?id=3715 Benjamin you should talk with igor about using class new.
participants (2)
-
pharo＠googlecode.com -
Stéphane Ducasse