Hi Thierry, On 28 Oct 2013, at 11:31, Goubier Thierry <thierry.goubier@cea.fr> wrote:

Le 28/10/2013 11:18, Sven Van Caekenberghe a écrit :

...

Thierry,

ZnUrl now implements #mcRepositoryAsUser:withPassword: though it is currently a hack. Do you have a suggestion how to make it extendable ? I will think about it as well, I do have some ideas.

Well, I would just move the schemeName on the repository class and add a fromUrl:asUser:withPassword: in the repository instance creation, and change the mcRepositoryAsUser:withPassword: to search among repository types based on the scheme in the url and dispatch with a call to fromUrl:asUser:withPassword: on the right repository class.

Sounds like an excellent idea/design. The dispatching/searching could be done on all subclasses of MCRepository, maybe using a more general #handlesUrl: method that for now just says ^ url scheme = #http but is general enough for potential special cases in the future. Having an instanciation class method on MCRepository subclasses like #fromUrl: would then do the actual action. The fact that username/password are passed as arguments while they could be part of the url is strange, but maybe necessary since you might not want them in the url proper - but the url can be freely manipulated (like safeUrl := url copy; username: nil; password: nil; yourself). Now, your idea solves the problem entirely external to ZnUrl itself, maybe it will hinder portability of Monticello itself (but the version in Pharo is probably customised anyway) ? My idea was to have some kind of global registry for actions to be performed on ZnUrl, the arguments being the url, an operation name, and an optional argument, ZnUrl>>#performOperation:withArgs: - To register a handler you specify a selection block, ZnUrl class>>#registerOperationWhen:do: For example, there is currently ZnUrl>>#resolve which should work differently on file urls. ZnUrl>>#resolve ^ self performOperation: #resolve withArgs: nil ZnUrl registerOperationWhen: [ :url :operation :args | (url scheme = #http | url scheme = #https) & operation = #resolve ] do: [ :url :args | ZnClient new beOneShot; enforceHttpSuccess: true; get: self ]. ZnUrl registerOperationWhen: [ :url :operation :args | url scheme = #file | operation = #resolve ] do: [ :url :args | url asFileReference contents ]. #performOperation:with: would search for a handler whose condition block matches and then execute it. But I am not 100% sure about this idea myself ;-) It is extendable but is require registration which can be a bit brittle. Sven

Thierry

...

Sven

On 28 Oct 2013, at 11:18, Goubier Thierry <thierry.goubier@cea.fr> wrote:

...

Hi All,

Url has been deprecated. What is to be done with the Monticello use of the subclasses of Url?

At the moment, ZnUrl has a hardcoded case switch to redirect on the right type of repository [1], but... It's not extendable, and breaks gitfiletree://.

[1] https://github.com/pharo-project/pharo-core/blob/e89b4ac70d5cef761667317d58a...

Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

On 28 Oct 2013, at 11:19, phil@highoctane.be wrote:

FWIW I also have serious issues with MetacelloToolBox against an FTP repository.

We should remove FTP. FTP is evil: the passed is passed in the clear, it is old, it makes problems with NAT and firewalls. FTP should *not* be used in 2013! Marcus

+1 to FTP. Esteban A. Maringolo 2013/10/28 phil@highoctane.be <phil@highoctane.be>

FTP is easy, and setting up a monticello repo like this takes no time. Especially on whatever shared hosting account, my NAS, on my own box where I can share the package-cache folder that way.

And it can be browsed as well.

I am not in the mood of maintaining an STH instance with mongo and friends.

I tried filetree and gitfiletree but those weren't supporting my workflow easily enough (and for some reason, I got a corrupt something w/ Bitbucket which let me fight with it for a full damn day).

Keep FTP alive.

Phil