Automatic Refactoring Disranging Seaside Rest Methods
Hello everyone, When you copy an image or sometimes when you make a Metacello commit, your methods are automatically refactored. This uncleanse the code (replacing context meaningfull variable names with gereric identifiers) and prevents seaside request parameters . Which are mapped to method parameters by uri strings: ToDoHandler>>searchFor: aString <get> <path: '/search?query={aString}'> ^ String streamContents: [ :stream | ToDoList default items do: [ :each | (each title includesSubString: aString) ifTrue: [ stream nextPutAll: each title; crlf ] ] ] will become: ToDoHandler>>searchFor: arg1 <get> <path: '/search?query={aString}'> ^ String streamContents: [ :arg2| ToDoList default items do: [ :arg3| (each title includesSubString: aString) ifTrue: [ arg2 nextPutAll: arg3 title; crlf ] ] ] So will end having a Parameter not found exception because arg1 and aString mismatche. Is there a way to disable automatic refactoring? Lionel -- View this message in context: http://forum.world.st/Automatic-Refactoring-Disranging-Seaside-Rest-Methods-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
I saw this happening only when the image cannot find the sources file, so it has to decompile the methods. On Mon, Jul 17, 2017 at 7:34 PM, lionelakue <lionelakue@gmail.com> wrote:
Hello everyone,
When you copy an image or sometimes when you make a Metacello commit, your methods are automatically refactored.
This uncleanse the code (replacing context meaningfull variable names with gereric identifiers) and prevents seaside request parameters . Which are mapped to method parameters by uri strings:
ToDoHandler>>searchFor: aString <get> <path: '/search?query={aString}'>
^ String streamContents: [ :stream | ToDoList default items do: [ :each | (each title includesSubString: aString) ifTrue: [ stream nextPutAll: each title; crlf ] ] ]
will become:
ToDoHandler>>searchFor: arg1 <get> <path: '/search?query={aString}'> ^ String streamContents: [ :arg2| ToDoList default items do: [ :arg3| (each title includesSubString: aString) ifTrue: [ arg2 nextPutAll: arg3 title; crlf ] ] ]
So will end having a Parameter not found exception because arg1 and aString mismatche.
Is there a way to disable automatic refactoring?
Lionel
-- View this message in context: http://forum.world.st/Automatic-Refactoring- Disranging-Seaside-Rest-Methods-tp4955422.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Now I can remember reading about this somewhere(wrongly remembered it as automatic refactoring)... I have this problem when I have to copy my image to pharocloud by example. You need to zip your .image file and load it to the cloud. what I am doing now is to replace my in-uri string parameters with the excepted arg1, arg2 etc. So is this the only solution? since the behavior is not voluntary. gcotelli wrote
I saw this happening only when the image cannot find the sources file, so it has to decompile the methods.
On Mon, Jul 17, 2017 at 7:34 PM, lionelakue <
lionelakue@
> wrote:
Hello everyone,
When you copy an image or sometimes when you make a Metacello commit, your methods are automatically refactored.
This uncleanse the code (replacing context meaningfull variable names with gereric identifiers) and prevents seaside request parameters . Which are mapped to method parameters by uri strings:
ToDoHandler>>searchFor: aString
<get>
<path: '/search?query={aString}'>
^ String streamContents: [ :stream | ToDoList default items do: [ :each | (each title includesSubString: aString) ifTrue: [ stream nextPutAll: each title; crlf ] ] ]
will become:
ToDoHandler>>searchFor: arg1
<get>
<path: '/search?query={aString}'>
^ String streamContents: [ :arg2| ToDoList default items do: [ :arg3| (each title includesSubString: aString) ifTrue: [ arg2 nextPutAll: arg3 title; crlf ] ] ]
So will end having a Parameter not found exception because arg1 and aString mismatche.
Is there a way to disable automatic refactoring?
Lionel
-- View this message in context: http://forum.world.st/Automatic-Refactoring- Disranging-Seaside-Rest-Methods-tp4955422.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- View this message in context: http://forum.world.st/Automatic-Refactoring-Disranging-Seaside-Rest-Methods-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
As Gabriel notes, it looks like your missing the .sources file. I don't know what pharocloud supports, but you could try packaging your image and your .sources file into the same ZIP archive. Cheers, Max On 18 July 2017 at 02:21:54, lionelakue (lionelakue@gmail.com) wrote: Now I can remember reading about this somewhere(wrongly remembered it as automatic refactoring)... I have this problem when I have to copy my image to pharocloud by example. You need to zip your .image file and load it to the cloud. what I am doing now is to replace my in-uri string parameters with the excepted arg1, arg2 etc. So is this the only solution? since the behavior is not voluntary. gcotelli wrote
I saw this happening only when the image cannot find the sources file, so it has to decompile the methods.
On Mon, Jul 17, 2017 at 7:34 PM, lionelakue <
lionelakue@
> wrote:
Hello everyone,
When you copy an image or sometimes when you make a Metacello commit, your methods are automatically refactored.
This uncleanse the code (replacing context meaningfull variable names with gereric identifiers) and prevents seaside request parameters . Which are mapped to method parameters by uri strings:
ToDoHandler>>searchFor: aString
<get>
<path: '/search?query={aString}'>
^ String streamContents: [ :stream | ToDoList default items do: [ :each | (each title includesSubString: aString) ifTrue: [ stream nextPutAll: each title; crlf ] ] ]
will become:
ToDoHandler>>searchFor: arg1
<get>
<path: '/search?query={aString}'>
^ String streamContents: [ :arg2| ToDoList default items do: [ :arg3| (each title includesSubString: aString) ifTrue: [ arg2 nextPutAll: arg3 title; crlf ] ] ]
So will end having a Parameter not found exception because arg1 and aString mismatche.
Is there a way to disable automatic refactoring?
Lionel
-- View this message in context: http://forum.world.st/Automatic-Refactoring- Disranging-Seaside-Rest-Methods-tp4955422.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- View this message in context: http://forum.world.st/Automatic-Refactoring-Disranging-Seaside-Rest-Methods-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Lionel when the system does find a source, it decompiles the method and this is why you get the code changed. Stef On Tue, Jul 18, 2017 at 7:22 AM, Max Leske <maxleske@gmail.com> wrote:
As Gabriel notes, it looks like your missing the .sources file. I don't know what pharocloud supports, but you could try packaging your image and your .sources file into the same ZIP archive.
Cheers, Max
On 18 July 2017 at 02:21:54, lionelakue (lionelakue@gmail.com) wrote:
Now I can remember reading about this somewhere(wrongly remembered it as automatic refactoring)...
I have this problem when I have to copy my image to pharocloud by example.
You need to zip your .image file and load it to the cloud.
what I am doing now is to replace my in-uri string parameters with the excepted arg1, arg2 etc.
So is this the only solution? since the behavior is not voluntary.
gcotelli wrote
I saw this happening only when the image cannot find the sources file, so it has to decompile the methods.
On Mon, Jul 17, 2017 at 7:34 PM, lionelakue <
lionelakue@
> wrote:
Hello everyone,
When you copy an image or sometimes when you make a Metacello commit, your methods are automatically refactored.
This uncleanse the code (replacing context meaningfull variable names with gereric identifiers) and prevents seaside request parameters . Which are mapped to method parameters by uri strings:
ToDoHandler>>searchFor: aString
<get>
<path: '/search?query={aString}'>
^ String streamContents: [ :stream | ToDoList default items do: [ :each | (each title includesSubString: aString) ifTrue: [ stream nextPutAll: each title; crlf ] ] ]
will become:
ToDoHandler>>searchFor: arg1
<get>
<path: '/search?query={aString}'>
^ String streamContents: [ :arg2| ToDoList default items do: [ :arg3| (each title includesSubString: aString) ifTrue: [ arg2 nextPutAll: arg3 title; crlf ] ] ]
So will end having a Parameter not found exception because arg1 and aString mismatche.
Is there a way to disable automatic refactoring?
Lionel
-- View this message in context: http://forum.world.st/Automatic-Refactoring- Disranging-Seaside-Rest-Methods-tp4955422.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- View this message in context: http://forum.world.st/Automatic-Refactoring-Disranging-Seaside-Rest-Methods-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Thank you all. The system was in fact missing the sources. I zipped my .image and .changes files together for the cloud. Lionel -- View this message in context: http://forum.world.st/Automatic-Refactoring-Disranging-Seaside-Rest-Methods-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Gabriel Cotelli -
lionelakue -
Max Leske -
Stephane Ducasse