[Pharo-project] Issue 3470 in pharo: [Failing Tests] OBKeyBindingsTest
Status: Accepted Owner: marcus.denker Labels: Milestone-1.3 New issue 3470 by marcus.denker: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470
OB.Tests.Morphic.OBKeyBindingsTest.testBrowseIt 0.339 13 OB.Tests.Morphic.OBKeyBindingsTest.testImplementorsOfIt 0.387 13 OB.Tests.Morphic.OBKeyBindingsTest.testReferencesToIt 0.254 13 OB.Tests.Morphic.OBKeyBindingsTest.testSendersOfIt 0.273 13
Updates: Labels: -Milestone-1.3 Milestone-1.2-DevImage Comment #1 on issue 3470 by marcus.denker: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 (No comment was entered for this change.)
Updates: Cc: renggli Comment #2 on issue 3470 by marianopeck: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 Hi Lukas. I was checking the 4 failing tests in Pharo 1.2: http://code.google.com/p/pharo/issues/detail?id=3470 The problem seems related to the changes with the SmalltalkEditor/ParagraphEditor and friends. The tests fails because the instVar "message" is nil, because nobody call OBKeyBindingsTest >> browseIt: aSelector nor its friends. This was called in Pharo 1.1 from OBTextMorphEditor because it was a subclass of ParagraphEditor. Now, I have no idea how to make it work in Pharo 1.2 Cheers mariano
Comment #3 on issue 3470 by panu.j.m...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 If one changes OBTextMorph>>#editorClass to return OBTextMorphEditor instead of SmalltalkEditor the OBKeyBindingsTest will pass. But I am don't know what are the consequences of this change.
Updates: Labels: Type-OB Comment #4 on issue 3470 by marcus.d...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 (No comment was entered for this change.)
Comment #5 on issue 3470 by marcus.d...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 Issue 3619 has been merged into this issue.
Comment #6 on issue 3470 by marcus.d...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 Issue 3619 proposed a fix (I merged it into this report)
Updates: Status: FixProposed Comment #7 on issue 3470 by marcus.d...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 (No comment was entered for this change.)
Comment #8 on issue 3470 by stephane...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 Can we publish in OB repository? What is the solution? Should we clone the repository?
Comment #9 on issue 3470 by guillerm...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 I'll publish it in pharo task forces
Updates: Status: Fixed Comment #10 on issue 3470 by guillerm...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 803 Tests green / 803 Tests for OB I published the change in Pharo task forces and updated the ConfigurationOfOmnibrowser in MetacelloRepository
Updates: Status: Closed Comment #11 on issue 3470 by marcus.d...@gmail.com: [Failing Tests] OBKeyBindingsTest http://code.google.com/p/pharo/issues/detail?id=3470 in build #117
participants (1)
-
pharo＠googlecode.com