[Pharo-project] Suggestions: move examples from UIThemes class to ExampleBuilderMorph class
A couple of suggestions Part 1. Move the methods in the UIThemes class, protocol 'examples' to ExampleBuilderMorph class, protocol 'examples'. Rationale: Every one of these examples first creates an instance of ExampleBuilderMorph as the base class that the example is built on. These examples do not demonstrate anything about how to use UITheme. I made a file that duplicates the methods from UITheme class -examples- to ExampleBuilderMorph class -examples-, suitable for filein. Methods such as ExampleBuilderMorph class >>exampleBasicControls work fine, indicating they have no dependence on UITheme. The file's 347 lines, so I'm not posting it here, unless requested. Part 2. Then move ExampleBuilderMorph and ExampleRadioButtonModel from Polymorph-Widgets into a new package called Polymorph-Widgets-Examples. Rationale: This would be reduce the size of Polymorph-Widgets, and make it more obvious that there are some examples of the widgets to look at. UITheme class is not the place where one expects to find examples of buttons, checkboxes, etc. Also this would be consistent with other Morphic packages. (Morphic-MorphTreeWidget and Morphic-MorphTreeWidget-Examples) --- -- View this message in context: http://forum.world.st/Suggestions-move-examples-from-UIThemes-class-to-Examp... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
edmund enter bug entries else your suggestions will be lost. Stef On Apr 25, 2011, at 8:56 PM, DougEdmunds wrote:
A couple of suggestions
Part 1. Move the methods in the UIThemes class, protocol 'examples' to ExampleBuilderMorph class, protocol 'examples'.
Rationale: Every one of these examples first creates an instance of ExampleBuilderMorph as the base class that the example is built on. These examples do not demonstrate anything about how to use UITheme.
I made a file that duplicates the methods from UITheme class -examples- to ExampleBuilderMorph class -examples-, suitable for filein. Methods such as ExampleBuilderMorph class >>exampleBasicControls work fine, indicating they have no dependence on UITheme. The file's 347 lines, so I'm not posting it here, unless requested.
Part 2. Then move ExampleBuilderMorph and ExampleRadioButtonModel from Polymorph-Widgets into a new package called Polymorph-Widgets-Examples.
Rationale: This would be reduce the size of Polymorph-Widgets, and make it more obvious that there are some examples of the widgets to look at. UITheme class is not the place where one expects to find examples of buttons, checkboxes, etc. Also this would be consistent with other Morphic packages. (Morphic-MorphTreeWidget and Morphic-MorphTreeWidget-Examples)
---
-- View this message in context: http://forum.world.st/Suggestions-move-examples-from-UIThemes-class-to-Examp... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
http://www.pharo-project.org/community/issue-tracking http://www.pharocasts.com/2010/03/how-to-contribute-to-pharo.html On Tue, Apr 26, 2011 at 9:44 AM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
edmund
enter bug entries else your suggestions will be lost.
Stef
On Apr 25, 2011, at 8:56 PM, DougEdmunds wrote:
A couple of suggestions
Part 1. Move the methods in the UIThemes class, protocol 'examples' to ExampleBuilderMorph class, protocol 'examples'.
Rationale: Every one of these examples first creates an instance of ExampleBuilderMorph as the base class that the example is built on. These examples do not demonstrate anything about how to use UITheme.
I made a file that duplicates the methods from UITheme class -examples- to ExampleBuilderMorph class -examples-, suitable for filein. Methods such as ExampleBuilderMorph class >>exampleBasicControls work fine, indicating they have no dependence on UITheme. The file's 347 lines, so I'm not posting it here, unless requested.
Part 2. Then move ExampleBuilderMorph and ExampleRadioButtonModel from Polymorph-Widgets into a new package called Polymorph-Widgets-Examples.
Rationale: This would be reduce the size of Polymorph-Widgets, and make it more obvious that there are some examples of the widgets to look at. UITheme class is not the place where one expects to find examples of buttons, checkboxes, etc. Also this would be consistent with other Morphic packages. (Morphic-MorphTreeWidget and Morphic-MorphTreeWidget-Examples)
---
-- View this message in context: http://forum.world.st/Suggestions-move-examples-from-UIThemes-class-to-Examp... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
-- Mariano http://marianopeck.wordpress.com
participants (3)
-
DougEdmunds -
Mariano Martinez Peck -
Stéphane Ducasse