[Pharo-project] Re: Missing #dispatchResultsIntoHistory
Hi Damien, Just to make sure that I fully understand your email. Are you suggesting the history feature should be integrated into the Standard SUnit? I haven't got the time to check what is in Testing@squeaksource yet. I hope to do it before next week. Keith, do you think it is a good idea to include the history feature in Testing? Cheers, Alexandre On 3 Dec 2008, at 10:30, Damien Cassou wrote:
Hi Alex,
OBCmdTestClass>>updateTestHistoryWith: sends #dispatchResultsIntoHistory to its parameter but this method is not implemented in Squeak 3.10.2. Could you please integrate your changes to the SUnit-Improved package at http://www.squeaksource.com/Testing?
Thank you
-- Damien Cassou http://damiencassou.seasidehosting.st
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Wed, Dec 3, 2008 at 2:49 PM, Alexandre Bergel <alexandre@bergel.eu> wrote:
Just to make sure that I fully understand your email. Are you suggesting the history feature should be integrated into the Standard SUnit? I haven't got the time to check what is in Testing@squeaksource yet. I hope to do it before next week.
I'm not suggesting anything. I just would like that the testing features you have implemented one year ago continue to work in Squeak. Currently, I can't run the tests from the browser anymore because of this missing method. -- Damien Cassou http://damiencassou.seasidehosting.st
On Wed, Dec 3, 2008 at 2:49 PM, Alexandre Bergel <alexandre@bergel.eu> wrote:
Just to make sure that I fully understand your email. Are you suggesting the history feature should be integrated into the Standard SUnit? I haven't got the time to check what is in Testing@squeaksource yet. I hope to do it before next week.
I'm not suggesting anything. I just would like that the testing features you have implemented one year ago continue to work in Squeak. Currently, I can't run the tests from the browser anymore because of this missing method.
The problem we are facing right now is that OB-Enhancements is at the moment dependent on a particular version of SUnit, one that contains these history enhancements. As OB-Enhancements is supposed to work in Pharo and Squeak, we can now either update the SUnit version in Squeak-dev to also use your work on test history (which would make sense to me) or I can change OB-Enhancements to test whether the history-aware SUnit is loaded or not... David
So, it seems that adding an empty dispatchResultsIntoHistory in Testing@SS will prevent having two versions of OBCmdTestClass I will do it in a minutes... Alexandre On 3 Dec 2008, at 10:53, Damien Cassou wrote:
On Wed, Dec 3, 2008 at 2:49 PM, Alexandre Bergel <alexandre@bergel.eu> wrote:
Just to make sure that I fully understand your email. Are you suggesting the history feature should be integrated into the Standard SUnit? I haven't got the time to check what is in Testing@squeaksource yet. I hope to do it before next week.
I'm not suggesting anything. I just would like that the testing features you have implemented one year ago continue to work in Squeak. Currently, I can't run the tests from the browser anymore because of this missing method.
-- Damien Cassou http://damiencassou.seasidehosting.st
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
The problem we are facing right now is that OB-Enhancements is at the moment dependent on a particular version of SUnit, one that contains these history enhancements. As OB-Enhancements is supposed to work in Pharo and Squeak, we can now either update the SUnit version in Squeak-dev to also use your work on test history (which would make sense to me) or I can change OB-Enhancements to test whether the history-aware SUnit is loaded or not...
This seems to be a cleaner solution to me. Else, people may wonder why there is an empty dispatchResultsIntoHistory defined somewhere (even with an appropriate note). Actually, simply testing whether this method exist should be sufficient. I am doing it now... Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
participants (3)
-
Alexandre Bergel -
Damien Cassou -
David Röthlisberger