[Pharo-project] alert: not defined on non-interactive ui manager
Hi all alert:, alert:title:... are defined on MorphicUIManager but not on NonInteractiveUIManager so this means that we get DNU when loading packages that call it. http://code.google.com/p/pharo/issues/detail?id=7205 I thought that bringing a pop up or dun in non interactive mode was killing the system but not. I'm confused but any how it would be good to have these two classes a bit more polymorphic so tell me if I'm saying something stupid. Stef
Hi, alert, abort, question, etc. are defined on MorphicUIManager (with a trait) but not on UIManager itself. As Stephane said, it may causes DNU when using a NonInteractiveUIManager. For example, if you try to update a version of KeyMapping in non interactive mode, it will failed because the load method defines a post-load action using alert (see ConfigurationOfKeyMapping>resetKeymapsAndWarn). So, should we define these methods as "subclass responsability" on UIManager or do I miss something? Regards, Christophe. Le 2 janv. 2013 à 16:05, Stéphane Ducasse a écrit :
Hi all
alert:, alert:title:... are defined on MorphicUIManager but not on NonInteractiveUIManager so this means that we get DNU when loading packages that call it.
http://code.google.com/p/pharo/issues/detail?id=7205
I thought that bringing a pop up or dun in non interactive mode was killing the system but not. I'm confused but any how it would be good to have these two classes a bit more polymorphic so tell me if I'm saying something stupid.
Stef
On 2 January 2013 16:05, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi all
alert:, alert:title:... are defined on MorphicUIManager but not on NonInteractiveUIManager so this means that we get DNU when loading packages that call it.
http://code.google.com/p/pharo/issues/detail?id=7205
I thought that bringing a pop up or dun in non interactive mode was killing the system but not. I'm confused but any how it would be good to have these two classes a bit more polymorphic so tell me if I'm saying something stupid.
Stef
When i first added NonInteractiveUIManager , i made sure that all protocol in UIManager is supported. Then, people adding more stuff to MorphicUIManager without: a) declaring new protocol in abstract UIManager and describing intended behavior there b) making sure it works (or has default behavior) in rest of classes, not just MorphicUIManager UI manager has too many responsibilities. But it is hard to see how we can avoid that. -- Best regards, Igor Stasenko.
alert:, alert:title:... are defined on MorphicUIManager but not on NonInteractiveUIManager so this means that we get DNU when loading packages that call it.
http://code.google.com/p/pharo/issues/detail?id=7205
I thought that bringing a pop up or dun in non interactive mode was killing the system but not. I'm confused but any how it would be good to have these two classes a bit more polymorphic so tell me if I'm saying something stupid.
Stef
When i first added NonInteractiveUIManager , i made sure that all protocol in UIManager is supported. Then, people adding more stuff to MorphicUIManager without:
I do not think that we added anything to MorphicUIManager. May be⦠when we merged some code of gary.
a) declaring new protocol in abstract UIManager and describing intended behavior there b) making sure it works (or has default behavior) in rest of classes, not just MorphicUIManager
UI manager has too many responsibilities. But it is hard to see how we can avoid that
It would be good to have a look at the protocol and see if we can deprecate one or two. But then in addition we can add placeholders in nonInteractive⦠Stef
participants (3)
-
Christophe Demarey -
Igor Stasenko -
Stéphane Ducasse