Re: [Pharo-project] I hate 'as yet unclassified'
In Pharo 20498, sorted by author in the method timestamp: gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
holy s**t , 35! and I'm more or less a maniac of classification :P On Jan 30, 2013, at 2:02 PM, Stephan Eggermont <stephan@stack.nl> wrote:
In Pharo 20498, sorted by author in the method timestamp:
gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
I think that classification is a matter of time and maturity of what you are doing. When I'm programming, using TDD or in the debugger, I don't care about categorization, I don't want to be stopped or slowed down by that. But before I commit the code, I run SmallLint and solve all the uncategorized methods. That is the time when I have the whole picture and can do a better categorization. So having a "not categorized yet" category for me is fine, it is part of the iterative development process. I would not change the tools, but I would force during the integration that no package will be integrated if it has uncategorized methods, the same if it has smalllint errors (at least errors, no possible errors). Hernan. On Wed, Jan 30, 2013 at 10:07 AM, Esteban Lorenzano <estebanlm@gmail.com>wrote:
holy s**t , 35!
and I'm more or less a maniac of classification :P
On Jan 30, 2013, at 2:02 PM, Stephan Eggermont <stephan@stack.nl> wrote:
In Pharo 20498, sorted by author in the method timestamp:
gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
-- *Hernán Wilkinson Agile Software Development, Teaching & Coaching* *Phone: +54 - 011 - *6091 - 3125* Mobile: +54 - 911 - 4470 - 7207 email: hernan.wilkinson@10Pines.com site: http://www.10Pines.com <http://www.10pines.com/>* Address: Alem 693, Floor 5 B, Buenos Aires, Argentina
Hernan Wilkinson wrote:
I think that classification is a matter of time and maturity of what you are doing. When I'm programming, using TDD or in the debugger, I don't care about categorization, I don't want to be stopped or slowed down by that. But before I commit the code, I run SmallLint and solve all the uncategorized methods. That is the time when I have the whole picture and can do a better categorization.
Interesting. My own standard practice with Monticello is to always first click the <Changes> button to help me summarize what this commit is about. Sometimes I see a leftover 'self halt' or Transcript and jump back to clean that up before saving. If Monticello had a <SmallLint> button, then I think I would make great use of it to clean up just prior committing a package revision. cheers -ben
Sorry! Mostly me... Regards, Gary ----- Original Message ----- From: "Esteban Lorenzano" <estebanlm@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Wednesday, January 30, 2013 1:07 PM Subject: Re: [Pharo-project] I hate 'as yet unclassified'
holy s**t , 35!
and I'm more or less a maniac of classification :P
On Jan 30, 2013, at 2:02 PM, Stephan Eggermont <stephan@stack.nl> wrote:
In Pharo 20498, sorted by author in the method timestamp:
gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
Ben On Jan 30, 2013, at 2:02 PM, Stephan Eggermont <stephan@stack.nl> wrote:
In Pharo 20498, sorted by author in the method timestamp:
gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
Euh, I want to fix some of them ! Stephan, Could you express this query in executable code ? I am guessing you did this with Moose ? Can it be done in plain Smalltalk ? Sven On 30 Jan 2013, at 14:02, Stephan Eggermont <stephan@stack.nl> wrote:
In Pharo 20498, sorted by author in the method timestamp:
gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
On 30 Jan 2013, at 15:08, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Can it be done in plain Smalltalk ?
Something crude like this: OrderedCollection streamContents: [ :stream | Object withAllSubclassesDo: [ :eachClass | stream nextPutAll: (eachClass methods select: [ :each | each category = #'as yet unclassified' ]) ] ]. OrderedCollection streamContents: [ :stream | Object withAllSubclassesDo: [ :eachClass | stream nextPutAll: (eachClass methods select: [ :each | each category = #'nil' ]) ] ]. It is then possible to subselect on author. But blaming people who contribute (a lot) might not be the best strategy. Often the author is the one who last changed a method, the missing categorisation was probably already there. Also, creating methods from certain tools makes then automatically uncategorised⦠Sven -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill
I'm not blaming, blaming is not interesting. I want to fix them. - automatically as much as possible - with social pressure ie CATEGORISE ME PLEASE
But blaming people who contribute (a lot) might not be the best strategy. Often the author is the one who last changed a method, the missing categorisation was probably already there. Also, creating methods from certain tools makes then automatically uncategorisedâ¦
such queries do not mean much because people change code. Anyway. I spent time on categorizing methods when I do not have my brain on to do something useful. Stef
In Pharo 20498, sorted by author in the method timestamp:
gvc 1550 AlainPlantec 320 216 GaryChambers 215 CamilloBruni 163 IgorStasenko 159 stephaneducasse 152 avi 148 Igor.Stasenko 128 StephaneDucasse 85 SeanDeNigris 81 MarcusDenker 78 ab 75 GuillermoPolito 68 tween 52 BenjaminVanRyseghem 51 ar 46 di 40 RAA 38 alain.plantec 38 EstebanLorenzano 35 FernandoOlivero 33 nice 31 tk 29 nk 28 cwp 26 dvf 22 rr 20 PavelKrivanek 18 MarianoMartinezPeck 18 yo 18 sd 18 bf 16 SvenVanCaekenberghe 16 JMM 16 marcus.denker 14 wiz 12 ajh 12 mjr 12 cipt 10 abc 10 md 10 HenrikSperreJohansen 9 MikeRoberts 8 AndyKellens 6 LukasRenggli 6 noha 6 ClementBera 6 jrd 6 GastonDallOglio 6 2011-01-24T15:34:00+01:00 6 DeboraFortini 5 stephane.ducasse 5 lr 5 2011-01-24T15:33:00+01:00 4 dgd 4 DamienCassou 4 TestRunner 4 bkv 4 BG 4 Alexandre 4 AndrewBlack 4 sw 4 SimonAllier 3 DanielAvivEstebanAllende 3 ASB 2 mas 2 pmm 2 simondenier 2 BernardoContreras 2 th 2 damienpollet 2 NicoPaez 2 CamilloBrui 2 sps 2 MiguelCoba 2 eem 2 NikoSchwarz 2 JavierPimas 2 GabrielOmarCotelli 2 mir 2 ul 2 2011-01-24T15:50:00+01:00 2 jf 2 c 2 ls 2 al 2 NorbertHartl 2 djp 2 AdrianLienhard 2 TorstenBergmann 2 AlexandreBergel 2 tbn 2 DiogenesMoreira 2 GuyHylton 1 ThierryGoubier 1
participants (8)
-
Ben Coman -
Benjamin -
Esteban Lorenzano -
Gary Chambers -
Hernan Wilkinson -
Stephan Eggermont -
Stéphane Ducasse -
Sven Van Caekenberghe