- I moved all the code to the FileSystemGitDev team on Smalltalkhub - we now have a working LibGit2 build (tests fail but that will be fixed in the coming days) - we got simple fetch working yesterday (yay!) - we (which means Stefan) started rewriting our tests with SUnit, moving away from Phexample (for several reasons) Todayâs program: - migrate more tests - fix initialization and setup issues - try to perform a complete fetch + merge (without conflicts) - implement clone - try to get push working Have a great day! Cheers, Max
Good to see this progress! Thanks for your effort. Uko On 19 Mar 2014, at 08:46, Max Leske <maxleske@gmail.com> wrote:
- I moved all the code to the FileSystemGitDev team on Smalltalkhub - we now have a working LibGit2 build (tests fail but that will be fixed in the coming days) - we got simple fetch working yesterday (yay!) - we (which means Stefan) started rewriting our tests with SUnit, moving away from Phexample (for several reasons)
Todayâs program: - migrate more tests - fix initialization and setup issues - try to perform a complete fetch + merge (without conflicts) - implement clone - try to get push working
Have a great day!
Cheers, Max
+1 On 19 Mar 2014, at 08:53, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Good to see this progress! Thanks for your effort.
Uko
On 19 Mar 2014, at 08:46, Max Leske <maxleske@gmail.com> wrote:
- I moved all the code to the FileSystemGitDev team on Smalltalkhub - we now have a working LibGit2 build (tests fail but that will be fixed in the coming days) - we got simple fetch working yesterday (yay!) - we (which means Stefan) started rewriting our tests with SUnit, moving away from Phexample (for several reasons)
Todayâs program: - migrate more tests - fix initialization and setup issues - try to perform a complete fetch + merge (without conflicts) - implement clone - try to get push working
Have a great day!
Cheers, Max
Le 19/03/2014 08:46, Max Leske a écrit :
- I moved all the code to the FileSystemGitDev team on Smalltalkhub - we now have a working LibGit2 build (tests fail but that will be fixed in the coming days) - we got simple fetch working yesterday (yay!) - we (which means Stefan) started rewriting our tests with SUnit, moving away from Phexample (for several reasons)
Todayâs program: - migrate more tests - fix initialization and setup issues - try to perform a complete fetch + merge (without conflicts) - implement clone - try to get push working
Have a great day!
With such news, it is a great day :) Thanks for the effort, Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
+1.. Keep going :) Doru On Wed, Mar 19, 2014 at 9:43 AM, Goubier Thierry <thierry.goubier@cea.fr>wrote:
Le 19/03/2014 08:46, Max Leske a écrit :
- I moved all the code to the FileSystemGitDev team on Smalltalkhub
- we now have a working LibGit2 build (tests fail but that will be fixed in the coming days) - we got simple fetch working yesterday (yay!) - we (which means Stefan) started rewriting our tests with SUnit, moving away from Phexample (for several reasons)
Today's program: - migrate more tests - fix initialization and setup issues - try to perform a complete fetch + merge (without conflicts) - implement clone - try to get push working
Have a great day!
With such news, it is a great day :)
Thanks for the effort,
Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- www.tudorgirba.com "Every thing has its own flow"
Max Leske wrote
rewriting our tests with SUnit, moving away from Phexample (for several reasons)
I'm curious about those reasons... ----- Cheers, Sean -- View this message in context: http://forum.world.st/FileSystem-Git-status-update-2-tp4749696p4749970.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
So am I :). Doru On Thu, Mar 20, 2014 at 2:33 PM, Sean P. DeNigris <sean@clipperadams.com>wrote:
Max Leske wrote
rewriting our tests with SUnit, moving away from Phexample (for several reasons)
I'm curious about those reasons...
----- Cheers, Sean -- View this message in context: http://forum.world.st/FileSystem-Git-status-update-2-tp4749696p4749970.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- www.tudorgirba.com "Every thing has its own flow"
On 20 Mar 2014, at 14:33, Sean P. DeNigris <sean@clipperadams.com> wrote:
Max Leske wrote
rewriting our tests with SUnit, moving away from Phexample (for several reasons)
I'm curious about those reasonsâ¦
I donât know Max reasons, but I can give you mine: FSGit based on libgit2 will be a part of the system while phexample will not, so we need sunit tests to keep it in sync with the rest of pharo :) Esteban
----- Cheers, Sean -- View this message in context: http://forum.world.st/FileSystem-Git-status-update-2-tp4749696p4749970.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Mar 20, 2014, at 9:43 AM, EstebanLM [via Smalltalk] <ml-node+s1294792n4749977h75@n4.nabble.com> wrote:
phexample will not⦠be a part of the system
Iâd love to standardize on a cutting edge testing framework. There have been so many great ideas (think ruby rspec) in recent times. Right now we have a chicken and egg problem... On one hand we canât express ourselves in ways that are: 1) easy to write 2) document the usage of our code i.e. easy for users to understand, and 3) reduce duplication On the other hand, we canât use libraries that help us do these things for core code. Thus, IMHO - core tests are often the poorest. My must-haves are: - mocks - phexemple-like building-on-previous-test - partial stubs - tables for input My wish list would be a real UI, taking advantage of Smalltalkâs strength, instead of leaning on the code browser and class structure, which are implementation details which constrain our thought unnecessarily. ----- Cheers, Sean -- View this message in context: http://forum.world.st/FileSystem-Git-status-update-2-tp4749696p4749982.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 20.03.2014, at 14:33, Sean P. DeNigris <sean@clipperadams.com> wrote:
Max Leske wrote
rewriting our tests with SUnit, moving away from Phexample (for several reasons)
I'm curious about those reasonsâ¦
I think that Phexample is pretty cool and I enjoyed writing tests with it (yes, devs donât usually say that about writing tests :) ). As Esteban said, we donât want to introduce the dependency to Phexample because of the integration. But that is only one reason. Personally I have three issues with Phexample: 1. the more complex a project becomes, the more complex the dependencies between tests get (in my case, chain lengths of 8 - 10). Problems this causes: 1.a there is no visual cue for the dependencies, so you have to try your best with protocols and naming but it just gets very confusing 1.b it becomes more likely to introduce cycles (which often crash your imageâ¦) 1.c it becomes more likely to introduce errors *because of* dependencies (e.g. because I used the wrong selector) and since you assume the dependencies to be fine⦠2. #setUp and #tearDown are executed for every test *even if the test is a dependency*. But in my case I depend on the state that has been established by a test (so maybe I misused Phexample. Unit tests should be self contained. But then again, if they were self contained, would there be a need for dependenciesâ¦?). But that state is destroyed by #setUp and #tearDown. Then again, I *do* need to initialize and destroy some stuff sometimes (which I could to manually, I know; just saying). 3. Especially if you test things that run longer than a couple of milliseconds, the test execution time will grow very fast because of the dependencies. Every test will be run by the suite (n) + every test in a dependency chain (0 < m < inf). That amounts to roughly ~ O(n^2), which is fine for short tests but not if you have longer running tests in there So my take away message from Phexample is: itâs cool to work with and you become pretty fast. Phexample is also cool for TDD because it lets you focus on the problem at hand and everything als can just be assumed to be #given:. But: I would only recommend it for small projects / projects with low complexity (or low number of dependencies). Git has notoriously many dependencies, so I might also just be an outlier (or I may not have understood how Phexample is supposed to work). Sean, regarding your proposal, I am *not* happy with SUnit, so Iâm very happy about any ideas you have :) Cheers, Max
----- Cheers, Sean -- View this message in context: http://forum.world.st/FileSystem-Git-status-update-2-tp4749696p4749970.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (7)
-
Esteban Lorenzano -
Goubier Thierry -
Max Leske -
Pharo4Stef -
Sean P. DeNigris -
Tudor Girba -
Yuriy Tymchuk