[Pharo-project] Issue 3454 in pharo: DNU when looking for implementors in OB on 1.2dev
Status: Accepted Owner: luc.fabresse Labels: Milestone-1.2-DevImage Type-ReportDefect New issue 3454 by luc.fabresse: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 Looking for implementors in 1.2 dev (#12281) from OBBrowser raise a DNU. in OBTextMorphEditorWithShout>>send:toModelWith:orDo: self terminateAndInitializeAround: ... but terminateAndInitializeAround is implemented in ParagraphEditor which is not a super class of OBTextMorphEditorWithShout.
Updates: Cc: renggli Comment #1 on issue 3454 by marianopeck: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 (No comment was entered for this change.)
Comment #2 on issue 3454 by marcus.denker: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 The following failing tests look related to that:
OB.Tests.Morphic.OBKeyBindingsTest.testBrowseIt 0.332 10 OB.Tests.Morphic.OBKeyBindingsTest.testImplementorsOfIt 0.384 10 OB.Tests.Morphic.OBKeyBindingsTest.testReferencesToIt 0.248 10 OB.Tests.Morphic.OBKeyBindingsTest.testSendersOfIt 0.265 10
Comment #3 on issue 3454 by luc.fabresse: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 I don't think that it is related. If I modify like that: OBTextMorphEditorWithShout>>send: aSelector toModelWith: args orDo: aBlock "self terminateAndInitializeAround: <--- COMMENTED BECAUSE DNU" [(model respondsTo: aSelector) ifTrue: [(model perform: aSelector withArguments: args) ifFalse: [self flash]] ifFalse: [aBlock value]] value it works! I can show implementors with cmd-m ... without any error but the 4 tests on OB are still yellow.
Comment #4 on issue 3454 by luc.fabresse: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 Concerning the 4 failing tests. The running test case OBKeyBindingsTest register itself as the model of a OBPluggableTextMorph to check if it receives the callback messages (implementorsOfIt:, ...) when a shortcut is pressed. And it didn't. Events seem to propagate well but at the end the callback messages are sent to a SmalltalkEditor not the model. Not sure it is clear ;-) To sum up, probably there is something wrong with event management.
Comment #5 on issue 3454 by guillermopolito: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 ParagraphEditor uses #terminateAndInitializeAround: a lot. Just look at its senders :) Maybe it is ok to remove that call...
Comment #6 on issue 3454 by guillermopolito: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 I mean, SmalltalkEditor does not use it.
Updates: Cc: -renggli Comment #7 on issue 3454 by luc.fabresse: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 Yes I don't know the impact of removing the #terminateAndInitializeAround: message send. That's why I did not provide a fix.
Updates: Status: Closed Comment #8 on issue 3454 by marcus.denker: DNU when looking for implementors in OB on 1.2dev http://code.google.com/p/pharo/issues/detail?id=3454 works in version 21.12.2010
participants (1)
-
pharo＠googlecode.com