[Pharo-project] Issue 3620 in pharo: Settings: OCompletion settings appear twice
Status: Accepted Owner: laurent....@gmail.com New issue 3620 by laurent....@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Pharo image: dev 1.2 Steps to reproduce: 1. open settings 2. in search field type 'compl' then enter 3. OCompletion settings appear twice
Comment #1 on issue 3620 by laurent....@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Fix (naive) here: SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
On Fri, 28 Jan 2011, pharo@googlecode.com wrote:
Comment #1 on issue 3620 by laurent....@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620
Fix (naive) here: SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
The actual problem is that SettingsBrowser is showing Squeak's pragma preferences as Pharo's system settings. See SettingTreeBuilder >> #preference:category:description:type: for the implementation. I see three possible scenarios to resolve this issue: 1. Your fix will be accepted (which implies that OCompletion will be forked). 2. We remove ECPreferences class >> #settingsOn: from OCompletion. 3. You remove SettingTreeBuilder >> #preference:category:description:type: from Pharo. Levente
On Fri, 28 Jan 2011, pharo@googlecode.com wrote:
Comment #1 on issue 3620 by laurent....@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620
Fix (naive) here: SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
The actual problem is that SettingsBrowser is showing Squeak's pragma preferences as Pharo's system settings. See SettingTreeBuilder >> #preference:category:description:type: for the implementation.
I see three possible scenarios to resolve this issue: 1. Your fix will be accepted (which implies that OCompletion will be forked). 2. We remove ECPreferences class >> #settingsOn: from OCompletion. 3. You remove SettingTreeBuilder >> #preference:category:description:type: from Pharo.
Le 29/01/2011 00:16, Levente Uzonyi a écrit : 4. Maybe it's also possible to remove duplicated entries (so just a UI problem). Cheers Alain
Levente
But why the UI collects the squeak preferences?
Comment #1 on issue 3620 by laurent....@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620
Fix (naive) here: SLICE-Issue-3620-Settings-OCompletion-settings-appear-twice-LaurentLaffont.1
The actual problem is that SettingsBrowser is showing Squeak's pragma preferences as Pharo's system settings. See SettingTreeBuilder >> #preference:category:description:type: for the implementation.
I see three possible scenarios to resolve this issue: 1. Your fix will be accepted (which implies that OCompletion will be forked). 2. We remove ECPreferences class >> #settingsOn: from OCompletion. 3. You remove SettingTreeBuilder >> #preference:category:description:type: from Pharo.
Levente
Updates: Status: FixProposed Labels: Milestone-1.2-DevImage Comment #2 on issue 3620 by marcus.d...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 (No comment was entered for this change.)
Comment #3 on issue 3620 by guillerm...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Only pragmas were removed. Should I Integrate it? I think it looks ok.
Comment #4 on issue 3620 by marcus.d...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 yes
Comment #5 on issue 3620 by marcus.d...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 So who commits this? me?
Comment #6 on issue 3620 by stephane...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 No idea but it would be good to move on this front. Guillermo who is your fuse? Esteban?
Comment #7 on issue 3620 by guillerm...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 These are OCompletion changes... I can move them into PharoTaskForces tonight. Will that do it?
Comment #8 on issue 3620 by stephane...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Why not in the OCompletion repository?
Comment #9 on issue 3620 by ryd...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 I don't think you'll be able to successfully push a change which would remove access to the preference in Squeak to the OCompletion repository. Probably better to change the Settings Browser UI to not display settings defined in both ways (<systemsettings> and <preference:category:...> )twice.
Comment #10 on issue 3620 by guillerm...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Yep, I' don't want to break squeak compatibility unless it's completely necessary... I guess that if we have to change the settings pragma collector, it's not fixed yet :)
Updates: Status: Accepted Comment #11 on issue 3620 by marcus.d...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 So what is the *simplest* *easiest* workaround for this so that we can actually release 1.2?
Comment #12 on issue 3620 by tudor.gi...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 As far as I understand, there is no simple solution. Could we not leave with this for 1.2?
Comment #13 on issue 3620 by stephane...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 yes.
Comment #14 on issue 3620 by marcus.d...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Levente suggests to fork it for 1.2: The fork would be the same as the latest version without the selectors containting pragma preferences. Then open a new issue for 1.3 about the duplicates appearing in the Settings Browser.
Updates: Labels: -Milestone-1.2-DevImage Milestone-1.3 Comment #15 on issue 3620 by stephane...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 (No comment was entered for this change.)
Updates: Labels: -Milestone-1.3 Milestone-1.3-DevImage Comment #16 on issue 3620 by marcus.d...@gmail.com: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 (No comment was entered for this change.)
Updates: Status: Closed Comment #17 on issue 3620 by marianopeck: Settings: OCompletion settings appear twice http://code.google.com/p/pharo/issues/detail?id=3620 Seems fixed in ConfigurationOfOCompletion version 1.3
participants (4)
-
Alain Plantec -
Levente Uzonyi -
pharo＠googlecode.com -
Stéphane Ducasse