Should Job use SystemAnnouncer?
While profiling some progressbar code, I noticed Job uses the SystemAnnouncer. It seems odd that an Announcer used for noticing code changes is reused for something unrelated to code changes. Could we have a separate announcer for this? Stephan
I think this is a good idea, you can see that there is already an #announcer inst var that currently is unused. I think the original idea behind using the system announcer was to make other tools possible that will interact with the progress. Though nobody did it so far ;) => if it is a performance penalty remove it! Plus if there is a private announcer for each job the only announcement that really needs to go public is JobStart, from then on potential 3rd party tools can register to the internal announcer. On 2013-09-01, at 20:43, Stephan Eggermont <stephan@stack.nl> wrote:
While profiling some progressbar code, I noticed Job uses the SystemAnnouncer. It seems odd that an Announcer used for noticing code changes is reused for something unrelated to code changes. Could we have a separate announcer for this?
Stephan
did you notice a different between SystemAnnouncer and replacing it by another one? On Sep 1, 2013, at 8:43 PM, Stephan Eggermont <stephan@stack.nl> wrote:
While profiling some progressbar code, I noticed Job uses the SystemAnnouncer. It seems odd that an Announcer used for noticing code changes is reused for something unrelated to code changes. Could we have a separate announcer for this?
Stephan
Stephan Eggermont wrote
Could we have a separate announcer for this?
Are you talking about a class-side announcer or per-job? If the latter, I seem to remember it being important to be able to register for the announcements from an outer scope which may not have access tho the job object. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Should-Job-use-SystemAnnouncer-tp4706044p4707039.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Camillo Bruni -
Sean P. DeNigris -
Stephan Eggermont -
Stéphane Ducasse